From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [RFC PATCH 04/14] net/i40e: use the same Rx path across process types
Date: Fri, 25 Jul 2025 14:43:30 +0100 [thread overview]
Message-ID: <aIOKAr9LyhWf4A3v@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250725124919.3564890-5-ciara.loftus@intel.com>
On Fri, Jul 25, 2025 at 12:49:09PM +0000, Ciara Loftus wrote:
> In the interest of simplicity, let the primary process select the Rx
> path to be used by all processes using the given device.
>
> The many logs which report individual Rx path selections have been
> consolidated into one single log
>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
> drivers/net/intel/i40e/i40e_ethdev.h | 20 +++-
> drivers/net/intel/i40e/i40e_rxtx.c | 168 ++++++++++++---------------
> 2 files changed, 93 insertions(+), 95 deletions(-)
>
> diff --git a/drivers/net/intel/i40e/i40e_ethdev.h b/drivers/net/intel/i40e/i40e_ethdev.h
> index 44864292d0..308039c363 100644
> --- a/drivers/net/intel/i40e/i40e_ethdev.h
> +++ b/drivers/net/intel/i40e/i40e_ethdev.h
> @@ -1226,6 +1226,22 @@ struct i40e_vsi_vlan_pvid_info {
> #define I40E_MBUF_CHECK_F_TX_SEGMENT (1ULL << 2)
> #define I40E_MBUF_CHECK_F_TX_OFFLOAD (1ULL << 3)
>
> +enum i40e_rx_func_type {
> + I40E_RX_DEFAULT,
> + I40E_RX_BULK_ALLOC,
> + I40E_RX_SCATTERED,
> + I40E_RX_SSE,
> + I40E_RX_AVX2,
> + I40E_RX_SSE_SCATTERED,
> + I40E_RX_AVX2_SCATTERED,
> + I40E_RX_AVX512,
> + I40E_RX_AVX512_SCATTERED,
> + I40E_RX_NEON,
> + I40E_RX_NEON_SCATTERED,
> + I40E_RX_ALTIVEC,
> + I40E_RX_ALTIVEC_SCATTERED,
> +};
> +
As with previous patch, I'd suggest working out what the most logical order
for these elements is, and using that. Having AVX2 and SSE interleaved
seems a bit strange.
Otherwise:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2025-07-25 13:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 12:49 [RFC PATCH 00/14] net/intel: rx path selection simplification Ciara Loftus
2025-07-25 12:49 ` [RFC PATCH 01/14] net/ice: use the same Rx path across process types Ciara Loftus
2025-07-25 13:40 ` Bruce Richardson
2025-07-25 12:49 ` [RFC PATCH 02/14] net/iavf: rename Rx/Tx function type variables Ciara Loftus
2025-07-25 13:40 ` Bruce Richardson
2025-07-25 12:49 ` [RFC PATCH 03/14] net/iavf: use the same Rx path across process types Ciara Loftus
2025-07-25 13:41 ` Bruce Richardson
2025-07-25 12:49 ` [RFC PATCH 04/14] net/i40e: " Ciara Loftus
2025-07-25 13:43 ` Bruce Richardson [this message]
2025-07-25 12:49 ` [RFC PATCH 05/14] net/intel: introduce common vector capability function Ciara Loftus
2025-07-25 13:45 ` Bruce Richardson
2025-07-25 12:49 ` [RFC PATCH 06/14] net/ice: use the new " Ciara Loftus
2025-07-25 13:56 ` Bruce Richardson
2025-07-25 12:49 ` [RFC PATCH 07/14] net/iavf: " Ciara Loftus
2025-07-25 12:49 ` [RFC PATCH 08/14] net/i40e: " Ciara Loftus
2025-07-25 12:49 ` [RFC PATCH 09/14] net/iavf: remove redundant field from iavf adapter struct Ciara Loftus
2025-07-25 14:51 ` Bruce Richardson
2025-07-25 12:49 ` [RFC PATCH 10/14] net/intel: introduce infrastructure for Rx path selection Ciara Loftus
2025-07-25 15:21 ` Bruce Richardson
2025-07-25 12:49 ` [RFC PATCH 11/14] net/ice: remove unsupported Rx offload Ciara Loftus
2025-07-25 15:22 ` Bruce Richardson
2025-07-25 12:49 ` [RFC PATCH 12/14] net/ice: use the common Rx path selection infrastructure Ciara Loftus
2025-07-25 12:49 ` [RFC PATCH 13/14] net/iavf: " Ciara Loftus
2025-07-25 12:49 ` [RFC PATCH 14/14] net/i40e: " Ciara Loftus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIOKAr9LyhWf4A3v@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).