Re: [PATCH v2 2/6] ipsec: replace unnecessary comma operator

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Aug 14, 2025 at 02:28:48PM -0700, Stephen Hemminger wrote:
> Use of comma as statement separator is discouraged and
> reported as warning by clang with -Wcomma
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/ipsec/misc.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/ipsec/misc.h b/lib/ipsec/misc.h
> index fd4d3f5256..54dc5c2d4d 100644
> --- a/lib/ipsec/misc.h
> +++ b/lib/ipsec/misc.h
> @@ -126,7 +126,8 @@ cpu_crypto_bulk(const struct rte_ipsec_session *ss,
>  
>  	const uint32_t vnum = RTE_DIM(vec);
>  
> -	j = 0, n = 0;
> +	j = 0;
> +	n = 0;
>  	vofs = 0;
>  	for (i = 0; i != num; i++) {
>  

A better fix here is to move the assignments up to where the variables are
defined just 9 lines earlier, rather than wasting code lines by assigning
to zero later on!