From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>
Subject: Re: [PATCH v2 5/6] app/testpmd: replace comma operator with bracket
Date: Mon, 18 Aug 2025 09:05:36 +0100 [thread overview]
Message-ID: <aKLe0I8337-tXlnL@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250814212901.88863-6-stephen@networkplumber.org>
On Thu, Aug 14, 2025 at 02:28:51PM -0700, Stephen Hemminger wrote:
> Use while with brackets in favor of comma operator.
>
> In flow print replace with temporary variable.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> app/test-pmd/cmdline_flow.c | 6 ++++--
> app/test-pmd/config.c | 10 ++++++----
> 2 files changed, 10 insertions(+), 6 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2025-08-18 8:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 23:26 [RFC 0/7] avoid unnecessary use of comma op Stephen Hemminger
2025-03-12 23:26 ` [RFC 1/7] eal: replace unnecessary comma operator Stephen Hemminger
2025-03-12 23:26 ` [RFC 2/7] ipsec: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 3/7] graph: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 4/7] net/mlx4: replace unnecessary comma operators Stephen Hemminger
2025-03-12 23:27 ` [RFC 5/7] net/mlx5: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 6/7] test: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 7/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 0/6] Enable warnings about use of comma operator Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 1/6] eal: replace unnecessary " Stephen Hemminger
2025-08-15 13:48 ` Konstantin Ananyev
2025-08-18 7:59 ` Bruce Richardson
2025-08-14 21:28 ` [PATCH v2 2/6] ipsec: " Stephen Hemminger
2025-08-15 13:47 ` Konstantin Ananyev
2025-08-18 8:00 ` Bruce Richardson
2025-08-18 8:14 ` Morten Brørup
2025-08-14 21:28 ` [PATCH v2 3/6] graph: " Stephen Hemminger
2025-08-15 13:49 ` Konstantin Ananyev
2025-08-18 8:01 ` Bruce Richardson
2025-08-14 21:28 ` [PATCH v2 4/6] test: replace unnecessary comma operators Stephen Hemminger
2025-08-15 13:50 ` Konstantin Ananyev
2025-08-18 8:02 ` Bruce Richardson
2025-08-14 21:28 ` [PATCH v2 5/6] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-18 8:05 ` Bruce Richardson [this message]
2025-08-14 21:28 ` [PATCH v2 6/6] config: enable comma warnings Stephen Hemminger
2025-08-15 14:00 ` Konstantin Ananyev
2025-08-15 0:30 ` [PATCH v2 0/6] Enable warnings about use of comma operator fengchengwen
2025-08-15 6:40 ` Morten Brørup
2025-08-15 16:15 ` Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 0/7] avoid unnecessary " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 1/7] eal: replace unnecessary " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 2/7] ipsec: " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 3/7] graph: " Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 4/7] test: replace unnecessary comma operators Stephen Hemminger
2025-08-16 7:37 ` Morten Brørup
2025-08-15 16:26 ` [PATCH v3 5/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 6/7] examples: remove unnecessary use of comma operator Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 7/7] config: enable comma warnings Stephen Hemminger
2025-08-16 7:45 ` [PATCH v3 0/7] avoid unnecessary use of comma operator Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKLe0I8337-tXlnL@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).