From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v2] net/ice: make link state configurable on device close
Date: Mon, 8 Sep 2025 12:00:54 +0100 [thread overview]
Message-ID: <aL63ZoyNsi1hKyyC@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250829094523.1582102-1-ciara.loftus@intel.com>
On Fri, Aug 29, 2025 at 09:45:23AM +0000, Ciara Loftus wrote:
> Introduce the device argument link_state_on_close for the ice driver.
> When the device is stopped or closed, the link state will be configured
> as follows for each of the three options:
> 1. down: bring (or keep) the link down
> 2. up: bring (or keep) the link up
> 3. initial: restore the link to the state it was in when the device
> started.
>
> Prior to this commit the default behaviour was to always restore the
> link to its initial state. The new default behaiour is to always bring
> the link down, which is in keeping with most other drivers.
>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2025-09-08 11:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 10:23 [PATCH] net/ice: make link state configurable on device stop Ciara Loftus
2025-08-28 10:35 ` Bruce Richardson
2025-08-28 14:55 ` Stephen Hemminger
2025-08-29 9:46 ` Loftus, Ciara
2025-08-29 9:45 ` [PATCH v2] net/ice: make link state configurable on device close Ciara Loftus
2025-09-08 11:00 ` Bruce Richardson [this message]
2025-09-08 11:05 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL63ZoyNsi1hKyyC@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).