From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v2 2/4] net/i40e: fix vector Rx queue set up logic
Date: Thu, 4 Sep 2025 17:31:01 +0100 [thread overview]
Message-ID: <aLm-xbiGNldcFG3S@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250902104859.2100141-3-ciara.loftus@intel.com>
On Tue, Sep 02, 2025 at 10:48:57AM +0000, Ciara Loftus wrote:
> The logic to set up a vector Rx queue was present in two places, before
> and after the Rx path was selected. In some cases, the rx queue would
> have been set up for vector Rx twice. Another scenario could occur where
> first the queue was set up for vector rx, then the scalar path selected
> but the vector rx setup would still persist. This of course would be
> incorrect behaviour, so it has been fixed by removing the setup logic
> that was before the path select code.
>
> Fixes: 052ae311091c ("net/i40e: use the common Rx path selection infrastructure")
I think this code is mostly from an older commit, which is why I'd mark
this instead as:
Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage")
>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2025-09-04 16:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 9:59 [PATCH] net/i40e: fix supported offloads for Rx vector path Ciara Loftus
2025-09-02 8:08 ` David Marchand
2025-09-02 10:24 ` Loftus, Ciara
2025-09-02 10:48 ` [PATCH v2 0/4] Fixes for net/intel Rx Path Selection Ciara Loftus
2025-09-02 10:48 ` [PATCH v2 1/4] net/i40e: fix supported offloads for Rx vector path Ciara Loftus
2025-09-04 16:29 ` Bruce Richardson
2025-09-02 10:48 ` [PATCH v2 2/4] net/i40e: fix vector Rx queue set up logic Ciara Loftus
2025-09-04 16:31 ` Bruce Richardson [this message]
2025-09-02 10:48 ` [PATCH v2 3/4] net/i40e: remove redundant vector Rx queue setup code Ciara Loftus
2025-09-04 16:47 ` Bruce Richardson
2025-09-02 10:48 ` [PATCH v2 4/4] net/iavf: remove duplicate in scalar offload list Ciara Loftus
2025-09-04 16:52 ` Bruce Richardson
2025-09-04 16:53 ` [PATCH v2 0/4] Fixes for net/intel Rx Path Selection Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLm-xbiGNldcFG3S@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).