Re: [RFC PATCH 3/6] ethdev: remove queue stats from ethdev stats structure

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Sep 24, 2025 at 09:37:18AM +0200, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> > Sent: Tuesday, 23 September 2025 16.12
> > 
> > The queue stats part of the rte_eth_stats structure has been deprecated
> > for many years now, since 2020 [1]. Therefore we look to remove these
> > fields from the stats structure.
> > 
> > Unfortunately, the flag introduced by the deprecation,
> > "RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS", means that for drivers using it we
> > still have to return queue stats from the driver stats_get function.
> > This means that we need a new parameter for those stats as part of the
> > stats_get interface. The autofill flag is set for 35 drivers, which
> > means that if we didn't do so, users of those 35 drivers would lose all
> > ability to get per-queue stats.
> > 
> > [1] Commit a72cb3e7656a ("doc: announce queue stats moving to xstats")
> > 	https://github.com/DPDK/dpdk/commit/a72cb3e
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Thank you for finally attacking this, Bruce.
> 
> A few documentation comments and a bugfix inline below.
>

Thanks for the review and good catch on the bug. Will fix in later
versions.

/Bruce