[PATCH] hash: fix build error due to missing include

[PATCH] hash: fix build error due to missing include

[Bruce Richardson]

The file "rte_thash.c" uses the rte_cpu_get_flag_enabled() API but does
not include "rte_cpuflags.h". Add the include to fix build issues this
causes:

../lib/hash/rte_thash.c: In function ‘rte_thash_gfni_supported’:
../lib/hash/rte_thash.c:79:13: error: implicit declaration of function
‘rte_cpu_get_flag_enabled’ [-Wimplicit-function-declaration]
   79 |         if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_GFNI) &&
         |             ^~~~~~~~~~~~~~~~~~~~~~~~

Fixes: d8f0f514428e ("eal/x86: remove useless include from spinlock header")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/hash/rte_thash.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c
index 0f9ed20d0d..fcd41248b9 100644
--- a/lib/hash/rte_thash.c
+++ b/lib/hash/rte_thash.c
@@ -14,6 +14,7 @@
 #include <rte_eal_memconfig.h>
 #include <rte_log.h>
 #include <rte_malloc.h>
+#include <rte_cpuflags.h>
 
 RTE_LOG_REGISTER_SUFFIX(thash_logtype, thash, INFO);
 #define RTE_LOGTYPE_HASH thash_logtype
-- 
2.48.1

Re: [PATCH] hash: fix build error due to missing include

[Thomas Monjalon]

24/09/2025 17:48, Bruce Richardson:
> The file "rte_thash.c" uses the rte_cpu_get_flag_enabled() API but does
> not include "rte_cpuflags.h". Add the include to fix build issues this
> causes:
> 
> ../lib/hash/rte_thash.c: In function ‘rte_thash_gfni_supported’:
> ../lib/hash/rte_thash.c:79:13: error: implicit declaration of function
> ‘rte_cpu_get_flag_enabled’ [-Wimplicit-function-declaration]
>    79 |         if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_GFNI) &&
>          |             ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: d8f0f514428e ("eal/x86: remove useless include from spinlock header")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

How is that possible that I don't see this error in my compilations?

Re: [PATCH] hash: fix build error due to missing include

[Bruce Richardson]

On Wed, Sep 24, 2025 at 06:05:00PM +0200, Thomas Monjalon wrote:
> 24/09/2025 17:48, Bruce Richardson:
> > The file "rte_thash.c" uses the rte_cpu_get_flag_enabled() API but does
> > not include "rte_cpuflags.h". Add the include to fix build issues this
> > causes:
> > 
> > ../lib/hash/rte_thash.c: In function ‘rte_thash_gfni_supported’:
> > ../lib/hash/rte_thash.c:79:13: error: implicit declaration of function
> > ‘rte_cpu_get_flag_enabled’ [-Wimplicit-function-declaration]
> >    79 |         if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_GFNI) &&
> >          |             ^~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Fixes: d8f0f514428e ("eal/x86: remove useless include from spinlock header")
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> How is that possible that I don't see this error in my compilations?
> 
Seems this code is only included when building with GFNI instructions
enabled. :-(

/Bruce

Re: [PATCH] hash: fix build error due to missing include

[Thomas Monjalon]

24/09/2025 18:05, Thomas Monjalon:
> 24/09/2025 17:48, Bruce Richardson:
> > The file "rte_thash.c" uses the rte_cpu_get_flag_enabled() API but does
> > not include "rte_cpuflags.h". Add the include to fix build issues this
> > causes:
> > 
> > ../lib/hash/rte_thash.c: In function ‘rte_thash_gfni_supported’:
> > ../lib/hash/rte_thash.c:79:13: error: implicit declaration of function
> > ‘rte_cpu_get_flag_enabled’ [-Wimplicit-function-declaration]
> >    79 |         if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_GFNI) &&
> >          |             ^~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Fixes: d8f0f514428e ("eal/x86: remove useless include from spinlock header")
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> How is that possible that I don't see this error in my compilations?

That's because we see it only on CPU having GFNI.

Applied, thanks.