From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH 0/8] Fixes for ice and iavf docs
Date: Mon, 29 Sep 2025 11:57:52 +0100 [thread overview]
Message-ID: <aNpmMEnJdmkArKxj@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250916142113.3485738-1-ciara.loftus@intel.com>
On Tue, Sep 16, 2025 at 02:21:05PM +0000, Ciara Loftus wrote:
> This series is a collection of fixes to the documentation (specifically
> the ini files) for the ice and iavf drivers.
>
> Ciara Loftus (8):
> net/ice: document support for free Tx mbuf on demand
> net/ice: fix documentation of support for TSO
> net/iavf: fix documentation for speed capabilities
> net/iavf: document support for fast mbuf free
> net/iavf: document support for free Tx mbuf on demand
> net/iavf: document support for burst mode info
> net/iavf: fix documentation of support for TSO
> net/iavf: document support for extended statistics
>
> doc/guides/nics/features/iavf.ini | 7 +++++--
> doc/guides/nics/features/ice.ini | 3 ++-
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> --
When reviewing these, I'm not convinced about using "P" (Partial) as a flag
to indicate features that don't work on vector drivers. Since the feature
is present in the driver and works - all be it with a perf hit, as happens
with many features, even those that don't change the actual Rx/Tx function
chosen - I think it should be marked as just "Y", and that using "P" is
confusing. Can we maybe investigate other options here, maybe a footnote or
asterisk on the entry that says: "May not be present in all Rx/Tx paths, for
example, may force driver to use scalar, rather than vector, code paths"
Since the rest of the changes are trivial, I've just applied the other
five patches, (1, 3, 5, 6, 8) to next-net-intel, rather than carry a whole
series through multiple versions.
Thanks,
/Bruce
prev parent reply other threads:[~2025-09-29 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 14:21 Ciara Loftus
2025-09-16 14:21 ` [PATCH 1/8] net/ice: document support for free Tx mbuf on demand Ciara Loftus
2025-09-24 13:48 ` Bruce Richardson
2025-09-16 14:21 ` [PATCH 2/8] net/ice: fix documentation of support for TSO Ciara Loftus
2025-09-16 14:21 ` [PATCH 3/8] net/iavf: fix documentation for speed capabilities Ciara Loftus
2025-09-24 13:54 ` Bruce Richardson
2025-09-16 14:21 ` [PATCH 4/8] net/iavf: document support for fast mbuf free Ciara Loftus
2025-09-16 14:21 ` [PATCH 5/8] net/iavf: document support for free Tx mbuf on demand Ciara Loftus
2025-09-24 13:54 ` Bruce Richardson
2025-09-16 14:21 ` [PATCH 6/8] net/iavf: document support for burst mode info Ciara Loftus
2025-09-24 13:57 ` Bruce Richardson
2025-09-16 14:21 ` [PATCH 7/8] net/iavf: fix documentation of support for TSO Ciara Loftus
2025-09-16 14:21 ` [PATCH 8/8] net/iavf: document support for extended statistics Ciara Loftus
2025-09-24 13:57 ` Bruce Richardson
2025-09-29 10:57 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNpmMEnJdmkArKxj@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).