[PATCH 0/8] Fixes for ice and iavf docs

[PATCH 0/8] Fixes for ice and iavf docs

[Ciara Loftus]

This series is a collection of fixes to the documentation (specifically
the ini files) for the ice and iavf drivers.

Ciara Loftus (8):
  net/ice: document support for free Tx mbuf on demand
  net/ice: fix documentation of support for TSO
  net/iavf: fix documentation for speed capabilities
  net/iavf: document support for fast mbuf free
  net/iavf: document support for free Tx mbuf on demand
  net/iavf: document support for burst mode info
  net/iavf: fix documentation of support for TSO
  net/iavf: document support for extended statistics

 doc/guides/nics/features/iavf.ini | 7 +++++--
 doc/guides/nics/features/ice.ini  | 3 ++-
 2 files changed, 7 insertions(+), 3 deletions(-)

-- 
2.34.1

[PATCH 1/8] net/ice: document support for free Tx mbuf on demand

[Ciara Loftus]

The free tx mbuf on demand feature has been supported since commit
ab7cfe1fe3d7 ("net/ice: cleanup Tx buffers"). Update the list of
supported features to reflect this.

Fixes: ab7cfe1fe3d7 ("net/ice: cleanup Tx buffers")
Cc: stable@dpdk.org

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 doc/guides/nics/features/ice.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini
index 9c8569740a..2703493514 100644
--- a/doc/guides/nics/features/ice.ini
+++ b/doc/guides/nics/features/ice.ini
@@ -14,6 +14,7 @@ Link status event    = Y
 FEC                  = Y
 Rx interrupt         = Y
 Fast mbuf free       = P
+Free Tx mbuf on demand = Y
 Queue start/stop     = Y
 Burst mode info      = Y
 Power mgmt address monitor = Y
-- 
2.34.1

[PATCH 2/8] net/ice: fix documentation of support for TSO

[Ciara Loftus]

TSO is only supported by the scalar path in the ice driver. Update the
documentation to reflect this partial support.

Fixes: f88de4694d94 ("net/ice: support Tx SSE vector")
Cc: stable@dpdk.org

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 doc/guides/nics/features/ice.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini
index 2703493514..f6439fde35 100644
--- a/doc/guides/nics/features/ice.ini
+++ b/doc/guides/nics/features/ice.ini
@@ -21,7 +21,7 @@ Power mgmt address monitor = Y
 MTU update           = Y
 Buffer split on Rx   = P
 Scattered Rx         = Y
-TSO                  = Y
+TSO                  = P
 Promiscuous mode     = Y
 Allmulticast mode    = Y
 Unicast MAC filter   = Y
-- 
2.34.1

[PATCH 3/8] net/iavf: fix documentation for speed capabilities

[Ciara Loftus]

The iavf PMD does not report the speed capabilities that the device is
capable of in the speed_capa field of the rte_eth_dev_info struct. The
documentation incorrectly stated this feature as supported. Fix this.

Fixes: 48de41ca11f0 ("net/avf: enable link status update")
Cc: stable@dpdk.org

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 doc/guides/nics/features/iavf.ini | 1 -
 1 file changed, 1 deletion(-)

diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
index 61c4742197..4ce4dc5a88 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -7,7 +7,6 @@
 ; is selected.
 ;
 [Features]
-Speed capabilities   = Y
 Link status          = Y
 Rx interrupt         = Y
 Queue start/stop     = Y
-- 
2.34.1

[PATCH 4/8] net/iavf: document support for fast mbuf free

[Ciara Loftus]

The fast mbuf free feature has been partially supported since commit
9ab9514c150e ("net/iavf: enable AVX512 for Tx"). Update the list of
supported features to reflect this.

Fixes: 9ab9514c150e ("net/iavf: enable AVX512 for Tx")
Cc: stable@dpdk.org

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 doc/guides/nics/features/iavf.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
index 4ce4dc5a88..aac27bd706 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -9,6 +9,7 @@
 [Features]
 Link status          = Y
 Rx interrupt         = Y
+Fast mbuf free       = P
 Queue start/stop     = Y
 Runtime Rx queue setup = Y
 Runtime Tx queue setup = Y
-- 
2.34.1

[PATCH 5/8] net/iavf: document support for free Tx mbuf on demand

[Ciara Loftus]

The free tx mbuf on demand feature has been supported since commit
86e44244f95c ("net/iavf: cleanup Tx buffers"). Update the list of
supported features to reflect this.

Fixes: 86e44244f95c ("net/iavf: cleanup Tx buffers")
Cc: stable@dpdk.org

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 doc/guides/nics/features/iavf.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
index aac27bd706..4e4c5cc817 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -10,6 +10,7 @@
 Link status          = Y
 Rx interrupt         = Y
 Fast mbuf free       = P
+Free Tx mbuf on demand = Y
 Queue start/stop     = Y
 Runtime Rx queue setup = Y
 Runtime Tx queue setup = Y
-- 
2.34.1

[PATCH 6/8] net/iavf: document support for burst mode info

[Ciara Loftus]

The burst mode info feature has been supported since commit 0d5a856f5be9
("net/iavf: support Rx/Tx burst mode info"). Update the list of
supported features to reflect this.

Fixes: 0d5a856f5be9 ("net/iavf: support Rx/Tx burst mode info")
Cc: stable@dpdk.org

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 doc/guides/nics/features/iavf.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
index 4e4c5cc817..7420432840 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -14,6 +14,7 @@ Free Tx mbuf on demand = Y
 Queue start/stop     = Y
 Runtime Rx queue setup = Y
 Runtime Tx queue setup = Y
+Burst mode info      = Y
 Power mgmt address monitor = Y
 MTU update           = Y
 Scattered Rx         = Y
-- 
2.34.1

[PATCH 7/8] net/iavf: fix documentation of support for TSO

[Ciara Loftus]

TSO is only supported by the scalar path in the iavf driver. Update the
documentation to reflect this partial support.

Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
Cc: stable@dpdk.org

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 doc/guides/nics/features/iavf.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
index 7420432840..63c89ee28f 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -18,7 +18,7 @@ Burst mode info      = Y
 Power mgmt address monitor = Y
 MTU update           = Y
 Scattered Rx         = Y
-TSO                  = Y
+TSO                  = P
 Promiscuous mode     = Y
 Allmulticast mode    = Y
 Unicast MAC filter   = Y
-- 
2.34.1

[PATCH 8/8] net/iavf: document support for extended statistics

[Ciara Loftus]

The extended statistics feature has been implemented since commit
d38a06bf4367 ("net/iavf: add extended stats"). Update the list of
supported features to reflect this.

Fixes: d38a06bf4367 ("net/iavf: add extended stats")
Cc: stable@dpdk.org

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 doc/guides/nics/features/iavf.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
index 63c89ee28f..74c1910ca3 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -41,6 +41,7 @@ Packet type parsing  = Y
 Rx descriptor status = Y
 Tx descriptor status = Y
 Basic stats          = Y
+Extended stats       = Y
 Multiprocess aware   = Y
 FreeBSD              = Y
 Linux                = Y
-- 
2.34.1

Re: [PATCH 1/8] net/ice: document support for free Tx mbuf on demand

[Bruce Richardson]

On Tue, Sep 16, 2025 at 02:21:06PM +0000, Ciara Loftus wrote:
> The free tx mbuf on demand feature has been supported since commit
> ab7cfe1fe3d7 ("net/ice: cleanup Tx buffers"). Update the list of
> supported features to reflect this.
> 
> Fixes: ab7cfe1fe3d7 ("net/ice: cleanup Tx buffers")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
>  doc/guides/nics/features/ice.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH 3/8] net/iavf: fix documentation for speed capabilities

[Bruce Richardson]

On Tue, Sep 16, 2025 at 02:21:08PM +0000, Ciara Loftus wrote:
> The iavf PMD does not report the speed capabilities that the device is
> capable of in the speed_capa field of the rte_eth_dev_info struct. The
> documentation incorrectly stated this feature as supported. Fix this.
> 
> Fixes: 48de41ca11f0 ("net/avf: enable link status update")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
>  doc/guides/nics/features/iavf.ini | 1 -
>  1 file changed, 1 deletion(-)
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH 5/8] net/iavf: document support for free Tx mbuf on demand

[Bruce Richardson]

On Tue, Sep 16, 2025 at 02:21:10PM +0000, Ciara Loftus wrote:
> The free tx mbuf on demand feature has been supported since commit
> 86e44244f95c ("net/iavf: cleanup Tx buffers"). Update the list of
> supported features to reflect this.
> 
> Fixes: 86e44244f95c ("net/iavf: cleanup Tx buffers")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
>  doc/guides/nics/features/iavf.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
> index aac27bd706..4e4c5cc817 100644
> --- a/doc/guides/nics/features/iavf.ini
> +++ b/doc/guides/nics/features/iavf.ini
> @@ -10,6 +10,7 @@
>  Link status          = Y
>  Rx interrupt         = Y
>  Fast mbuf free       = P
> +Free Tx mbuf on demand = Y
>  Queue start/stop     = Y
>  Runtime Rx queue setup = Y
>  Runtime Tx queue setup = Y
> -- 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH 6/8] net/iavf: document support for burst mode info

[Bruce Richardson]

On Tue, Sep 16, 2025 at 02:21:11PM +0000, Ciara Loftus wrote:
> The burst mode info feature has been supported since commit 0d5a856f5be9
> ("net/iavf: support Rx/Tx burst mode info"). Update the list of
> supported features to reflect this.
> 
> Fixes: 0d5a856f5be9 ("net/iavf: support Rx/Tx burst mode info")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
>  doc/guides/nics/features/iavf.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH 8/8] net/iavf: document support for extended statistics

[Bruce Richardson]

On Tue, Sep 16, 2025 at 02:21:13PM +0000, Ciara Loftus wrote:
> The extended statistics feature has been implemented since commit
> d38a06bf4367 ("net/iavf: add extended stats"). Update the list of
> supported features to reflect this.
> 
> Fixes: d38a06bf4367 ("net/iavf: add extended stats")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
>  doc/guides/nics/features/iavf.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH 0/8] Fixes for ice and iavf docs

[Bruce Richardson]

On Tue, Sep 16, 2025 at 02:21:05PM +0000, Ciara Loftus wrote:
> This series is a collection of fixes to the documentation (specifically
> the ini files) for the ice and iavf drivers.
> 
> Ciara Loftus (8):
>   net/ice: document support for free Tx mbuf on demand
>   net/ice: fix documentation of support for TSO
>   net/iavf: fix documentation for speed capabilities
>   net/iavf: document support for fast mbuf free
>   net/iavf: document support for free Tx mbuf on demand
>   net/iavf: document support for burst mode info
>   net/iavf: fix documentation of support for TSO
>   net/iavf: document support for extended statistics
> 
>  doc/guides/nics/features/iavf.ini | 7 +++++--
>  doc/guides/nics/features/ice.ini  | 3 ++-
>  2 files changed, 7 insertions(+), 3 deletions(-)
> 
> -- 

When reviewing these, I'm not convinced about using "P" (Partial) as a flag
to indicate features that don't work on vector drivers. Since the feature
is present in the driver and works - all be it with a perf hit, as happens
with many features, even those that don't change the actual Rx/Tx function
chosen - I think it should be marked as just "Y", and that using "P" is
confusing. Can we maybe investigate other options here, maybe a footnote or
asterisk on the entry that says: "May not be present in all Rx/Tx paths, for
example, may force driver to use scalar, rather than vector, code paths"

Since the rest of the changes are trivial, I've just applied the other
five patches, (1, 3, 5, 6, 8) to next-net-intel, rather than carry a whole
series through multiple versions.

Thanks,
/Bruce