* [PATCH] dmadev: replace zero length array
@ 2025-10-15 18:59 Stephen Hemminger
2025-10-16 8:15 ` Bruce Richardson
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2025-10-15 18:59 UTC (permalink / raw)
To: dev
Cc: Stephen Hemminger, pbhagavatula, Chengwen Feng, Kevin Laatz,
Bruce Richardson
Use of zero length arrays is Gcc extension.
Found by zero_length_array.cocci.
Fixes: 9674119fbf27 ("dmadev: add enqueue/dequeue operations")
Cc: pbhagavatula@marvell.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/dmadev/rte_dmadev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h
index 30e168825e..8ae9ee031b 100644
--- a/lib/dmadev/rte_dmadev.h
+++ b/lib/dmadev/rte_dmadev.h
@@ -856,7 +856,7 @@ struct rte_dma_op {
/** Number of destination segments. */
uint16_t nb_dst;
/** Source and destination segments. */
- struct rte_dma_sge src_dst_seg[0];
+ struct rte_dma_sge src_dst_seg[];
};
#ifdef __cplusplus
--
2.47.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dmadev: replace zero length array
2025-10-15 18:59 [PATCH] dmadev: replace zero length array Stephen Hemminger
@ 2025-10-16 8:15 ` Bruce Richardson
2025-10-16 9:47 ` Morten Brørup
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2025-10-16 8:15 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, pbhagavatula, Chengwen Feng, Kevin Laatz
On Wed, Oct 15, 2025 at 11:59:46AM -0700, Stephen Hemminger wrote:
> Use of zero length arrays is Gcc extension.
> Found by zero_length_array.cocci.
>
> Fixes: 9674119fbf27 ("dmadev: add enqueue/dequeue operations")
> Cc: pbhagavatula@marvell.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/dmadev/rte_dmadev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h
> index 30e168825e..8ae9ee031b 100644
> --- a/lib/dmadev/rte_dmadev.h
> +++ b/lib/dmadev/rte_dmadev.h
> @@ -856,7 +856,7 @@ struct rte_dma_op {
> /** Number of destination segments. */
> uint16_t nb_dst;
> /** Source and destination segments. */
> - struct rte_dma_sge src_dst_seg[0];
> + struct rte_dma_sge src_dst_seg[];
> };
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] dmadev: replace zero length array
2025-10-16 8:15 ` Bruce Richardson
@ 2025-10-16 9:47 ` Morten Brørup
2025-10-16 9:50 ` Pavan Nikhilesh Bhagavatula
0 siblings, 1 reply; 4+ messages in thread
From: Morten Brørup @ 2025-10-16 9:47 UTC (permalink / raw)
To: Bruce Richardson, Stephen Hemminger
Cc: dev, pbhagavatula, Chengwen Feng, Kevin Laatz
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Thursday, 16 October 2025 10.15
>
> On Wed, Oct 15, 2025 at 11:59:46AM -0700, Stephen Hemminger wrote:
> > Use of zero length arrays is Gcc extension.
> > Found by zero_length_array.cocci.
> >
> > Fixes: 9674119fbf27 ("dmadev: add enqueue/dequeue operations")
> > Cc: pbhagavatula@marvell.com
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > lib/dmadev/rte_dmadev.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h
> > index 30e168825e..8ae9ee031b 100644
> > --- a/lib/dmadev/rte_dmadev.h
> > +++ b/lib/dmadev/rte_dmadev.h
> > @@ -856,7 +856,7 @@ struct rte_dma_op {
> > /** Number of destination segments. */
> > uint16_t nb_dst;
> > /** Source and destination segments. */
> > - struct rte_dma_sge src_dst_seg[0];
> > + struct rte_dma_sge src_dst_seg[];
> > };
> >
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dmadev: replace zero length array
2025-10-16 9:47 ` Morten Brørup
@ 2025-10-16 9:50 ` Pavan Nikhilesh Bhagavatula
0 siblings, 0 replies; 4+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2025-10-16 9:50 UTC (permalink / raw)
To: Morten Brørup, Bruce Richardson, Stephen Hemminger
Cc: dev, Chengwen Feng, Kevin Laatz
>> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
>> Sent: Thursday, 16 October 2025 10.15
>>
>> On Wed, Oct 15, 2025 at 11:59:46AM -0700, Stephen Hemminger wrote:
>> > Use of zero length arrays is Gcc extension.
>> > Found by zero_length_array.cocci.
>> >
>> > Fixes: 9674119fbf27 ("dmadev: add enqueue/dequeue operations")
>> > Cc: pbhagavatula@marvell.com
>> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> > ---
>> > lib/dmadev/rte_dmadev.h | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h
>> > index 30e168825e..8ae9ee031b 100644
>> > --- a/lib/dmadev/rte_dmadev.h
>> > +++ b/lib/dmadev/rte_dmadev.h
>> > @@ -856,7 +856,7 @@ struct rte_dma_op {
>> > /** Number of destination segments. */
>> > uint16_t nb_dst;
>> > /** Source and destination segments. */
>> > - struct rte_dma_sge src_dst_seg[0];
>> > + struct rte_dma_sge src_dst_seg[];
>> > };
>> >
>> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>Acked-by: Morten Brørup <mb@smartsharesystems.com>
Thanks Stephan,
Acked-by: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
We should probably add this check to CI.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-16 9:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-15 18:59 [PATCH] dmadev: replace zero length array Stephen Hemminger
2025-10-16 8:15 ` Bruce Richardson
2025-10-16 9:47 ` Morten Brørup
2025-10-16 9:50 ` Pavan Nikhilesh Bhagavatula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).