DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] Revert "net/ice: count drop-all filter in Rx stats"
@ 2025-10-20 16:42 Jeff Shaw
  2025-10-20 16:47 ` Bruce Richardson
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Shaw @ 2025-10-20 16:42 UTC (permalink / raw)
  To: dev; +Cc: Jeff Shaw, Bruce Richardson, Anatoly Burakov

This reverts commit af05f9e37153c53335938bcde2978a359c5f4efa.

A side effect of this patch is that it also counts frames which
are dropped when the PF receives frames not destined for it when
promiscuous mode is disabled.

Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
---
 drivers/net/intel/ice/ice_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
index a9a49cd924..9d0fbd2a5a 100644
--- a/drivers/net/intel/ice/ice_ethdev.c
+++ b/drivers/net/intel/ice/ice_ethdev.c
@@ -6353,13 +6353,12 @@ ice_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 
 	stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
 			  pf->main_vsi->eth_stats.rx_multicast +
-			  ns->eth.rx_unknown_protocol +
 			  pf->main_vsi->eth_stats.rx_broadcast -
 			  pf->main_vsi->eth_stats.rx_discards;
 	stats->opackets = ns->eth.tx_unicast +
 			  ns->eth.tx_multicast +
 			  ns->eth.tx_broadcast;
-	stats->ibytes   = ns->eth.rx_bytes;
+	stats->ibytes   = pf->main_vsi->eth_stats.rx_bytes;
 	stats->obytes   = ns->eth.tx_bytes;
 	stats->oerrors  = ns->eth.tx_errors +
 			  pf->main_vsi->eth_stats.tx_errors;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Revert "net/ice: count drop-all filter in Rx stats"
  2025-10-20 16:42 [PATCH] Revert "net/ice: count drop-all filter in Rx stats" Jeff Shaw
@ 2025-10-20 16:47 ` Bruce Richardson
  0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2025-10-20 16:47 UTC (permalink / raw)
  To: Jeff Shaw; +Cc: dev, Anatoly Burakov

On Mon, Oct 20, 2025 at 09:42:29AM -0700, Jeff Shaw wrote:
> This reverts commit af05f9e37153c53335938bcde2978a359c5f4efa.
> 
> A side effect of this patch is that it also counts frames which
> are dropped when the PF receives frames not destined for it when
> promiscuous mode is disabled.
> 
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-10-20 16:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-20 16:42 [PATCH] Revert "net/ice: count drop-all filter in Rx stats" Jeff Shaw
2025-10-20 16:47 ` Bruce Richardson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).