DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Shaiq Wani <shaiq.wani@intel.com>
Cc: <dev@dpdk.org>, <anatoly.burakov@intel.com>, <aman.deep.singh@intel.com>
Subject: Re: [PATCH] net/ixgbe: add E610 NIC speed support
Date: Tue, 4 Nov 2025 11:48:02 +0000	[thread overview]
Message-ID: <aQnn8r0-vGhG2cAX@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20251103133804.585506-1-shaiq.wani@intel.com>

On Mon, Nov 03, 2025 at 07:08:04PM +0530, Shaiq Wani wrote:
> Added a switch case for the E610 NIC adapter to set all supported link
> speeds (10M, 100M, 1G, 2.5G, 5G, 10G) in the ixgbe driver.
> Previously, E610 was not explicitly handled.
> 
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
>  drivers/net/intel/ixgbe/ixgbe_ethdev.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/intel/ixgbe/ixgbe_ethdev.c b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
> index bfc091c367..c01f53d8ad 100644
> --- a/drivers/net/intel/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
> @@ -2797,6 +2797,11 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
>  			allowed_speeds = RTE_ETH_LINK_SPEED_10M |
>  				RTE_ETH_LINK_SPEED_100M | RTE_ETH_LINK_SPEED_1G;
>  		break;
> +	case ixgbe_mac_E610:
> +		allowed_speeds = RTE_ETH_LINK_SPEED_10M | RTE_ETH_LINK_SPEED_100M |

Actually, on checking against the datasheet [section 1.4], I don't think it
supports 10M, only 100M. [Not that I expect that many users of DPDK are at
only 10M speed, but still]. Can you please double-check these values are
all correct?

Thanks,
/Bruce

> +			RTE_ETH_LINK_SPEED_1G | RTE_ETH_LINK_SPEED_2_5G |
> +			RTE_ETH_LINK_SPEED_5G | RTE_ETH_LINK_SPEED_10G;
> +		break;
>  	default:
>  		allowed_speeds = RTE_ETH_LINK_SPEED_100M | RTE_ETH_LINK_SPEED_1G |
>  			RTE_ETH_LINK_SPEED_10G;
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2025-11-04 11:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03 13:38 Shaiq Wani
2025-11-04 11:42 ` Bruce Richardson
2025-11-04 11:48 ` Bruce Richardson [this message]
2025-11-04 15:01 ` [PATCH v2] " Shaiq Wani
2025-11-04 17:41   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQnn8r0-vGhG2cAX@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=aman.deep.singh@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=shaiq.wani@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).