DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/ixgbe: add E610 NIC speed support
@ 2025-11-03 13:38 Shaiq Wani
  2025-11-04 11:42 ` Bruce Richardson
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Shaiq Wani @ 2025-11-03 13:38 UTC (permalink / raw)
  To: dev, bruce.richardson, anatoly.burakov; +Cc: aman.deep.singh

Added a switch case for the E610 NIC adapter to set all supported link
speeds (10M, 100M, 1G, 2.5G, 5G, 10G) in the ixgbe driver.
Previously, E610 was not explicitly handled.

Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
---
 drivers/net/intel/ixgbe/ixgbe_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/intel/ixgbe/ixgbe_ethdev.c b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
index bfc091c367..c01f53d8ad 100644
--- a/drivers/net/intel/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
@@ -2797,6 +2797,11 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
 			allowed_speeds = RTE_ETH_LINK_SPEED_10M |
 				RTE_ETH_LINK_SPEED_100M | RTE_ETH_LINK_SPEED_1G;
 		break;
+	case ixgbe_mac_E610:
+		allowed_speeds = RTE_ETH_LINK_SPEED_10M | RTE_ETH_LINK_SPEED_100M |
+			RTE_ETH_LINK_SPEED_1G | RTE_ETH_LINK_SPEED_2_5G |
+			RTE_ETH_LINK_SPEED_5G | RTE_ETH_LINK_SPEED_10G;
+		break;
 	default:
 		allowed_speeds = RTE_ETH_LINK_SPEED_100M | RTE_ETH_LINK_SPEED_1G |
 			RTE_ETH_LINK_SPEED_10G;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] net/ixgbe: add E610 NIC speed support
  2025-11-03 13:38 [PATCH] net/ixgbe: add E610 NIC speed support Shaiq Wani
@ 2025-11-04 11:42 ` Bruce Richardson
  2025-11-04 11:48 ` Bruce Richardson
  2025-11-04 15:01 ` [PATCH v2] " Shaiq Wani
  2 siblings, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2025-11-04 11:42 UTC (permalink / raw)
  To: Shaiq Wani; +Cc: dev, anatoly.burakov, aman.deep.singh

On Mon, Nov 03, 2025 at 07:08:04PM +0530, Shaiq Wani wrote:
> Added a switch case for the E610 NIC adapter to set all supported link
> speeds (10M, 100M, 1G, 2.5G, 5G, 10G) in the ixgbe driver.
> Previously, E610 was not explicitly handled.
> 
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] net/ixgbe: add E610 NIC speed support
  2025-11-03 13:38 [PATCH] net/ixgbe: add E610 NIC speed support Shaiq Wani
  2025-11-04 11:42 ` Bruce Richardson
@ 2025-11-04 11:48 ` Bruce Richardson
  2025-11-04 15:01 ` [PATCH v2] " Shaiq Wani
  2 siblings, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2025-11-04 11:48 UTC (permalink / raw)
  To: Shaiq Wani; +Cc: dev, anatoly.burakov, aman.deep.singh

On Mon, Nov 03, 2025 at 07:08:04PM +0530, Shaiq Wani wrote:
> Added a switch case for the E610 NIC adapter to set all supported link
> speeds (10M, 100M, 1G, 2.5G, 5G, 10G) in the ixgbe driver.
> Previously, E610 was not explicitly handled.
> 
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
>  drivers/net/intel/ixgbe/ixgbe_ethdev.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/intel/ixgbe/ixgbe_ethdev.c b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
> index bfc091c367..c01f53d8ad 100644
> --- a/drivers/net/intel/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
> @@ -2797,6 +2797,11 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
>  			allowed_speeds = RTE_ETH_LINK_SPEED_10M |
>  				RTE_ETH_LINK_SPEED_100M | RTE_ETH_LINK_SPEED_1G;
>  		break;
> +	case ixgbe_mac_E610:
> +		allowed_speeds = RTE_ETH_LINK_SPEED_10M | RTE_ETH_LINK_SPEED_100M |

Actually, on checking against the datasheet [section 1.4], I don't think it
supports 10M, only 100M. [Not that I expect that many users of DPDK are at
only 10M speed, but still]. Can you please double-check these values are
all correct?

Thanks,
/Bruce

> +			RTE_ETH_LINK_SPEED_1G | RTE_ETH_LINK_SPEED_2_5G |
> +			RTE_ETH_LINK_SPEED_5G | RTE_ETH_LINK_SPEED_10G;
> +		break;
>  	default:
>  		allowed_speeds = RTE_ETH_LINK_SPEED_100M | RTE_ETH_LINK_SPEED_1G |
>  			RTE_ETH_LINK_SPEED_10G;
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] net/ixgbe: add E610 NIC speed support
  2025-11-03 13:38 [PATCH] net/ixgbe: add E610 NIC speed support Shaiq Wani
  2025-11-04 11:42 ` Bruce Richardson
  2025-11-04 11:48 ` Bruce Richardson
@ 2025-11-04 15:01 ` Shaiq Wani
  2025-11-04 17:41   ` Bruce Richardson
  2 siblings, 1 reply; 5+ messages in thread
From: Shaiq Wani @ 2025-11-04 15:01 UTC (permalink / raw)
  To: dev, bruce.richardson, anatoly.burakov; +Cc: aman.deep.singh

Added a switch case for the E610 NIC adapter to set all supported link
speeds (100M, 1G, 2.5G, 5G, 10G) in the ixgbe driver.
Previously, E610 was not explicitly handled.

Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

v2:
*removed 10M speed since E610 does not support it.
---
 drivers/net/intel/ixgbe/ixgbe_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/intel/ixgbe/ixgbe_ethdev.c b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
index bfc091c367..89a799762f 100644
--- a/drivers/net/intel/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
@@ -2797,6 +2797,11 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
 			allowed_speeds = RTE_ETH_LINK_SPEED_10M |
 				RTE_ETH_LINK_SPEED_100M | RTE_ETH_LINK_SPEED_1G;
 		break;
+	case ixgbe_mac_E610:
+		allowed_speeds = RTE_ETH_LINK_SPEED_100M | RTE_ETH_LINK_SPEED_1G |
+			RTE_ETH_LINK_SPEED_2_5G | RTE_ETH_LINK_SPEED_5G |
+			RTE_ETH_LINK_SPEED_10G;
+		break;
 	default:
 		allowed_speeds = RTE_ETH_LINK_SPEED_100M | RTE_ETH_LINK_SPEED_1G |
 			RTE_ETH_LINK_SPEED_10G;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] net/ixgbe: add E610 NIC speed support
  2025-11-04 15:01 ` [PATCH v2] " Shaiq Wani
@ 2025-11-04 17:41   ` Bruce Richardson
  0 siblings, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2025-11-04 17:41 UTC (permalink / raw)
  To: Shaiq Wani; +Cc: dev, anatoly.burakov, aman.deep.singh

On Tue, Nov 04, 2025 at 08:31:13PM +0530, Shaiq Wani wrote:
> Added a switch case for the E610 NIC adapter to set all supported link
> speeds (100M, 1G, 2.5G, 5G, 10G) in the ixgbe driver.
> Previously, E610 was not explicitly handled.
> 
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
Applied to next-net-intel.

Thanks,
/Bruce

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-11-04 17:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-03 13:38 [PATCH] net/ixgbe: add E610 NIC speed support Shaiq Wani
2025-11-04 11:42 ` Bruce Richardson
2025-11-04 11:48 ` Bruce Richardson
2025-11-04 15:01 ` [PATCH v2] " Shaiq Wani
2025-11-04 17:41   ` Bruce Richardson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).