* [PATCH] net/idpf: fix missing offload from conversion function
@ 2025-11-13 14:50 Ciara Loftus
2025-11-17 6:46 ` Shetty, Praveen
0 siblings, 1 reply; 3+ messages in thread
From: Ciara Loftus @ 2025-11-13 14:50 UTC (permalink / raw)
To: dev; +Cc: Ciara Loftus, stable
The TCP_TSO tx offload was missing from the conversion function. This
was effectively taking the request for that offload out of consideration
when selecting the tx function. As a result a vector path which does not
support TSO could be chosen when that offload was requested, when
instead the scalar path should be chosen which does support that
offload. Fix this by adding the TSO offload to the conversion function.
Fixes: c008a5e740bd ("common/idpf: add queue setup/release")
Cc: stable@dpdk.org
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
drivers/net/intel/idpf/idpf_rxtx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/intel/idpf/idpf_rxtx.c b/drivers/net/intel/idpf/idpf_rxtx.c
index 1c725065df..4796d8b862 100644
--- a/drivers/net/intel/idpf/idpf_rxtx.c
+++ b/drivers/net/intel/idpf/idpf_rxtx.c
@@ -42,6 +42,8 @@ idpf_tx_offload_convert(uint64_t offload)
ol |= IDPF_TX_OFFLOAD_TCP_CKSUM;
if ((offload & RTE_ETH_TX_OFFLOAD_SCTP_CKSUM) != 0)
ol |= IDPF_TX_OFFLOAD_SCTP_CKSUM;
+ if ((offload & RTE_ETH_TX_OFFLOAD_TCP_TSO) != 0)
+ ol |= IDPF_TX_OFFLOAD_TCP_TSO;
if ((offload & RTE_ETH_TX_OFFLOAD_MULTI_SEGS) != 0)
ol |= IDPF_TX_OFFLOAD_MULTI_SEGS;
if ((offload & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) != 0)
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] net/idpf: fix missing offload from conversion function
2025-11-13 14:50 [PATCH] net/idpf: fix missing offload from conversion function Ciara Loftus
@ 2025-11-17 6:46 ` Shetty, Praveen
2025-11-17 9:35 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Shetty, Praveen @ 2025-11-17 6:46 UTC (permalink / raw)
To: Loftus, Ciara, dev; +Cc: Loftus, Ciara, stable
The TCP_TSO tx offload was missing from the conversion function. This was effectively taking the request for that offload out of consideration when selecting the tx function. As a result a vector path which does not support TSO could be chosen when that offload was requested, when instead the scalar path should be chosen which does support that offload. Fix this by adding the TSO offload to the conversion function.
Fixes: c008a5e740bd ("common/idpf: add queue setup/release")
Cc: stable@dpdk.org
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
drivers/net/intel/idpf/idpf_rxtx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/intel/idpf/idpf_rxtx.c b/drivers/net/intel/idpf/idpf_rxtx.c
index 1c725065df..4796d8b862 100644
--- a/drivers/net/intel/idpf/idpf_rxtx.c
+++ b/drivers/net/intel/idpf/idpf_rxtx.c
@@ -42,6 +42,8 @@ idpf_tx_offload_convert(uint64_t offload)
ol |= IDPF_TX_OFFLOAD_TCP_CKSUM;
if ((offload & RTE_ETH_TX_OFFLOAD_SCTP_CKSUM) != 0)
ol |= IDPF_TX_OFFLOAD_SCTP_CKSUM;
+ if ((offload & RTE_ETH_TX_OFFLOAD_TCP_TSO) != 0)
+ ol |= IDPF_TX_OFFLOAD_TCP_TSO;
if ((offload & RTE_ETH_TX_OFFLOAD_MULTI_SEGS) != 0)
ol |= IDPF_TX_OFFLOAD_MULTI_SEGS;
if ((offload & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) != 0)
--
Looks good to me,
Acked-by: Praveen Shetty <praveen.shetty@intel.com>
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/idpf: fix missing offload from conversion function
2025-11-17 6:46 ` Shetty, Praveen
@ 2025-11-17 9:35 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2025-11-17 9:35 UTC (permalink / raw)
To: Shetty, Praveen; +Cc: Loftus, Ciara, dev, stable
On Mon, Nov 17, 2025 at 06:46:44AM +0000, Shetty, Praveen wrote:
> The TCP_TSO tx offload was missing from the conversion function. This was
> effectively taking the request for that offload out of consideration when
> selecting the tx function. As a result a vector path which does not
> support TSO could be chosen when that offload was requested, when instead
> the scalar path should be chosen which does support that offload. Fix
> this by adding the TSO offload to the conversion function.
>
> Fixes: c008a5e740bd ("common/idpf: add queue setup/release") Cc:
> stable@dpdk.org
>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com> ---
> drivers/net/intel/idpf/idpf_rxtx.c | 2 ++ 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/intel/idpf/idpf_rxtx.c
> b/drivers/net/intel/idpf/idpf_rxtx.c index 1c725065df..4796d8b862 100644
> --- a/drivers/net/intel/idpf/idpf_rxtx.c +++
> b/drivers/net/intel/idpf/idpf_rxtx.c @@ -42,6 +42,8 @@
> idpf_tx_offload_convert(uint64_t offload) ol |=
> IDPF_TX_OFFLOAD_TCP_CKSUM; if ((offload & RTE_ETH_TX_OFFLOAD_SCTP_CKSUM)
> != 0) ol |= IDPF_TX_OFFLOAD_SCTP_CKSUM; + if ((offload &
> RTE_ETH_TX_OFFLOAD_TCP_TSO) != 0) + ol |=
> IDPF_TX_OFFLOAD_TCP_TSO; if ((offload & RTE_ETH_TX_OFFLOAD_MULTI_SEGS) !=
> 0) ol |= IDPF_TX_OFFLOAD_MULTI_SEGS; if ((offload &
> RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) != 0) --
>
> Looks good to me, Acked-by: Praveen Shetty <praveen.shetty@intel.com>
>
Applied to dpdk-next-net-intel
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-17 9:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-13 14:50 [PATCH] net/idpf: fix missing offload from conversion function Ciara Loftus
2025-11-17 6:46 ` Shetty, Praveen
2025-11-17 9:35 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).