From: Bruce Richardson <bruce.richardson@intel.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: <dev@dpdk.org>, Paul Greenwalt <paul.greenwalt@intel.com>,
"Vladimir Medvedkin" <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH 1/2] net/iavf: check if PF actually indicates Rx timestamps
Date: Mon, 17 Nov 2025 11:37:32 +0000 [thread overview]
Message-ID: <aRsI_E5gIPP4jsY9@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20251113-jk-dpdk-iavf-rx-timestamping-improvements-v1-1-3d9a0168087b@intel.com>
On Thu, Nov 13, 2025 at 01:33:44PM -0800, Jacob Keller wrote:
> The iavf driver has support for hardware Rx timestamps since commit h
> b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor").
>
> To enable this, the VF must first negotiate PTP capabilities with the PF
> by sending the VIRTCHNL_OP_1588_PTP_GET_CAPS command, with the requested
> capabilities. The PF will respond with the actually supported subset of
> capabilities.
>
> The PF may not actually enable Rx timestamping, even if it reports the
> overall PTP capability support. If this happens, the iavf driver logic
> will incorrectly report that Rx timestamps can be enabled despite being
> rejected by the PF.
>
> This is unlikely in practice, as most PFs which support the
> VIRTCHNL_VF_CAP_PTP will support Rx timestamping. However, there are
> some cases where this may not be true.
>
> Check that the PF actually reports the Rx timestamping capability
> instead of assuming it is enabled. Doing so prevents the DPDK
> application from attempting to enable Rx timestamps when they won't
> actually be enabled.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
Fixes: b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor")
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2025-11-17 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 21:33 [PATCH 0/2] net/iavf: handle PF not enabling Rx timestamps properly Jacob Keller
2025-11-13 21:33 ` [PATCH 1/2] net/iavf: check if PF actually indicates Rx timestamps Jacob Keller
2025-11-17 11:37 ` Bruce Richardson [this message]
2025-11-13 21:33 ` [PATCH 2/2] net/iavf: check Rx timestamp validity bit Jacob Keller
2025-11-17 11:45 ` Bruce Richardson
2025-11-17 11:49 ` [PATCH 0/2] net/iavf: handle PF not enabling Rx timestamps properly Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRsI_E5gIPP4jsY9@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jacob.e.keller@intel.com \
--cc=paul.greenwalt@intel.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).