Re: [PATCH v1] net/intel: changes to avoid comma operator misuse warnings

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Nov 06, 2025 at 01:53:54PM +0530, Venkatesh Vemula wrote:
> fixed comma operator misuse warnings with clang compiler
> for intel PMDs when -Wcomma enabled.
> 
> Bugzilla ID: 1809("net/intel: possible misuse of comma operator")
> Signed-off-by: Venkatesh Vemula <venkatesh.vemula@intel.com>
> ---
>  drivers/net/intel/i40e/i40e_ethdev.c             | 8 ++++----
>  drivers/net/intel/i40e/i40e_rxtx_vec_avx2.c      | 4 ++--
>  drivers/net/intel/i40e/i40e_rxtx_vec_avx512.c    | 2 +-
>  drivers/net/intel/iavf/iavf_rxtx_vec_avx2.c      | 4 ++--
>  drivers/net/intel/iavf/iavf_rxtx_vec_avx512.c    | 6 +++---
>  drivers/net/intel/ice/ice_ethdev.c               | 8 ++++----
>  drivers/net/intel/ice/ice_rxtx_vec_avx2.c        | 4 ++--
>  drivers/net/intel/ice/ice_rxtx_vec_avx512.c      | 2 +-
>  drivers/net/intel/idpf/idpf_common_rxtx_avx2.c   | 4 ++--
>  drivers/net/intel/idpf/idpf_common_rxtx_avx512.c | 8 ++++----
>  10 files changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/net/intel/i40e/i40e_ethdev.c b/drivers/net/intel/i40e/i40e_ethdev.c
> index b8ce79061b..799e65ac8d 100644
> --- a/drivers/net/intel/i40e/i40e_ethdev.c
> +++ b/drivers/net/intel/i40e/i40e_ethdev.c
> @@ -5099,15 +5099,15 @@ i40e_res_pool_destroy(struct i40e_res_pool_info *pool)
>  		return;
>  
>  	for (entry = LIST_FIRST(&pool->alloc_list);
> -			entry && (next_entry = LIST_NEXT(entry, next), 1);
> -			entry = next_entry) {
> +		 entry; entry = next_entry) {

The indentation and wrapping seems off here (and similar changes below).
Suggest you see if the whole "for" statement can exist on a single line,
now that it's shorter. If not, keep indentation from original code and
don't adjust it.

Thanks,
/Bruce

> +		next_entry = LIST_NEXT(entry, next);
>  		LIST_REMOVE(entry, next);
>  		rte_free(entry);
>  	}
>  
<snip>