DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: Re: [PATCH] net/e1000: add check for filter mask range
Date: Mon, 17 Nov 2025 16:25:06 +0000	[thread overview]
Message-ID: <aRtMYmDnEGXhI_7H@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <192cd9cd-ac37-40fd-a5e6-2b51d5399b2f@intel.com>

On Mon, Nov 17, 2025 at 05:06:45PM +0100, Burakov, Anatoly wrote:
> On 11/14/2025 7:21 PM, Stephen Hemminger wrote:
> > Gcc-16 complains about possible reference outside of array
> > when managing flex filter. This is a false positive because the
> > filter length can never be that long, but compiler can't detect
> > that. Add guard rail check to only loop over possible array.
> > 
> > ../drivers/net/intel/e1000/igb_ethdev.c:4265:23: note: at offset 152 into destination object of size 176 allocated by ‘rte_zmalloc’
> >   4265 |         flex_filter = rte_zmalloc("e1000_flex_filter",
> >        |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >   4266 |                         sizeof(struct e1000_flex_filter), 0);
> >        |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../drivers/net/intel/e1000/igb_ethdev.c:4280:50: warning: writing 64 bytes into a region of size 0 [-Wstringop-overflow=]
> >   4280 |                 flex_filter->filter_info.mask[i] = mask;
> >        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> 
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
Applied to dpdk-next-net-intel. [With the "&&" moved to previous line to keep
checkpatch happy]

/Bruce

      reply	other threads:[~2025-11-17 16:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 18:21 Stephen Hemminger
2025-11-17 16:06 ` Burakov, Anatoly
2025-11-17 16:25   ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRtMYmDnEGXhI_7H@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).