From: Bruce Richardson <bruce.richardson@intel.com>
To: luyan <973788536@qq.com>
Cc: <maxime.coquelin@redhat.com>, <chenbox@nvidia.com>,
<dev@dpdk.org>, luyan <luyan@cmss.chinamobile.com>
Subject: Re: [PATCH] eal/arm: include rte_config.h upfront to fix ARM arch header selection
Date: Fri, 5 Dec 2025 08:23:24 +0000 [thread overview]
Message-ID: <aTKWfGo9O639Y542@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <tencent_0AAA93B91277A304E5303277E262EB7FC408@qq.com>
On Tue, Dec 02, 2025 at 04:08:49PM +0800, luyan wrote:
> From: luyan <luyan@cmss.chinamobile.com>
>
> Fix incorrect arch header inclusion on ARM by adding rte_config.h before
> architecture judgment.
>
> Signed-off-by: Yan Lu <luyan@cmss.chinamobile.com>
> ---
> lib/eal/arm/include/rte_atomic.h | 2 ++
> lib/eal/arm/include/rte_cpuflags.h | 2 ++
> lib/eal/arm/include/rte_cycles.h | 2 ++
> lib/eal/arm/include/rte_io.h | 2 ++
> lib/eal/arm/include/rte_memcpy.h | 2 ++
> lib/eal/arm/include/rte_pause.h | 2 ++
> lib/eal/arm/include/rte_prefetch.h | 2 ++
> 7 files changed, 14 insertions(+)
>
> diff --git a/lib/eal/arm/include/rte_atomic.h b/lib/eal/arm/include/rte_atomic.h
> index 40e14e56f7..c329b18761 100644
> --- a/lib/eal/arm/include/rte_atomic.h
> +++ b/lib/eal/arm/include/rte_atomic.h
> @@ -5,6 +5,8 @@
> #ifndef _RTE_ATOMIC_ARM_H_
> #define _RTE_ATOMIC_ARM_H_
>
> +#include <rte_config.h>
> +
> #ifdef RTE_ARCH_64
> #include <rte_atomic_64.h>
> #else
When building DPDK or building DPDK apps, rte_config.h should already be
included by this point anyway. We pass "-include rte_config.h" as a flag to
the C compiler, meaning it is included first as a header for building each
file. This flag is also included in the pkg-config output, so apps building
against DPDK should get the same behaviour.
/Bruce
prev parent reply other threads:[~2025-12-05 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 8:08 luyan
2025-12-05 8:23 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTKWfGo9O639Y542@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=973788536@qq.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=luyan@cmss.chinamobile.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).