From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v3 00/11] Assign all unit tests to suites
Date: Tue, 9 Dec 2025 08:50:06 +0000 [thread overview]
Message-ID: <aTfivuaqs37ESNYx@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20251208111053.12535b4f@phoenix.local>
On Mon, Dec 08, 2025 at 11:10:53AM -0800, Stephen Hemminger wrote:
> On Mon, 8 Dec 2025 11:52:34 +0000
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > Categorize all unit tests into one of the test suites: generally driver
> > tests or fast-tests. In order to add some of the tests to fast tests,
> > some additional work was required, hence the additional patches in this
> > set. Also, make the parameters for asan and hugepages clearer in each
> > test's definition.
> >
> > V3:
> > - correct comment in patch 1
> > - define "attic" suite for unstable tests and add red_autotest to it.
> >
> > V2:
> > - rename the parameters for fast-test
> > - fix issues with the tests to be added to fast-tests:
> > * allow loading drivers from secondary processes
> > * fix undefined behaviour flagged by asan in red test
> > * skip unrunnable power tests, rather than failing
> > - add tests to driver-test suite also
> > - add patch fixing output in case we have no unattached tests
> >
> > Bruce Richardson (11):
> > app/test: make parameters clearer when adding fast tests
> > app/test: fix undefined behaviour in red autotest
> > app/test: reduce duration of secondary timer test
> > app/test: fix timer loop hang on secondary process failure
> > eal: add internal APIs to query loaded driver paths
> > app/test: pass loaded driver info to secondary procs
> > app/test: skip power capabilities test if unsupported
> > app/test: add some unattached tests to fast-test suite
> > app/test: add tests to driver test suite
> > buildtools/get-test-suites: suppress empty output
> > app/test: move red autotest to attic
> >
> > app/test/process.h | 28 ++++++++++++-
> > app/test/suites/meson.build | 14 ++++++-
> > app/test/test.h | 13 ++++++-
> > app/test/test_acl.c | 2 +-
> > app/test/test_alarm.c | 2 +-
> > app/test/test_argparse.c | 2 +-
> > app/test/test_atomic.c | 2 +-
> > app/test/test_bitcount.c | 2 +-
> > app/test/test_bitmap.c | 2 +-
> > app/test/test_bitops.c | 2 +-
> > app/test/test_bitratestats.c | 2 +-
> > app/test/test_bitset.c | 2 +-
> > app/test/test_bpf.c | 6 +--
> > app/test/test_byteorder.c | 2 +-
> > app/test/test_cfgfile.c | 2 +-
> > app/test/test_cksum.c | 2 +-
> > app/test/test_cmdline.c | 2 +-
> > app/test/test_common.c | 2 +-
> > app/test/test_compressdev.c | 2 +-
> > app/test/test_cpuflags.c | 2 +-
> > app/test/test_crc.c | 2 +-
> > app/test/test_cryptodev_crosscheck.c | 2 +-
> > app/test/test_cycles.c | 2 +-
> > app/test/test_debug.c | 2 +-
> > app/test/test_devargs.c | 2 +-
> > app/test/test_dispatcher.c | 2 +-
> > app/test/test_distributor.c | 2 +-
> > app/test/test_eal_flags.c | 24 ++++++------
> > app/test/test_eal_fs.c | 2 +-
> > app/test/test_errno.c | 2 +-
> > app/test/test_ethdev_api.c | 2 +-
> > app/test/test_ethdev_link.c | 2 +-
> > app/test/test_event_crypto_adapter.c | 2 +-
> > app/test/test_event_eth_rx_adapter.c | 4 +-
> > app/test/test_event_eth_tx_adapter.c | 2 +-
> > app/test/test_event_ring.c | 2 +-
> > app/test/test_event_timer_adapter.c | 2 +-
> > app/test/test_event_vector_adapter.c | 2 +-
> > app/test/test_eventdev.c | 4 +-
> > app/test/test_external_mem.c | 2 +-
> > app/test/test_fbarray.c | 2 +-
> > app/test/test_fib.c | 2 +-
> > app/test/test_fib6.c | 2 +-
> > app/test/test_func_reentrancy.c | 2 +-
> > app/test/test_graph.c | 4 +-
> > app/test/test_graph_feature_arc.c | 2 +-
> > app/test/test_hash.c | 2 +-
> > app/test/test_hash_readwrite.c | 2 +-
> > app/test/test_interrupts.c | 2 +-
> > app/test/test_ipfrag.c | 2 +-
> > app/test/test_ipsec.c | 2 +-
> > app/test/test_ipsec_sad.c | 2 +-
> > app/test/test_kvargs.c | 2 +-
> > app/test/test_latencystats.c | 2 +-
> > app/test/test_lcore_var.c | 2 +-
> > app/test/test_lcores.c | 2 +-
> > app/test/test_logs.c | 2 +-
> > app/test/test_lpm.c | 2 +-
> > app/test/test_lpm6.c | 2 +-
> > app/test/test_malloc.c | 2 +-
> > app/test/test_mbuf.c | 2 +-
> > app/test/test_mcslock.c | 2 +-
> > app/test/test_member.c | 2 +-
> > app/test/test_memcpy.c | 2 +-
> > app/test/test_memory.c | 2 +-
> > app/test/test_mempool.c | 2 +-
> > app/test/test_memzone.c | 2 +-
> > app/test/test_meter.c | 2 +-
> > app/test/test_metrics.c | 2 +-
> > app/test/test_mp_secondary.c | 2 +-
> > app/test/test_net_ether.c | 2 +-
> > app/test/test_net_ip6.c | 2 +-
> > app/test/test_pcapng.c | 2 +-
> > app/test/test_pdcp.c | 2 +-
> > app/test/test_pdump.c | 2 +-
> > app/test/test_per_lcore.c | 2 +-
> > app/test/test_pflock.c | 2 +-
> > app/test/test_pie.c | 2 +-
> > app/test/test_pmd_ring.c | 2 +-
> > app/test/test_pmu.c | 2 +-
> > app/test/test_power.c | 2 +-
> > app/test/test_power_cpufreq.c | 6 +--
> > app/test/test_power_intel_uncore.c | 2 +-
> > app/test/test_power_kvm_vm.c | 2 +-
> > app/test/test_prefetch.c | 2 +-
> > app/test/test_ptr_compress.c | 2 +-
> > app/test/test_rawdev.c | 2 +-
> > app/test/test_rcu_qsbr.c | 2 +-
> > app/test/test_red.c | 2 +-
> > app/test/test_reorder.c | 2 +-
> > app/test/test_rib.c | 2 +-
> > app/test/test_rib6.c | 2 +-
> > app/test/test_ring.c | 2 +-
> > app/test/test_rwlock.c | 8 ++--
> > app/test/test_sched.c | 2 +-
> > app/test/test_security.c | 2 +-
> > app/test/test_security_inline_macsec.c | 2 +-
> > app/test/test_security_inline_proto.c | 6 +--
> > app/test/test_seqlock.c | 2 +-
> > app/test/test_service_cores.c | 2 +-
> > app/test/test_soring.c | 2 +-
> > app/test/test_spinlock.c | 2 +-
> > app/test/test_stack.c | 4 +-
> > app/test/test_string_fns.c | 2 +-
> > app/test/test_table.c | 2 +-
> > app/test/test_tailq.c | 2 +-
> > app/test/test_telemetry_data.c | 2 +-
> > app/test/test_telemetry_json.c | 2 +-
> > app/test/test_thash.c | 2 +-
> > app/test/test_threads.c | 2 +-
> > app/test/test_ticketlock.c | 2 +-
> > app/test/test_timer.c | 2 +-
> > app/test/test_timer_secondary.c | 13 ++++---
> > app/test/test_trace.c | 2 +-
> > app/test/test_vdev.c | 2 +-
> > app/test/test_version.c | 2 +-
> > buildtools/get-test-suites.py | 5 ++-
> > doc/guides/contributing/unit_test.rst | 10 +++--
> > lib/eal/common/eal_common_options.c | 54 ++++++++++++++++++++++++--
> > lib/eal/include/rte_eal.h | 52 +++++++++++++++++++++++++
> > lib/sched/rte_red.h | 9 ++++-
> > 121 files changed, 313 insertions(+), 157 deletions(-)
> >
> > --
> > 2.51.0
> >
>
>
> Overall looks good, one comment is to try and make sure the new
> functions are internal only? or experimental?
I think internal-only. I've marked them in doxygen as internal-only but did
not put it in the export line. I don't see the need for apps to use these
APIs, so let's limit the scope as much as possible, because we can always
open it up further later.
/Bruce
next prev parent reply other threads:[~2025-12-09 8:50 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 15:49 [PATCH 0/2] improve fast-tests suite Bruce Richardson
2025-12-02 15:49 ` [PATCH 1/2] app/test: add some unattached tests to fast-test suite Bruce Richardson
2025-12-02 15:49 ` [PATCH 2/2] app/test: make parameters clearer when adding fast tests Bruce Richardson
2025-12-02 16:53 ` Marat Khalili
2025-12-02 18:16 ` Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 00/10] Assign all unit tests to suites Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 01/10] app/test: make parameters clearer when adding fast tests Bruce Richardson
2025-12-05 10:10 ` Marat Khalili
2025-12-05 10:17 ` Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 02/10] app/test: fix undefined behaviour in red autotest Bruce Richardson
2025-12-05 10:25 ` Marat Khalili
2025-12-04 18:20 ` [PATCH v2 03/10] app/test: reduce duration of secondary timer test Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 04/10] app/test: fix timer loop hang on secondary process failure Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 05/10] eal: add internal APIs to query loaded driver paths Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 06/10] app/test: pass loaded driver info to secondary procs Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 07/10] app/test: skip power capabilities test if unsupported Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 08/10] app/test: add some unattached tests to fast-test suite Bruce Richardson
2025-12-05 12:37 ` David Marchand
2025-12-05 12:43 ` Bruce Richardson
2025-12-05 12:50 ` David Marchand
2025-12-05 12:53 ` Bruce Richardson
2025-12-05 13:08 ` David Marchand
2025-12-04 18:20 ` [PATCH v2 09/10] app/test: add tests to driver test suite Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 10/10] buildtools/get-test-suites: suppress empty output Bruce Richardson
2025-12-05 10:29 ` Marat Khalili
2025-12-08 11:52 ` [PATCH v3 00/11] Assign all unit tests to suites Bruce Richardson
2025-12-08 11:52 ` [PATCH v3 01/11] app/test: make parameters clearer when adding fast tests Bruce Richardson
2025-12-08 11:52 ` [PATCH v3 02/11] app/test: fix undefined behaviour in red autotest Bruce Richardson
2025-12-08 11:52 ` [PATCH v3 03/11] app/test: reduce duration of secondary timer test Bruce Richardson
2025-12-08 11:52 ` [PATCH v3 04/11] app/test: fix timer loop hang on secondary process failure Bruce Richardson
2025-12-08 11:52 ` [PATCH v3 05/11] eal: add internal APIs to query loaded driver paths Bruce Richardson
2025-12-08 19:09 ` Stephen Hemminger
2025-12-09 8:41 ` Bruce Richardson
2025-12-08 11:52 ` [PATCH v3 06/11] app/test: pass loaded driver info to secondary procs Bruce Richardson
2025-12-08 11:52 ` [PATCH v3 07/11] app/test: skip power capabilities test if unsupported Bruce Richardson
2025-12-08 11:52 ` [PATCH v3 08/11] app/test: add some unattached tests to fast-test suite Bruce Richardson
2025-12-08 11:52 ` [PATCH v3 09/11] app/test: add tests to driver test suite Bruce Richardson
2025-12-08 11:52 ` [PATCH v3 10/11] buildtools/get-test-suites: suppress empty output Bruce Richardson
2025-12-08 11:52 ` [PATCH v3 11/11] app/test: move red autotest to attic Bruce Richardson
2025-12-08 19:10 ` [PATCH v3 00/11] Assign all unit tests to suites Stephen Hemminger
2025-12-09 8:50 ` Bruce Richardson [this message]
2025-12-11 17:16 ` [PATCH v4 " Bruce Richardson
2025-12-11 17:16 ` [PATCH v4 01/11] app/test: make parameters clearer when adding fast tests Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 02/11] app/test: fix undefined behaviour in red autotest Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 03/11] app/test: reduce duration of secondary timer test Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 04/11] app/test: fix timer loop hang on secondary process failure Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 05/11] eal: add internal APIs to query loaded driver paths Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 06/11] app/test: pass loaded driver info to secondary procs Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 07/11] app/test: skip power capabilities test if unsupported Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 08/11] app/test: add some unattached tests to fast-test suite Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 09/11] app/test: add tests to driver test suite Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 10/11] buildtools/get-test-suites: suppress empty output Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 11/11] app/test: move red autotest to attic Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTfivuaqs37ESNYx@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).