DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH 0/8] Fixes for Intel common rx/tx path selection
Date: Mon, 15 Dec 2025 14:58:21 +0000	[thread overview]
Message-ID: <aUAiDdY6K5_ugFHb@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20251215140553.2283531-1-ciara.loftus@intel.com>

On Mon, Dec 15, 2025 at 02:05:45PM +0000, Ciara Loftus wrote:
> An issue exists with the way Rx and Tx paths are defined and then used
> by the common selection infrastructure, which in some cases means not
> all paths are available for selection. The issue affects four drivers on
> both Rx and Tx paths resulting in eight fix patches.
> 
> Depending on the underlying architecture and CPU flags available, a
> different set of paths are defined for each driver. The path selection
> function iterates sequentially from zero to num_paths where num_paths is
> the size of the array as determined by the RTE_DIM macro. However,
> depending on the platform, some of these entries may be empty, and valid
> entries at the end of the array may never be considered in the selection
> function. Fix this by editing each driver's rx/tx "func_type" enum and
> only defining a value for the path if it is implemented in the driver's
> rx/tx "path_infos" array.
>
I wonder if there is an alternative/better approach that can work here. For
each array, RTE_DIM will correctly give its size, and the indexes are set
according to the enum values which are common across each platform.
Therefore, the remaining entries in each array are going to be all zeroed,
since they are not explicitly initialized, e.g. the AXV entries on ARM
platforms. Would it not then work to just check during selection for a
non-NULL pkt_burst pointer in each entry we are comparing and skip those
which are NULL?

/Bruce

  parent reply	other threads:[~2025-12-15 14:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15 14:05 Ciara Loftus
2025-12-15 14:05 ` [PATCH 1/8] net/i40e: ensure all Tx paths are selectable Ciara Loftus
2025-12-15 14:05 ` [PATCH 2/8] net/iavf: " Ciara Loftus
2025-12-15 14:05 ` [PATCH 3/8] net/ice: " Ciara Loftus
2025-12-15 14:05 ` [PATCH 4/8] net/idpf: " Ciara Loftus
2025-12-15 14:05 ` [PATCH 5/8] net/i40e: ensure all Rx " Ciara Loftus
2025-12-15 14:05 ` [PATCH 6/8] net/iavf: " Ciara Loftus
2025-12-15 14:05 ` [PATCH 7/8] net/ice: " Ciara Loftus
2025-12-15 14:05 ` [PATCH 8/8] net/idpf: " Ciara Loftus
2025-12-15 14:58 ` Bruce Richardson [this message]
2025-12-16  9:06   ` [PATCH 0/8] Fixes for Intel common rx/tx path selection Loftus, Ciara
2025-12-16 10:35 ` [PATCH v2 0/3] " Ciara Loftus
2025-12-16 10:35   ` [PATCH v2 1/3] net/intel: prevent selection of a null Tx burst function Ciara Loftus
2025-12-16 12:05     ` Bruce Richardson
2025-12-16 10:35   ` [PATCH v2 2/3] net/intel: prevent selection of a null Rx " Ciara Loftus
2025-12-16 12:06     ` Bruce Richardson
2025-12-16 10:35   ` [PATCH v2 3/3] net/intel: bring common Rx path selection in line with Tx Ciara Loftus
2025-12-16 12:06     ` Bruce Richardson
2025-12-16 12:28   ` [PATCH v2 0/3] Fixes for Intel common rx/tx path selection Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aUAiDdY6K5_ugFHb@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).