From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C08D42CB7; Wed, 14 Jun 2023 12:31:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 106AA40E0F; Wed, 14 Jun 2023 12:31:07 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2073.outbound.protection.outlook.com [40.107.237.73]) by mails.dpdk.org (Postfix) with ESMTP id 6566640DDB for ; Wed, 14 Jun 2023 12:31:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=igkinzF3aXa1aAm+M6G8goqNfrrmpPCpLJlW+AIDakO643AuaNjw4J/1gXPihplVYrsvJ22AKzX5xyibY6KX2OZc3XxUSgueHQntVHYlJn1s8Ic4WOiEhthB5UvJXt9MNNocEhDE2yBejvCTG0g+h49PjdoluneBcqGpM6+JrZMNof+gQQc5kXwNrPSU3tZl3RaNNAyOw+sJWwBjSh5qQoPqj+dTCgSodP/Bqr5H88jakEOi7mSGw9OZCSI6FJxu6Xl1rPzUd2abovJBLFhf7adkxI+Msx+r61YGt0roenKqGkwiCYyaN6TjAIobFkQYQv7K6nn+4pHTnIEa3PUXIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KIzYcUwfJU8NkQPW+8zo1+10oeEh7cQfYBL50oVUuUI=; b=l+v4ue+Kok9934VVMLQRyVGOKeAraPUWqarx1ril/HqaGElqvQdXDLc2pbLWj9LEid6J/jZIhCO/H7IK3xI5Cwk2gjtSDtMKWQSdVcad/cSbOR9EYfNmQgqnD7dJJnqyMOXGocZz0sXHG4b9REW1fIXr/uB4CnjhdXX7P7nn7+kXnJ3kN5XuM4Z3L8pFPHnAuQZ6OBW9Obb1m3vc3xDaHAzd4rd14cZyrzslzzbTZ1YuVIfrJvOrMvInmO1Ro16NdGDy4vBjYxVbgM/1V5FwI8zP97qoBLDsuQSS3jGdkpkR2YdqRdgL8PUjGRRfoqUvb1pJrqdZ20qvscK/og/2oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KIzYcUwfJU8NkQPW+8zo1+10oeEh7cQfYBL50oVUuUI=; b=ECoec6bjK29jDvsnQvybzAAVwrTtdhrfvduSRVB+NtyDXux7D7xHp3UT6UIbyliYEx+dsSoMCNYMAqQPBHT+DKw5tgUSchsQsjDyF3k84ELWE87+7sA4kj9a4/4H2j3p6EzCCXUjL5ejizbyT47R7S7JIMH+e26ac9XyAfxDmng= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by DM8PR12MB5398.namprd12.prod.outlook.com (2603:10b6:8:3f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Wed, 14 Jun 2023 10:31:04 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::3b9d:9ac6:f3ce:e106]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::3b9d:9ac6:f3ce:e106%3]) with mapi id 15.20.6477.028; Wed, 14 Jun 2023 10:31:04 +0000 Message-ID: Date: Wed, 14 Jun 2023 11:30:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Ruifeng Wang , "Gupta, Nipun" , "dev@dpdk.org" , "thomas@monjalon.net" , "david.marchand@redhat.com" , Honnappa Nagarahalli Cc: "Anand, Harpreet" , "Agarwal, Nikhil" , nd References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230421145406.12831-1-nipun.gupta@amd.com> <20230421145406.12831-6-nipun.gupta@amd.com> <54328b0c-584e-dc58-2559-9d30e089a66a@amd.com> <8d729d5d-2de4-fc73-3ad6-d045079274e9@amd.com> From: Ferruh Yigit Subject: Re: [PATCH v3 5/5] config/arm: add AMD CDX In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0017.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::15) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|DM8PR12MB5398:EE_ X-MS-Office365-Filtering-Correlation-Id: 20796867-dc60-43f1-ace8-08db6cc27469 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PvNDkQUOJ572N8frZYtMnYT5ctVnmP2bEi1dyXxk2lGVo+AgLq4ofnylHoKarNOw1AylXC+IH2vshHp3P7mUX6RJs/jP9OLzKFa1l7yE7Sd81AK0E/wU1HNCC2KwLJuTL/4hZy4e+EzWr8IXBHYORoPzUSFhH0VVRaSI8E0br2XQd+pVmhgZa3Ge9sM3edM3G1NijSnF1bA/ccfjXR43U4JrcCmkq73v7zxOPb1gXr2x+hYlSDjF9zVr3sfM8Xj/liOvMj7W9c84ALYzzsQ9T9rCXez836u4xtAICYVjfn0JXmPwS9E5yY7kcNdeSJDXv3Op04K0AFtzBZDpNl/7DGiAeKzBlMkRk7ygxANdNmWaKuROmyMgO+vtfTQ88TskbceFV6AjYR1lk8E21rTdmGRxsmkdNoJCSBWTvuu5aCOnYf79rVV2fxGgjuxR4OgBS9DxxJW1IMH5JB3+lqDtxVRUDkVXdX107VX6rR2fC97CL96LvftuWD6lXYtqFGBERB357gCYi+MQdWsarZvS65lbEW138Kkq4vnQz7n/2uya9Dol1QXbap3LIwdJqtH8qd/q+fW9FQN0IvgiDdPv6nLeD5QbGELnLpMnEbLx4vm+lM21oMDcqD0nTqyds1eMgT48xaLPv1sGi4Tb7jwdCA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(136003)(366004)(451199021)(6486002)(316002)(41300700001)(2906002)(31696002)(6506007)(86362001)(186003)(26005)(53546011)(44832011)(2616005)(6512007)(38100700002)(83380400001)(5660300002)(36756003)(8936002)(66476007)(66946007)(8676002)(478600001)(54906003)(110136005)(66556008)(6666004)(31686004)(4326008)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OU9ZY29iRFYxSVp2TWJka2JrTlR6RWxwTXVtQ0pqNWZDOStRQXdJL0VOb0oy?= =?utf-8?B?RVlLZXNGbHorZlVaNGV2UWJ6MzZncnJZdlMzbldiSUZxc1RrRTgxQUo2bUVr?= =?utf-8?B?THo2ZXVJeW1JZG9QbnJhRVhOVldFSFRkL292Nml0L0JwemJibm9IdkdtOURI?= =?utf-8?B?cVRDUVFaU0tHVmMwUGhQaTZLVTB1aWJ4YjRwOFduSkFuTlZ6anREb3I1bUdr?= =?utf-8?B?Q0NSWm0vcGxMK2ZNNC9kb2E5bTR0NVpBZjRmVVBZWm1xN2lWWmJReTdSakd1?= =?utf-8?B?OVRnSnVrUlBmSVJybndWWTZuL2lZdndLdGpDSmZ6M3l6c3pjUHVSa0xuNEg5?= =?utf-8?B?eTNudEswOTBoSW1OSURkU0ZRYnpDc3o2WndDbUhVcTh5dTlmbEx5Z1VKcHNj?= =?utf-8?B?eVkwM2xBc2pJckVKWmlpQ2NyYzZuY0ZGVzVBYTNGRWdqb3JqWTBZRUY0MkVQ?= =?utf-8?B?VUlSOXN0cllIMTQ4NWNuZ2lnQ3lUSGxLajNYUGR0eUdseG5HYmJwMHJqS1Q1?= =?utf-8?B?ZjZ1ZlFZcHpSeGF3QmRicW1pU3dKdDBpL1JnQVBUUXhxdDY2WWZlOHRvZkVr?= =?utf-8?B?cjlQcmtEaFZCT0htUXNTMlg4RGpMa3hhQ0pWWWxwVi9JNTkzRjM5OVZOWlkv?= =?utf-8?B?ZG1kMXI0OVJUWDdMMyszUjBmb05rejBpUEdSZUp5YjFMWVU5Rk5xUnc3Y3gv?= =?utf-8?B?L1JmTjgvak9XUWIybVMxQWwvR0hQZGhEQWxRRiszOXd3QTJJNWRuVHpUZHVn?= =?utf-8?B?TnlEa25VUmp4cndFQ1hTbUpEeEZWSm5FVFc3Y2hyS2plQXVEWXE4ZXJkSkVa?= =?utf-8?B?Z1JtdU9ER3Z2dFZ6cWJ4eHZBZWhqWEpZVU9HWFZmV1JXdGlsUkRwZjlEWTE0?= =?utf-8?B?K2UxNFRER2kyS3NWTlJkODRrbzREUlhOZTZrVVdhNGJ0S3pzRE5KQ1VCQVh2?= =?utf-8?B?bHJON0YvNVk5Qi8ybE8wSzBxdlJSSFlLenlPYVJ4cXhtZHFzdk9wcVAyOEto?= =?utf-8?B?MjYwSkxGVlpya0ZldVhBMHF1Q2h2ZDh5VFZsYXkwNzZqcmlZWnAyZi84VnBO?= =?utf-8?B?dHppbHZ2TmJHdmkxRHhNRVdBYXlKMFBSeWJSU09WRlRLVEl0ZWpNZkJhVHov?= =?utf-8?B?RVViZnhhbDlGV0pvd2VUSWFpMXppbWQzeW5LRTRTVHFpZk9IL3NyMHpkcGNt?= =?utf-8?B?L2xSSGpRa1hSSjMyOXkxbFBKUTIxNTFVaGFQNDRGSE5kK2xNcXd6cjJOOGtu?= =?utf-8?B?WDU1RExoUHhLeC9QT2MwcE1RUkVzVVV2VUZzcHVIVkVUMkNuaG9JcXpNQjE5?= =?utf-8?B?R3FCNmFDcjBVa0Z2UTcvdW43c0I3YWZqM1BmVituZk5SclJnNVJpcEQxNXN6?= =?utf-8?B?Qkt3akVLMXBTOUtIWllNTGU3SHRiakN2Z3VSSDNaK2JvdXB6LzJTWWxhNTdX?= =?utf-8?B?WWFIOUVTL1cxZkUwbWZnNktBcDVNZ1g3UG94ZGQ3Wm1BQXRVRVlQcmFJamJV?= =?utf-8?B?WVYrMmRYMEdhdm40SzVIL1ZhVzZ5Sm43dDBmRGxzb3ZKUlNaU1ZBelZsdUlN?= =?utf-8?B?dVUxcGRlNnhyMGFvNSttU3JPdUtWNmFtTFc1dVhCaW1rb2x0a2VkLzQwVVB5?= =?utf-8?B?Q3h1V283TDFnWHNuTTJ4NXozdVROM293SjNGOUhCWWVuMzhRbW8rNzRJOU04?= =?utf-8?B?RmRzaXpENnhyTVdzRkVxTWtFa0c1aThzaU82NlR1WEtiQ282NDVpTHpndHI5?= =?utf-8?B?OGU5dEIvVEdmalBZY0ljWm16TUdNSW80NXdjUjZoYTBBZC9VRDBwa3dNbDha?= =?utf-8?B?UzV6SVJuMVJhYkV5ZzZIRG9tUzh4RTNQK1kybTgxNnpKM21FZGtjMGpCQ1Vz?= =?utf-8?B?ZmpvMDltbTBMK3pyREpWa3NnRnd3Vkk5RHNIRWxTd0JDb0YwOWxrRFlnTnRY?= =?utf-8?B?RERzTDN0UDhNcWxBWXk2dVQvNVpNSVR0dXVxWmEzd0lTME9mZHpFQnFQa016?= =?utf-8?B?MVhyMVZTcGMwWWtHUExmaVlqVVc0QTFTa1k2RE9GbFBKWHpmSDEzUVlNcWF3?= =?utf-8?B?WWZacVZWbTlPUzhjNXdlSU56K2o5a09ObTFkSHlWeFJHQVFUN2NscGxCSVlP?= =?utf-8?Q?xR+Dihe0Ms1E9PiJOZYMr+hiR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20796867-dc60-43f1-ace8-08db6cc27469 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 10:31:03.8380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tcjYGzKZSYnYGp9mDZsiizRFCiA+2FrwA8SniQ687/O4w6YZGZ6FjSyVq+CCAqrE X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5398 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/9/2023 6:55 AM, Ruifeng Wang wrote: >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Monday, May 8, 2023 7:27 PM >> To: Gupta, Nipun ; dev@dpdk.org; thomas@monjalon.net; >> david.marchand@redhat.com; Honnappa Nagarahalli ; Ruifeng >> Wang >> Cc: Anand, Harpreet ; Agarwal, Nikhil >> Subject: Re: [PATCH v3 5/5] config/arm: add AMD CDX >> >> On 5/8/2023 11:24 AM, Gupta, Nipun wrote: >>> >>> >>>> -----Original Message----- >>>> From: Yigit, Ferruh >>>> Sent: Thursday, May 4, 2023 8:59 PM >>>> To: Gupta, Nipun ; dev@dpdk.org; >>>> thomas@monjalon.net; david.marchand@redhat.com >>>> Cc: Anand, Harpreet ; Agarwal, Nikhil >>>> >>>> Subject: Re: [PATCH v3 5/5] config/arm: add AMD CDX >>>> >>>> On 4/21/2023 3:54 PM, Nipun Gupta wrote: >>>>> Adding support for AMD CDX devices >>>>> >>>>> Signed-off-by: Nipun Gupta >>>>> --- >>>>> config/arm/arm64_cdx_linux_gcc | 17 +++++++++++++++++ >>>>> config/arm/meson.build | 14 ++++++++++++++ >>>>> 2 files changed, 31 insertions(+) >>>>> create mode 100644 config/arm/arm64_cdx_linux_gcc >>>>> >>>>> diff --git a/config/arm/arm64_cdx_linux_gcc >>>> b/config/arm/arm64_cdx_linux_gcc >>>>> new file mode 100644 >>>>> index 0000000000..8e6d619dae >>>>> --- /dev/null >>>>> +++ b/config/arm/arm64_cdx_linux_gcc >>>>> @@ -0,0 +1,17 @@ >>>>> +[binaries] >>>>> +c = ['ccache', 'aarch64-linux-gnu-gcc'] cpp = ['ccache', >>>>> +'aarch64-linux-gnu-g++'] ar = 'aarch64-linux-gnu-ar' >>>>> +as = 'aarch64-linux-gnu-as' >>>>> +strip = 'aarch64-linux-gnu-strip' >>>>> +pkgconfig = 'aarch64-linux-gnu-pkg-config' >>>>> +pcap-config = '' >>>>> + >>>>> +[host_machine] >>>>> +system = 'linux' >>>>> +cpu_family = 'aarch64' >>>>> +cpu = 'armv8-a' >>>>> +endian = 'little' >>>>> + >>>>> +[properties] >>>>> +platform = 'cdx' >>>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index >>>>> 5213434ca4..39b8929534 100644 >>>>> --- a/config/arm/meson.build >>>>> +++ b/config/arm/meson.build >>>>> @@ -305,6 +305,18 @@ soc_bluefield = { >>>>> 'numa': false >>>>> } >>>>> >>>>> +soc_cdx = { >>>>> + 'description': 'AMD CDX', >>>>> + 'implementer': '0x41', >>>>> + 'part_number': '0xd42', >>>>> + 'flags': [ >>>>> + ['RTE_MACHINE', '"cdx"'], >>>>> + ['RTE_MAX_LCORE', 16], >>>>> + ['RTE_MAX_NUMA_NODES', 1] >>>>> + ], >>>>> + 'numa': false >>>>> +} >>>> >>>> Hi Nipun, >>>> >>>> Why we need a new arm platform/config? Is it because of above flags? >>>> If it can work with default values, I think we can drop this patch. >>> >>> Hi Ferruh, >>> >>> CDX driver works with generic ARM compilation too (arm64_armv8_linux_gcc). >>> >>> The versal platforms supporting CDX have A78 cores, and adding this >>> cdx config Helps to provide gcc option "march= armv8.4-a" which is for >>> implementer "0xd42" (ARM cortex A78 cores)., whereas for generic ARM >>> compilation "march= armv8-a". >>> >>> Maybe ARM guys can provide more information regarding if there is any >>> impact on using generic architecture flag (i.e. march= armv8a) on A78 cores. >>> >> >> Hi Honnappa, Ruifeng, >> >> Can you please support on this question, what is the difference of 'march= armv8-a' flag >> (comparing march= armv8a)? >> Should we consider adding an arm config file to support this flag? > > I see there is a new version without change to config file. > FWIW, native build is fine without this change. Because the specific (implementer, part number) flags > are already in place. What enabled by this change are options for soc build (-Dplatform=cdx) and > cross-build (--cross-file arm64_cdx_linux_gcc). > Hi Ruifeng, Honnappa, Config file will come as standalone patch, it only separated from this set. And config file is required mainly for '--march=armv8.4-a' parameter. There are multiple configs using the same parameter, is it a good option to create a common config for 'armv8.4-a', similar to 'generic' one? Or is it preferred that each SoC adding its own config, as done in this patch? Thanks, ferruh