From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CB1CA034E; Wed, 19 Jan 2022 18:28:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E45F441184; Wed, 19 Jan 2022 18:28:58 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id CAB0041147 for ; Wed, 19 Jan 2022 18:28:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642613337; x=1674149337; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=n47LMxAqbiOpsnROuapyK8VJoaT/ri2wlPvyusgFgUE=; b=Qck7Cz/NtPGwm5TmZKDeM39hsD++EjQRLrIwH/XUHIPzyODj6QQmfTUf HaRm24mwNXOaaDURO5hFTj00lSxqzlAneN/XFU4LRNN8aDco2qcq2dvod ycaIjJmA+vSnMzzQieDzgisyyuIJ6oOcjVHjw6xCoAwng6Y4ESXHvMfgp YBOju++DNeSh6e6Yry+l4GLIw98O7LnUPJu7EGs/Rl8Ua3hD15/OjjVdI joBhkXvWFAeynmRXVK6EHzlusKbDzKqcnO5JBJgvD0cpIFuIulowEKTDq ztde5c27Mb4Q2a8dryImdZk4ocY/C6ARJjEDxx/IkN4hgOC72p3ICTvtZ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="225795863" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="225795863" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 09:28:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="622581357" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga002.fm.intel.com with ESMTP; 19 Jan 2022 09:28:20 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 19 Jan 2022 09:28:20 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 19 Jan 2022 09:28:20 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 19 Jan 2022 09:28:20 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 19 Jan 2022 09:28:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NfPb2AoNcnlIoBNUSpWTm67xn9K7R7cAXtTbyNsfogj18LB3vOZd9BMhqzUAcA2yLyaALNY2MJ/Zibww1Po1Dt0IA1Ju8AfFx5r3Tuzo/R/fhTQHWkvKatKcodxp6TmJQd1Tx2t3GKCFNXkh+MhTFNMhVnlAuRdXY+qUwsEEfAdjuI2A3W1QcpIx3odke9av68f05FuoGdyRmDQdLviLKjjQn4pEigicnqSLDkgEXUlYfdxi21wMXA1Q6F6AGMfpEsOUZSYX6KYdoIKRRheDUSgavib3D8Jv2gijTxbQarD5XCHksqqpR5BIKlyDHbuMuVqVGAoIYwe7B97aIOSBkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ikgu0CDv5+jAnycyDXdPjQ/vE4tfwfedm75idps/1eg=; b=dlSOTKnm6TV9dqV3KVQDh5Cqb9UT59DSbS95OlwrcwFsPsIArHvx3i0QzD3jl+FiBwTqBEbI6ebBeJA5KVzQ+VhIG6Nd5wAC68gK47XnjudSFhQ1Cd96r8265yRw7GSNJhJGwtAE8xRetW1N6ML2LBHaw96iA3NlUpx6sFqgiCuHhovnwitBkWp90QSOYlZuE7hW/hpQSbAdZZV6CADSd4vqjBdHdQ47po58SZALnjpH3poGUH8v7EdlFT3LF1GqmPcaLWRpb9EjDz6ikYFEebKZo3uNAgZXNHSuG49YhrHGc1svdkGQ2oRaehCU4XUbJC2hwCWg/1H1xBDgenJrhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SN6PR11MB3277.namprd11.prod.outlook.com (2603:10b6:805:c4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.12; Wed, 19 Jan 2022 17:28:17 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.008; Wed, 19 Jan 2022 17:28:17 +0000 Message-ID: Date: Wed, 19 Jan 2022 17:28:11 +0000 Content-Language: en-US To: Yanling Song , CC: , , , , References: From: Ferruh Yigit Subject: Re: [PATCH v6 26/26] net/spnic: fixes unsafe C style code X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0390.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::17) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e680784-e67f-4a3f-b00a-08d9db7114c2 X-MS-TrafficTypeDiagnostic: SN6PR11MB3277:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LDtkvRFfjjaehf/MPz/PcU3iQTGOvdyG+a799nZ1wYtgtja8exYgPBFdm9hDqWjkryqpjDWwlVCBpP6MiHjChshgdD/Pb+SvAl9fETr4wIrte3GF3oMREdYdu+EXhGBXSw2jGEMvmVbXoDZQIa/JEEVIFNVOUbxy8O6oJqJmlpf+yIWB+diz9KpUdPQsN8YA1M6TOWYHSoQKJqBl93PCVoDxzM7CrYAkiARSfiPo4HFs4cbJpIJufgc4j50Yu5uf7cMRbbuqNqOhCtSU1rmdCHcsr2xwWuWIVaIVE1odbxPvF2aLXCK4TYg6zsLBaQm6FOpFEm6hlf2kW5avu1PSIYMjCWFTAKl2k9tZjp8+CfdWkkyhDB6cYLuAzEe8TsAxzEv9coLeM5zrLfx/2XuIa3+uGzxRaHLOGeGAbYYKlSbuk1USOWxz2f2N7LAjZE0zqhOKo0QBv9lxKRnV7MN1DAdbE4/kvOctDVvsDBRhslbu24Gq70x/DX5A2rypSVu6PYhdiO/x0KO2vcQH+Wb+X9AabeY0OnGNvllOrHg6mtCZpHromKN1fY3LzbIc7h8dwHMwBuIThnV3NcsJ/eSgDSnIlSFixeYN63mZRmqQ4s8H17/INkkuvXArVgaYbWTOw2vjG90FmUwpsQZJaFuGIobGG9CPD8DU9rbCW/3KqgxeYmtzWng5qQnKRduThEpB8wa5Mb373g0srtJUJPAM/w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(82960400001)(8936002)(2906002)(66946007)(5660300002)(36756003)(6666004)(6506007)(53546011)(83380400001)(66476007)(66556008)(26005)(186003)(31696002)(38100700002)(8676002)(86362001)(6486002)(2616005)(44832011)(4326008)(31686004)(316002)(6512007)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzFmQ1RhZ1ZuSHBWY1BpZnZKQlFBekJ3di8rM01xVE85d1Rodkxtc1UxYnY0?= =?utf-8?B?TVZkZXhtZ2RIMU5ycnphSjAyTkxsRTUxN3g5Y3hyOExTaXd3NnZsMm5UZms3?= =?utf-8?B?ZDlWZFRxTlA2TXpxWS9DSXFzQjQ3TFd6aHpVUDh2MDlvVXUrV0RKZFdMclVN?= =?utf-8?B?bVh5SEY0Y3ZWSlJZRUZXMUhjKzNDWGIraGJTaHdFV2ZJWUV5QXMwcVBibys1?= =?utf-8?B?anJuQTBZMkxqd2lMQ1Z6bGpMZ09tdkoyd2tmbG9UNzd3cmFDdnNpMHJpKzlX?= =?utf-8?B?Y0NOSkYrYXZHMnJ5V2I0d21qWERHOHJ1M3BQZ2RNOVlxTzE0cWUyOStZVHVj?= =?utf-8?B?NHZucDQzQUR6dHV6MTJobTBUZ1dKZWJsQ1JxNi9kREVNSWF3NldrVmt3dk5a?= =?utf-8?B?L0JkSHZpRTh3TnVMemJLcENzazlZeUF6cEFmNVJJSFRVb1YzNDc4TXBMUTYx?= =?utf-8?B?VGdQUzF2WFo4NmMzd2NPLzhrRGpaVytOT2VpRHRNZmVYZUY0OFVqaG1kakR2?= =?utf-8?B?Ym5xbTBDZnRtNE5VV3o4ZTNleVh5dzBJYmZNaFJ1MnNFRmFSbjI3Mk43RTFM?= =?utf-8?B?Nk5IY2VIbnBWNUxUR1NFYnJEVk9ORDR0ZXo5endNM3BvODNxcEplQ081c0dK?= =?utf-8?B?Sjd5VHhSa0E2czl3M21jVlp1UjlTTk9WUHlEbFRvRVdia2hpRzhURzFLWHB5?= =?utf-8?B?OFNSV3l0WThnVCt0WXpmNlFvdzRtQXd0cTZUMXNWTkx4NThhb2dxeEw2eE1H?= =?utf-8?B?aERIdE1PSnJxVHk4YTB4eUQzMzBCTHY3OElOdG1hbThBWTJwdkhnRHVGYlJE?= =?utf-8?B?VlZCL0M0YStMTGZBczR6TjdtTk1HVTU2SkJjU0oyT2FUclNaUS9URUJZbEsw?= =?utf-8?B?Q2JFaHdZRm5lc0tvQXYvSUJGUzJHM2tTSkVLTU0xbHpPZ24rTDJITkRlT3lZ?= =?utf-8?B?SjAyRFBRZUdSNjhNVjJ2SlRXSXhQRUcrQ3ZOS1QzZUN6eWYvK0FheUZTU0RG?= =?utf-8?B?a3NZS3BLRHRJWjF0WVZwZUpteUFtdmNRaHRub3dyNGZWRDZPcGEyRlMyOS9i?= =?utf-8?B?em9FMStEMXpJSUMvZzIraGRZdm0rSW4zM1NBZWdRSEx5dnZMaXh6NjhxTkIy?= =?utf-8?B?aWQrZ0JvZGk0bG91bEJZV0pyL3BZWklORUx2OWx5NEtBM091MWpMOFJaN0Zk?= =?utf-8?B?Ui9yNkFKeG1MelVhMlM3emtjOVZEN1BoNkFvTHlXNWxzdWJkbE9LVUNYWDRz?= =?utf-8?B?VWFTOGgzZGNEQUJ2VG1qdWpIVHR1V1l1ZmxLVFZOUFBmQlhqWDRvNit3TG5u?= =?utf-8?B?anZFSzZ5UWFOcDB6bG5lZERGZkNwMzdwRk80WEVtbktzdTUxaW4wdURVS2F0?= =?utf-8?B?am1Vd1ljLzdGZU4rdldpZ2QxZGY1RjdFUjE0TnN2OXVPYlh5WElzLzZZY0lU?= =?utf-8?B?cnkrMnNrWEsvQ0tsQklOSVpoRVZRY1ZnVUViYzFsVzBScUllamVmb09ySEho?= =?utf-8?B?ZDdmRzBCZ1FCQVZ1SHgrMGtMeVBObFNIWXJlRVBwK08xOEFYTFhCSXFpTnlu?= =?utf-8?B?d0V6UzhGM0ZReGRYY1Q0Q0UvMWZYTC9JWUhtMFhEYjBQWjBYd3M2QzNwZ21q?= =?utf-8?B?K0JJLzRCUWVsTGdkWTkwRWd2Rkp1bW1yVDNSVTJ0eDBubVQwMXF3aEVpMGE2?= =?utf-8?B?KzNucGp1aUxIU0xyVGpNQmdzb2tlMm5UQ1Fya1M1L2taZWpEKzFmMVc3THlt?= =?utf-8?B?anNFNWpsTEErZEJZZi9VRldKVmt5M3NacnZUbGMxMmFGaTk2S1pMWi9xc1pH?= =?utf-8?B?NW5NSVRxb3ZKb1cvRUtrSGhkVXVZaE56SSsyMFFrNUw2L1JwbHFXa0kvay9N?= =?utf-8?B?YzV2R05GVnozRHNtOUhBVWxnNkZLMkVJRGtEQWtmVWJWOXFFSUVaSVkwTklt?= =?utf-8?B?R0haY3k5dGhDYnpiblpWTXJvREtyYUdxdVRpaVFPTEpzVkFUdWc3WTVzeG9t?= =?utf-8?B?cFhBUnYyVEV2UG02ck9uaGNpVGJyVHNWTHFLMWR5RlVValdtZ3VFQXhKMFdD?= =?utf-8?B?M2xGRy9qWmhxNTdFVTcxTS9LNWUvZE1zUFN3NS9WNDNKQ2g2NjEvMHJhTXBH?= =?utf-8?B?NmkvTmEwY1VQa0V4bnJmbmk0VlVEQ3lKNWYyVVZBdExJeldzRmRKeHB0Q3dt?= =?utf-8?Q?71avFffpA4XjLCtI5fV2YRg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5e680784-e67f-4a3f-b00a-08d9db7114c2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 17:28:17.8072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qM0HVwhr0+zmt2HP6h2R3mFtcJKgxzDN6cEu/JgsO+NyPN79u/a5OJjd5xxTolX1fivc9lbMHUAM2r8Uuk1hyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3277 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/30/2021 6:09 AM, Yanling Song wrote: > Use the hardware structure instead of void* as parameter of > function to keep the type information Hi Yanling, This is a new driver and first patchset for it. Instead of fixing it in the set, why not update old patches to introduce them correct at first place? > > Signed-off-by: Yanling Song > --- > drivers/net/spnic/base/spnic_cmdq.c | 14 +-- > drivers/net/spnic/base/spnic_cmdq.h | 6 +- > drivers/net/spnic/base/spnic_hw_cfg.c | 49 ++++------ > drivers/net/spnic/base/spnic_hw_cfg.h | 16 ++-- > drivers/net/spnic/base/spnic_hw_comm.c | 32 ++++--- > drivers/net/spnic/base/spnic_hw_comm.h | 22 ++--- > drivers/net/spnic/base/spnic_hwdev.c | 8 +- > drivers/net/spnic/base/spnic_hwif.c | 52 +++++------ > drivers/net/spnic/base/spnic_hwif.h | 22 ++--- > drivers/net/spnic/base/spnic_mgmt.c | 9 +- > drivers/net/spnic/base/spnic_mgmt.h | 4 +- > drivers/net/spnic/base/spnic_nic_cfg.c | 110 +++++++++++------------ > drivers/net/spnic/base/spnic_nic_cfg.h | 84 ++++++++--------- > drivers/net/spnic/base/spnic_nic_event.c | 30 +++---- > drivers/net/spnic/base/spnic_nic_event.h | 10 +-- > drivers/net/spnic/base/spnic_wq.c | 3 +- > drivers/net/spnic/base/spnic_wq.h | 2 +- > drivers/net/spnic/spnic_ethdev.c | 10 +-- > drivers/net/spnic/spnic_io.c | 34 +++---- > drivers/net/spnic/spnic_io.h | 10 +-- > drivers/net/spnic/spnic_rx.c | 4 +- > drivers/net/spnic/spnic_tx.c | 4 +- > 22 files changed, 252 insertions(+), 283 deletions(-) <...>