From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9256141B90; Tue, 31 Jan 2023 17:47:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 705114067B; Tue, 31 Jan 2023 17:47:12 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5ED2040041 for ; Tue, 31 Jan 2023 17:47:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675183629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=axQJnaHVy7MAJ583xugYdaqj1vJADPJCaoxXPagI6n8=; b=a9BSNpmNo4WfvFwRfrjxSbA0VksxdIwvoucHcPRwqpGNUwH/Gi9ksIEGz55YCnpoU9uNRX ndZ70DP8tjzbdxB0mgaoYpby6ZzObHqNau4iNpa6P55Z8okH1ouF4iuyJ9PSHrs7Y/4HxZ pLXleeRGEwHy9uTAnGMK4JK1BW0goTY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-163-P5OYFaznNDy7FE2v9MTdhg-1; Tue, 31 Jan 2023 11:47:05 -0500 X-MC-Unique: P5OYFaznNDy7FE2v9MTdhg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 93E9D2817227; Tue, 31 Jan 2023 16:47:04 +0000 (UTC) Received: from [10.39.208.22] (unknown [10.39.208.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3582FC15BAE; Tue, 31 Jan 2023 16:47:02 +0000 (UTC) Message-ID: Date: Tue, 31 Jan 2023 17:47:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v4 3/9] vhost: terminate when access lock is not taken To: David Marchand , dev@dpdk.org Cc: stephen@networkplumber.org, chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com, xuan.ding@intel.com References: <20220328121758.26632-1-david.marchand@redhat.com> <20230119184620.3195267-1-david.marchand@redhat.com> <20230119184620.3195267-4-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20230119184620.3195267-4-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/19/23 19:46, David Marchand wrote: > Be a bit more strict when a programmatic error is detected wrt to the with regards to* > access_lock not being taken. > Mark the new helper with __rte_assert_exclusive_lock so that clang > understands where locks are expected to be taken. > > Signed-off-by: David Marchand > --- > lib/vhost/vhost.c | 18 +++--------------- > lib/vhost/vhost.h | 10 ++++++++++ > lib/vhost/virtio_net.c | 6 +----- > 3 files changed, 14 insertions(+), 20 deletions(-) > Nice! Reviewed-by: Maxime Coquelin Thanks, Maxime