From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A49042421; Wed, 25 Jan 2023 14:55:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E01542D92; Wed, 25 Jan 2023 14:55:40 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2079.outbound.protection.outlook.com [40.107.237.79]) by mails.dpdk.org (Postfix) with ESMTP id 9979C42D31 for ; Wed, 25 Jan 2023 14:55:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAFixSaCekRk/qRc9O8Aixac5u0i2xLBml7ejXdOH5D+sLKRBGjSIYRAQQBzRGqffyjaUt8qXAknMQFixTDoQnJSaTxneYWAful85AeYzKp7ag2gLW37RRZLJSq/ntAmaSwPO8r8oinqEtdijxMj4n9T7X1+LdQ7ZTzLtBVf8DqIC/TsWH72rsAcuPrf8c8p15LuqU7HowMCxfYcvZuH9QnWiNGn6au4VoCXgmBh4HNw/ok2kgLEMCoBHxdsJop0M6QEQShI9SfAneP+uHx1eBVvwX3jYEcrkXq2EwtUmD2CuuU0eUhQCpI8ycFZ1kVYWy+KGETn4f4HPNRAQWEt2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AEE8K84igqENsghgfFJBt93W9+YMAUJorO1VAf5jbbE=; b=ELSDW6hu/vxexyEQWu/Z2KLlzK0wUoTzSYZxHsKFidUiJYBTE5qbAENvPyJHaAnr3toeDzCPl8zvbSnsPv80UbL9yWJi5j8JIIdOdhfHqq5AsmLeg2706Vg6G3HB+TOSeFlG9cFCapteDuonzJJuqRHpxcbMi9Qi7dZv9jNZxS2IsnBL+P9vN1CL/uNJSUzeiQ5EAB60Azk3BmWrvyuwNj9TMCm4UaIe7EhWWq9s+euG6XT2o3yTgfhniConQuV8R4ctOdcD2F3ely0g8MZJGAXtbBCBtoL+mub5ycrVfQqgLgAz9ie5ZOE1QXWqoGyjFAljrr1gdI/Yfj9d4GXGzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AEE8K84igqENsghgfFJBt93W9+YMAUJorO1VAf5jbbE=; b=VlHiQVWEvO1gNed6uO6RUn1MO85h59CmJ5KJ9x0l1glYCvDKy3+ey8dusrujTSK6k7ZqWwSaBLpzrjKoimnJT4vqq5Ct3hKiLZiGDEzBadzZTNlGMv9YS5Kert3i8ZvNJPn+dDfFXHbDibVFWiBusGxOPxPMKaOuiRatCNI/k8Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB6830.namprd12.prod.outlook.com (2603:10b6:a03:47c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Wed, 25 Jan 2023 13:55:37 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%7]) with mapi id 15.20.6002.033; Wed, 25 Jan 2023 13:55:37 +0000 Message-ID: Date: Wed, 25 Jan 2023 13:55:30 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Thomas Monjalon , Aman Singh , Yuying Zhang , Ivan Malov , Andrew Rybchenko , dev@dpdk.org, Hanumanth Reddy Pothula Cc: "viacheslavo@nvidia.com" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , david.marchand@redhat.com References: <20221220200250.2413443-1-hpothula@marvell.com> <11fa3448-7348-09d6-b7e0-321aef1d8953@amd.com> <5290135.upeRZZJTqa@thomas> From: Ferruh Yigit Subject: Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation In-Reply-To: <5290135.upeRZZJTqa@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0207.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::27) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB6830:EE_ X-MS-Office365-Filtering-Correlation-Id: 21a07b21-7d8d-4794-9928-08dafedbd60a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VrGC63lg5h3G8dgNsXIcpFz5AycjGLR7pgRAngFQzWv6YcjjDnX8F7HPAm2/XPupYU9qdNfL9HW2mm9+QpecM12+uDx2XE1/QTzL2RDJzDq1k/UTWW196qr5Fw1C6syyYfK/hZn4fBPjBUi2ayeTHvJslisBsbOdNZb8ILojqR16yJ5W3G9kS3NDykbMqYQJ1UsTULGEaEqsFvZPP4UNV9xMkK6UvDJvXyTfEKuFrp0IYcxbUP8SwDBll3yol4nFOJgDgUm98oBPhO49tx5QDlNpuffoTnXqRN4pIOaCXSavP4T+hKZYbvvAoMFM8gy310jRcp+mPNTpfy9h3O9wVBT2rRIJ7ILtHaE4ItsRr0JmBYky3qx8egwXEms23pov6kuOo5mTO5j/pswNkxmYLtmaq5p24OBjo3y5ULFREw0B6zDF5FvkyHRV8vMA5bQU3yBqtk21zB36gRbqtgJyiqE/y24xjcX3bBXMjyrou0Nhc7VSdhDtugDDMVWmGBdsxSGmcM97PoPkQLhHF+HEjGhUQbEvl0hCjuUeMQIanQYKbdLfpRUi93E0sB2aQ9p6gISFg4tzDGDRNblTkwmsDqA3ffdyc/9SICShkFM3MbUBNKOQfnfoFIJy1ie5BtMjduCvx0fdS5Gq2YtLu68+zPhvQrWBZuGgP2a0i9ec+2GfhZ53NkIF08xgJfcNS1ZFvK19fFhsVODu/WzFU6dm5Kr6Iku1EBvIkjdiYKdUEAA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(346002)(136003)(396003)(39860400002)(366004)(451199018)(44832011)(186003)(26005)(6512007)(6666004)(6506007)(86362001)(4326008)(8936002)(7416002)(66476007)(66946007)(110136005)(2616005)(38100700002)(2906002)(478600001)(6486002)(53546011)(54906003)(41300700001)(31686004)(36756003)(31696002)(316002)(8676002)(66556008)(5660300002)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlpETUhnUUZYcnJkdXpPZkxaSzVEWjNHZWlBUi85bFlTczRqWEQ4Qk9xaFZi?= =?utf-8?B?QkhzNTVwL1BGazRTMkMrbE51cXFDM2VPMEVzMU1RSXhpVG5UTG5Oc0FQUkZv?= =?utf-8?B?Z1h0N2ZoSmxvRW03OFBvQWl4VzRkYW5VRExPLzIvMFNCUFRBQmhDeGcyNStz?= =?utf-8?B?SDIvWjlMbXZSaWs2d1Y3L201ZGp5K0R1S1I5eStxVUkwejRYNndVakdVSzBM?= =?utf-8?B?N09yTThtQ21Yb3FMQUdnWXlENTNkazRWREgrQlg3VDBENXBKNVIwdFl5WG1B?= =?utf-8?B?cGhQNDZNanRvMFd4QzVCWHV0NlZZU2J4QzVUb0JaWVZGQ1dML25YcHNTd2Rw?= =?utf-8?B?RnpVdGU0MHlVbmttL2hXNVJQb2tnMmE3Z1p1RXJqcUljODNVRHppRWJ6eTFT?= =?utf-8?B?b05uM2VoWDBLRXE5bURLaU40RHd2QndGTnV6VXJSYXZWTzZmb2dSYTFRalJy?= =?utf-8?B?Z2EvMmE3cDRPamtmVU02SHdpZ21TTE83d01rTFBLd09rcThCbEhoa2I3d1Fv?= =?utf-8?B?bkMrWGFaY1hPb0w3QkwrWEZCSStIU2dGVnVMMzY5MVJoNjdMVzA0KzlocC96?= =?utf-8?B?VVF2NnFOSzM0R01qYXZXVzdiYXVTK2xjQjNYYXJ3eFNWMlgxTTJKZ1AvU3NT?= =?utf-8?B?SFBaN0xtbVRjWGNxWEk0Qk94MnJGMCtONEZ2V1MzYWw5ZWswcllHVmJla1Vy?= =?utf-8?B?UjlXZ0xKOVJRRzJGSXcrM21PNExWN1VIYWh6MDIwTndHUEMweWQ3YTEyRFBn?= =?utf-8?B?THBlUHcvM0t3QzdQb1RYamxLVllqcFhkd1hIRU10a1UxaVRhY3VsdzIva1Yz?= =?utf-8?B?R1JpSzdDZXBaQlBKWXhEN2VnNjNEWS9sTmJhWGlQbDZ3OHRWazl0cktYeHdV?= =?utf-8?B?WEd5R3BQTk9WOWFDUjBJcFBUSGlWcXNXYURTbDJ6SkJOMG82NkhlNXZ0TkZS?= =?utf-8?B?RkxZWVgvVTJIRmlnV3hkNzFFTVZrajREWEZheS8zRGdnRHRJekw5WC81NGFK?= =?utf-8?B?YXltblBwTExtcGhUVnozSlpmWXZEOHBsYzJwWXRFeTRPZzRhR3JhSi83bm5X?= =?utf-8?B?bGNCKzY5OW8rOWNvSUQ4K2xvQlN0NG91NTZvR0lDTkx4ZHpLNDJuZkdVOEg4?= =?utf-8?B?aktzQ1MrNjdPWE0yR21yMVp2S0JPQVlPdFpDYm1VZ3ZmWFU4b0p4a3ZjRWs4?= =?utf-8?B?cmRqOEZSd1ZPaDZkQUhDRUx1Wlk1STRRcDRPTzhCalpBUldtb0ZLMDJ5dFpo?= =?utf-8?B?Yzk2bHF3ZEowMVRjaTljUVE4NEdyOVM3RUg0cjNCWjNLZ1E4dDRjRXl5YmVG?= =?utf-8?B?N2w3OTJLcE5DZGRkTXNTRmNnK1BsV3BHTllzTFN6a1FPeXBiTWJZdzd5eGNN?= =?utf-8?B?Wklpd2NabHBaY2FhRWQyYkJzVFQzREF2MWFONEQwVzFMWlRCR3dEVjZSUlY2?= =?utf-8?B?UkNTWTZseDJtcG9wRWFIRjBHOVhFQjQrbVVFU1VhS0o2cUxmbHVxVXJ0THBO?= =?utf-8?B?WmhHV0krRnRVeUZLSkhHZzJkc1NreFRpVnl1OVNVNUJQM1N2SnB0Y0VmOE1D?= =?utf-8?B?N2x2NUtvbkZpWVFTR3hTZ3FSM3ZFOUVGYlJPK29WVHBxSG82bkVza0pldG0x?= =?utf-8?B?aGdkckRBTDRlR1NwZ3pWUlB1MHhwaDVKSzF3UzdOc3RMaDlmQ1k0WkI0OVJD?= =?utf-8?B?cVlEUVJ3akFIWEozYTkvUVBBYmlJYzFTS3Z0VHpJMzB6OFpveWxXcVl3Ymww?= =?utf-8?B?bXFLQ2xQWTFBZEErb0hNNDRJUXpDM09JRWdpYUdFQ3dkTlorN3puU05jYTln?= =?utf-8?B?cDlEMmNGWVlWK3NSa3Q0enNtUkZPTU5QczlvOXUvRG5uTjNwV0xiNTh1Y1pa?= =?utf-8?B?eUJJWHVndlp2a3R2UUR6NW01Ty9oTEFRTm4rMzdBVG1tazRlRDJUVGUrekxx?= =?utf-8?B?S3pSZ1dzM3IwUWk4V2tuRFpGT3ZyTlJYaTN0WkJPTlhrc0xhZVdOZmpidmk1?= =?utf-8?B?STZzVFdpb1l1MGtwQlROZzExQjNiMGhPczcxdFdJNW1qUm1EeU1HaU40bHdP?= =?utf-8?B?UVNHOGJsZ0MvaTZBdXFsR1l4cmtsbEJaS0R3VnZLdEpCTS94L1FhdzM0QjZX?= =?utf-8?Q?85d93gk3FVZmhwaKPhwTAizrA?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21a07b21-7d8d-4794-9928-08dafedbd60a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 13:55:37.1001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fDQI4j9OA4YOKh2H+5+UCnv0ykVy9Br72a1KrXBXmz5nBRrq8T9uv/pEvAm1b+yy X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6830 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/25/2023 12:55 PM, Thomas Monjalon wrote: > 25/01/2023 10:30, Hanumanth Reddy Pothula: >> ++ Ivan Malov and Andrew Rybchenko >> >> From: Ferruh Yigit >>> On 12/21/2022 2:07 AM, Hanumanth Pothula wrote: >>>> Presently, Rx metadata is sent to PMD by default, leading to a >>>> performance drop as processing for the same in Rx path takes extra >>>> cycles. >>>> >>>> Hence, add new testpmd command, >>>> 'enable port nic_to_pmd_rx_metadata' >>>> >>>> This command helps in sending Rx metadata to PMD and thereby Rx >>>> metadata flow command requests are processed. >>>> >>>> Signed-off-by: Hanumanth Pothula >>> >>> Hi Hanumanth, >>> >>> I agree with Thomas for the patch. >>> >>> 'eth_rx_metadata_negotiate_mp()' requests all Rx metadata offloads to be >>> enabled, but at this stage if there is no flow rule for Rx metadata why it is >>> consuming extra cycles? >>> >>> Can you update driver code to process Rx metadata when it is enabled by >>> application (via 'rte_eth_rx_metadata_negotiate()') AND there is at least >>> one flow rule for it? >> >> #1 What is the purpose of rte_eth_rx_metadata_negotiate() API if it is always called by testpmd. >> We thought it was added so that when that metadata is not needed, application need not call this >> thereby saving cycles/bandwidth. > > testpmd is for testing all features. That's why all is negotiated. > Cycles should be saved if you don't enable it until a flow rule requires it. > Hi Thomas, Not just for saving cycles, but from testing perspective too, do you think does it work if a way to disable these Rx metadata added by keeping default behavior as it is? And new command can be in a consistent command syntax like: "port config ..." >> #2 We use this API similar to Rx/Tx offload flags so that we can set things up before device is >> configured. We thought that is the purpose of having this negotiate API and avoid depleting offload flags. > > It is just a configuration negotiation specific to metadata. > >> #3 Generally any new offloads added to DPDK would be in disabled state in testpmd and we would have >> an option to enable it. In this case, testpmd is by default calling this negotiation. > > Negotiating is not enabling. > >> We can update the driver if the purpose of this API is clear. > > Please do. > Is following understanding correct? API Flow Rule Result ----- ------------ -------- Enable No Rule Feature Disabled Enable Rule exist Feature Enabled Disable X Feature Disabled