From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C268A0521; Mon, 3 Aug 2020 10:25:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 675672BE1; Mon, 3 Aug 2020 10:25:31 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 4359C2BD8 for ; Mon, 3 Aug 2020 10:25:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596443129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HKuWwMe89yvIoldaa1xifTOt4S1FAD6yMAJu51N7Pv8=; b=HKu06H06PFZP8nxhd9bTixHk4OK9PFPJPkyrODSw2Xu1UvAgk6uqgUDYtUJ27lM+Efgmgq muvB67MQxDdKMmXbupdPc/glcFDWCUn4LsVvmZbrK+KRCxacGOH/9EmMHfQB3sZTWvWid+ acRt5c+WqNKy0cQkteCg0TM69YSPMUM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-Gv-YJ6xeO4Sq-xgrLKVTVQ-1; Mon, 03 Aug 2020 04:25:24 -0400 X-MC-Unique: Gv-YJ6xeO4Sq-xgrLKVTVQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 97689800460; Mon, 3 Aug 2020 08:25:23 +0000 (UTC) Received: from [10.36.110.16] (unknown [10.36.110.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE2B774F58; Mon, 3 Aug 2020 08:25:17 +0000 (UTC) To: "Chautru, Nicolas" , "dev@dpdk.org" , "akhil.goyal@nxp.com" , "thomas@monjalon.net" , David Marchand , "Richardson, Bruce" References: <1594930811-12873-1-git-send-email-nicolas.chautru@intel.com> <1594930811-12873-2-git-send-email-nicolas.chautru@intel.com> <18daf845-298b-43c9-2e2a-316d64cec9fd@redhat.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: Date: Mon, 3 Aug 2020 10:25:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [20.11, PATCH v2] baseband/fpga_5gnr_fec: add companion PF config App X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Nicolas, On 7/31/20 5:17 PM, Chautru, Nicolas wrote: > Hi Maxime, > >> >> Hi Nicolas, >> >> On 7/16/20 10:20 PM, Nicolas Chautru wrote: >>> Adding companion application to configure HW Device from the PF. >>> Then the device can be accessed through BBDEV from VF (or PF). >>> >>> Signed-off-by: Nicolas Chautru >>> --- >>> doc/guides/bbdevs/fpga_5gnr_fec.rst | 80 +++-- >>> .../baseband/fpga_5gnr_fec/pf_config_app/Makefile | 36 +++ >>> .../fpga_5gnr_fec/pf_config_app/config_app.c | 333 >> +++++++++++++++++++ >>> .../pf_config_app/fpga_5gnr_cfg_app.c | 351 >> +++++++++++++++++++++ >>> .../pf_config_app/fpga_5gnr_cfg_app.h | 102 ++++++ >>> .../pf_config_app/fpga_5gnr_cfg_parser.c | 187 +++++++++++ >>> .../pf_config_app/fpga_5gnr_config.cfg | 18 ++ >>> 7 files changed, 1087 insertions(+), 20 deletions(-) create mode >>> 100644 drivers/baseband/fpga_5gnr_fec/pf_config_app/Makefile >>> create mode 100644 >>> drivers/baseband/fpga_5gnr_fec/pf_config_app/config_app.c >>> create mode 100644 >>> drivers/baseband/fpga_5gnr_fec/pf_config_app/fpga_5gnr_cfg_app.c >>> create mode 100644 >>> drivers/baseband/fpga_5gnr_fec/pf_config_app/fpga_5gnr_cfg_app.h >>> create mode 100644 >>> drivers/baseband/fpga_5gnr_fec/pf_config_app/fpga_5gnr_cfg_parser.c >>> create mode 100644 >>> drivers/baseband/fpga_5gnr_fec/pf_config_app/fpga_5gnr_config.cfg >> >> I think having the pf_config_app in the driver directory is not a good idea, >> this is not the place for applications. >> >> Also, it is not integrated in the DPDK build system, so it cannot benefit from >> the CI. Having an external dependency that is not packaged in distributions >> will not help to have it integrated in the build system. >> > > Thanks for sharing. > Note that all these points were raised openly explicitly earlier as you know, ie part of both pros and cons. > Still happy to get feedback from others notably Thomas. It appears you had side conversations with him on this very topic. > >> I see some alternatives: >> 1. Move it in another directory in the main DPDK repo, but it is not a DPDK >> example, not a dev tool and not a build tool, so it would need a new >> directory. >> 2. Create a BBDEV tools repository on dpdk.org (It would require techboard >> approval). >> 3. Host it in a dedicated repository on Intel's github 4. Move it into some >> Intel FPGA tools repository > > There are several others options which were indeed considered in case this option was not viable. > Still DPDK was considered best option so far to keep everything in one recognized place for BBDEV devices but happy to get further input from others. > >> I think option 3 would be the best to get it packaged into distributions as it >> has no build dependency with any DPDK library. >> You could maybe add inih library as a git sub-repository within this repo. >> Other advantage is you wouldn't depend on DPDK release cycles to get fixes >> merged. >> >> Regarding the tool itself, I understand from the commit message that the >> tool has a dependency on the BBDEV PMD version, but the tool run on the >> host while the PMD driver is used in the guest/container. So having it in the >> driver directory will not really help, as host DPDK (if any) and guest DPDK may >> come from different parties. > > Yes this was captured earlier, purely stored there as a companion application for a given > version of the PMD (ie. different subdirectories for each PMD directory). > They do no run in the same container for deployment and are not built at the same time indeed, their interface is the HW really and one being needed to be run prior to the other one to be functional. > >> One question I have is whether this is the tool itself that has a dependency on >> the PMD, or just the config file? > > Each PMD directory would have its own version of the companion PF config application. > Ie. the patch above is only for baseband/fpga_5gnr_fec ie. Intel Vista Creek with 5G LDPC user image. OK. Does it mean the same application and configuration will work for baseband/fpga_5gnr_fec PMD versions v20.11, v21.02, v21.05, etc, ...? If not, is there a way for the PMD driver to detect whether a wrong configuration was applied? Something like checking the FW version of a NIC is supported by the PMD driver. > There will be different companion applications upstreamed for each other PMD directories (current and future) as they rely on different HW devices with independent MMIO access. > Said otherwise both the config file (features exposed) and implementation (registers required for these features) are defined per HW device (+ user image for FPGA) hence per PMD version. Would it make sense to have a single application, with having the registers map and their values to apply in a configuration file? It would avoid code duplication between devices and so ease the maintenance. > > There 2 entities have no API between themselves, only indirectly through HW (no shared memory, VF2PF comms, etc..). > New features may have to be added concurrently though, hence splitting repos create room for version mismatch and complicate the ingredients line up. I am not sure that this argument holds, because one could argue in this case that we could place the FPGA bitstream in the PMD directory too to ensure there is no mismatch. > That was part of the pros and cons described earlier and I can totally see arguments both ways, and that's what I have been trying to share openly in this ticket history. Thanks, I appreciate that. > > Basically I see nothing fundamentally new here in the discussion, but it is great to receive input and I am happy to hear further input from tech board or others towards a decision. > This started as an open discussion on this DPDK mailing list capturing explicitly both pros and cons of this approach which are arguable, and in case this is not deemed practical eventually then we can still totally come back internally to the drawing board with other options outside of DPDK. > > Thanks, > Nic > Regards, Maxime