From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E048941EB2; Thu, 16 Mar 2023 18:01:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D174640DF6; Thu, 16 Mar 2023 18:01:22 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2083.outbound.protection.outlook.com [40.107.223.83]) by mails.dpdk.org (Postfix) with ESMTP id E834740DDC for ; Thu, 16 Mar 2023 18:01:21 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dFbdUL3EcSBMNSDSIUZwtAHGxh5yKOW08zIMfW1EF018ptPPxuOMiJJuXBfz2nqmVNv6ukBVxlqYUlH6UxgMbVXW78SnXha8Btzf+6YlyHqqqf6dGSVUv73upY/ZFcDlvIG2zDurhzF8jLpoNwMsBl2qVpixCAklCmCyzzx38WKcOoWpg2OcDv63KADPzYVDhVKnf55psULzbNDWr6amjgIqAeN0PRp5iKVorbqKh2PzETphJPm/IpU8OnbTTijBH90u4hCuGURRKDYEUb3uvvqou3pbjWiau6UcX2P6Xs+TrDWrALByh+rdparRmx5AN4iQa05b3o02O4BmCrh2dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FHQ4kYHLIFRfLivFrIZExkVT9Gkr4hSK2CgF6q1jBsE=; b=P15vhGY6lY77t5wAtqvMPkr1QX/YTuk+RGHxSWUvbG+fpHnhx+bupTWfeurL8Q76miNWv/Id6QHNuh4bTKf/0sWqfmnQZf1Z2S1CI09fzN1fQcV/iDtLS7m1yi5G/PE3OTYkZ2Nr398R13lCKk5k9WK0LgvOSiCPgjC5CVPOlgToZpMMag0EaMCfeziM4U8ZTG79gqvlgCGLFfICr+chFkmmydjRQUfPlpVzfI9LhpvRLfg5+bicDw6j/8gWFw+GIAiV3yM1LETYfidYaqQ5az5rUU9pTgS7ZmFDkbkVAcoBN2ZMLflFgB7XN0Ravxm5fP5OAb7JI83H9M2xLzvlXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FHQ4kYHLIFRfLivFrIZExkVT9Gkr4hSK2CgF6q1jBsE=; b=SQ6txMUQ4k53OwrQhlk2PiPjKz7D6JePFgBXoSDM09pNE78MRQOSzvXMuM1w+Wc1S02SK59IfMClBAXxtKuo8qGgMUFBdL95dHgAWU8jDPP2/nREe2XZYwVkxXDeoUFKU3ublb8K/wg6Nn7TjoSpscdtIHkuVTTnCWndBmwDIbo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB8294.namprd12.prod.outlook.com (2603:10b6:8:f4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Thu, 16 Mar 2023 17:01:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6178.026; Thu, 16 Mar 2023 17:01:20 +0000 Message-ID: Date: Thu, 16 Mar 2023 17:01:13 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 0/2] Fix testpmd interrupt regression Content-Language: en-US To: Stephen Hemminger , Thomas Monjalon Cc: dev@dpdk.org, David Marchand , Pier Damouny References: <20230313171905.67720-1-stephen@networkplumber.org> <20230315173132.4044-1-stephen@networkplumber.org> <20230316083104.3872a538@hermes.local> From: Ferruh Yigit In-Reply-To: <20230316083104.3872a538@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P123CA0025.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:388::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB8294:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f24e595-ad64-4df1-17f0-08db26401043 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZSW4OQlIHK/6Yntc/S52V/QSS0Ib9vrIDBQu5bXOqappzLXexqTqXzN4zrS5WA0TSEpcK3KrhwAljVU8dlmRq4wEovGqODZAVya/VSF6Z/xjgetvU2dMildc75A9fCVLkFdzRDGdIdGqyg5PQDUHr/4BUSzt5nQViHacdh4oj9M4znSGgT8oJPsD1qdb2dDJdhAI384F32hEAVCCwdOIx3mUSGBbEKYN4NFBcvfpE1ju1ooutXqA4KsviUE0KsObJ153n/MNRRy1ySXDFhZSwcryJzLvmbZ2ol0LKPeJBBPx/vCdE8tAnf8PpxKPn0PowV2zWAbPQ12/SWmkl1Zxf38tbdiJvas9E3dYtstoR3qVodFbSKHiyO6wHTz/sOlQ5u/mx4qdl9VxU0/A273f9HHqcnf2QoJT5jBP+bR9V4pkn2NdnWOkqYpdSVBNlyocYqv/B9ife4dx6isbgDOUHnQU3kobPAlZs6W2Mj9uA3t4PlgW2Q8oLY0C6JnkI5+kzb8GJtG9PVjJeTEg4q8JUomPFtEb5oG8sKbchQ5g0xZSVeqmyVcht6yHh+GX8McHbyvlC+vh7rRmGbHxUrZxkpsXg9UlpZwuEl3eUP2flyJhqmtDCvy0q3J5BBUIw8+w9VOlTF2l1DfWFhgFwdDhPbstyTJqqeqOwf5LdzNgXVtXGDnYQKNm3Nmws2nj5sTR/ajFwLQZ4rpcQ2AZhYoIUx3/Pv5yrNzoBoCJWOVrIXM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(136003)(39860400002)(376002)(346002)(366004)(451199018)(36756003)(86362001)(38100700002)(2906002)(41300700001)(8936002)(44832011)(5660300002)(478600001)(31696002)(4326008)(53546011)(83380400001)(316002)(54906003)(6512007)(6506007)(110136005)(2616005)(26005)(186003)(66946007)(66476007)(6486002)(66556008)(8676002)(6666004)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWI4VWhSTmpoWXNGTUl3MDAxV1J3ZDNmVUFITjYvbmg3b2VRL1lxUkFlNFFF?= =?utf-8?B?WUNmMjJKWWZaRWpnWE1SNkltc3FDS0hlS1dXRVphZFZCWWgyTVRaM0ZSWHNQ?= =?utf-8?B?WVZJMytXeU00TS9KYytSZkM4a1BraVJuNXkreUx1dXUxd0F6L1d1eFUrS2Ex?= =?utf-8?B?SjRRNmtUYlo5V0JzV0ZaaEcwTGFLdEczVVArMUlyeWFPT202ejZHRURsUmxu?= =?utf-8?B?L2x4Q2taZE1sbXorTWVuUGF1RlBZa09iVWdHSE13UnZrSmpDOHN6VWl2K2JC?= =?utf-8?B?Smpkek1nRlpGd3ZyL2h3RmdDWWFpYStEaklxa2lQaXk3ZEc5RzRGQWlBN202?= =?utf-8?B?SmsrREp3TCt2eHJBSzRna1NSQ011dDZFdlpuTDJQY1oxMHFWOWZKU2FvYStn?= =?utf-8?B?OWpZY2dkanFxZU9NWU5OSFlyU1ZDMno4Ujh4NGk5R2ZkSjRodE9KMktXOTZn?= =?utf-8?B?Vi9icUlEYUV3ZjhZWHZ2UFVrOFBRSkFGUVRCZHZHcTZXZzdWQVJVSFFFSkVh?= =?utf-8?B?QThocjR0Y1ZqSXBHdFc5eTRxcXY3d29UakkrTmtjbk83b0FVd0trdmpWKy9Y?= =?utf-8?B?SDQyQklGSGI1bVI0d2ZWdGFYNEJ1dmFydzIrUndEcTVnUTFSeGxBd3hZbWhw?= =?utf-8?B?YjJiUXI4bENkKzhIODBja1lqTGRtZTdtN21hOCtadExJTjlkZkNtZlZrTVd6?= =?utf-8?B?QjBPNlpTK3RYVlo1TXY1THIrMHlVcGNWZlpiWmJQR255OU5jWkY5N2R2MGZU?= =?utf-8?B?Z1N4REFYVVRpd09ZcXFCNGtCVjJlMnFvVElqRWdIVll4dEQ3Uk8vaGViWVdi?= =?utf-8?B?QWVYUVgrbUR6dWc3Q2pmNU9PN1N2b2tCSVV0dThFWlZBOVE3SHJ6bk4wdHU2?= =?utf-8?B?NDNOQ2hNUlVqZzJNdGpad1c5UzhDMWZ0SkZzOGpKOXNxSEJybng3S3BDQW9m?= =?utf-8?B?T25mbEJqOWtmQmpIcUlLNnhyK2hHR0J6YS91UTRPdFBmcHFYVnFHS0ZmRVVx?= =?utf-8?B?WmtOckZ3cFhLZWQ1RGRWMGJKN0xmc2hVMDBMS05sV3lUZHpiMHYrK0VON2JV?= =?utf-8?B?bUNOQUU2UWZyeFd6bDdXTEZKWFhaZmZDbk5CckRTQjN5REtzdzFVeWt0NjRs?= =?utf-8?B?V3Vxa0ZsZXh2U2kzVm0rRmIxZE5xcGJtWHM1UEUxZFZYUkthaW1YNjFKakU4?= =?utf-8?B?aHFLZE5LVFY0SmxuT290MlBDTUFqWjBPaE44OC90dlRIT25FVVpscSswaFNl?= =?utf-8?B?TGgvMGhXemM0RDZRNGxTb3VhRWFCcERjMlR5dlU0MDRFczFJQ2VqVDAySUpG?= =?utf-8?B?VGhHdUw0SUZuRmZBdjJtTFNXSDNqNFlIbTlEdVFxT2FUeWtBQ1d0M2xXbUhi?= =?utf-8?B?UkRxbjZjc2pISTkvUTRYN1Z1dnBJY21TcDZ4MFJ0bFNwQWFHMDArSE9obWpW?= =?utf-8?B?S3ZzY21SdVpmdDhrTnhRK2FlMmY2dnFYU2x6dUNDeWVPdEF1RkNMaDYvZUpX?= =?utf-8?B?YW1KeUpmQ1d4cC80VWVsRHVESUtvZjczbk0vRzBkaDFiNElOeVEzUnJtNm9H?= =?utf-8?B?bTFkZ0NaSnlDcEJybjFpTmEza3ZvRGNFQzMyWWNzNXFZd0ZZbUFHVnFVM1BV?= =?utf-8?B?WElkQ1laN2lVa3djWFNUb2wwUlZNL0NHcUltMmlqZDJVa2VDeldCTHdCaktX?= =?utf-8?B?RlVlSEQ3a1RLeGZlaXd0SzNTb3dEWXNsa2pNV3RXWUc5NFV4by9UanAxR0dW?= =?utf-8?B?eldyRDNxZHAxV3JqZTlFRGJpSi9NcXk2WklqM1RLa0Q2UWZDalIvOHAzZnU1?= =?utf-8?B?UGpLVE1QSitkcCtQOVNTSWMrRzNoeCtZb1NhbFhMYWFLSGVKblBocWJONXVn?= =?utf-8?B?aGJHVzNUNWYrR0wrb0JtVHlPTk9CVk9yaGNTWkVsVVRLSHBmL0l4Vi9IZlVm?= =?utf-8?B?M3ltdWlROC9aaFArTXlydHNESzY2bVB0WGo1UGNqcW0xa2xBSVV3NGJIN2R6?= =?utf-8?B?OTV4c1JIVXVXaUl3QXBnRFZIcjlyNU5jelJ5bkhNYlZpcW9Wd0RFc3A0QnhL?= =?utf-8?B?Y0JPWlk3UVdVeU43WmVSRzNtSGphcCtNRk8zQUpsR0VKWFUveEVXNjhnR3g4?= =?utf-8?Q?gHt1dwp477PRPG9SRAi6Xi7vK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f24e595-ad64-4df1-17f0-08db26401043 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 17:01:19.8789 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EGcuNRzkEPLC+naT9aqzvIu0MD/XgM8CCosCRuTvreXOA7zBusbLC8sSXbA3DN9I X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8294 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/16/2023 3:31 PM, Stephen Hemminger wrote: > On Thu, 16 Mar 2023 12:20:41 +0000 > Ferruh Yigit wrote: > >> On 3/15/2023 5:31 PM, Stephen Hemminger wrote: >>> Resolve issues from using control-C in testpmd. >>> Fixes regression from recent change to use cmdline_poll(). >>> >>> v4 - drop sig_atomic_t. Not required requires changes on >>> some platforms. >>> >>> Stephen Hemminger (2): >>> testpmd: go back to using cmdline_interact >>> testpmd: enable interrupt in interactive mode >>> >>> app/test-pmd/cmdline.c | 27 ++++++++++++++------------- >>> app/test-pmd/testpmd.c | 11 +++++++++++ >>> lib/cmdline/cmdline.h | 10 ++++++++++ >>> lib/cmdline/cmdline_os_unix.c | 8 +++++++- >>> lib/cmdline/cmdline_os_windows.c | 18 ++++++++++++++++-- >>> lib/cmdline/cmdline_private.h | 2 +- >>> lib/cmdline/version.map | 3 +++ >>> 7 files changed, 62 insertions(+), 17 deletions(-) >>> >> >> This solution is adding new cmdline API for -rc3 and there are some >> testpmd changes, >> can it be possible to have a simple workaround specific to window for >> this release and get this set for next release? > > > Not really. cmdline_poll() is broken in several ways. > Don't want to fix it or use it. What about to revert the original fix [^1] in this release and get a new version of it at early next release? @Thomas, what do you think? I think better to decide before -rc3. [^1] Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal")