From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 78A25374E
 for <dev@dpdk.org>; Tue, 23 May 2017 15:21:05 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 23 May 2017 06:21:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,382,1491289200"; d="scan'208";a="90657087"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81])
 ([10.237.220.81])
 by orsmga004.jf.intel.com with ESMTP; 23 May 2017 06:21:03 -0700
To: Qi Zhang <qi.z.zhang@intel.com>, wenzhuo.lu@intel.com,
 helin.zhang@intel.com
Cc: dev@dpdk.org
References: <1495511950-12130-1-git-send-email-qi.z.zhang@intel.com>
 <1495511950-12130-3-git-send-email-qi.z.zhang@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <aa4247fe-ac28-6d9b-7686-a3d96dbfe278@intel.com>
Date: Tue, 23 May 2017 14:21:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <1495511950-12130-3-git-send-email-qi.z.zhang@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 3/3] net/ixgbe: enable flex bytes for generic
 flow API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 23 May 2017 13:21:06 -0000

On 5/23/2017 4:59 AM, Qi Zhang wrote:
> Add fdir flex byte support for rte_flow APIs.
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

Hi Qi,

There are a few checkpatch errors for this patch also please find a few
minor syntax issues below.

<...>

> +int
> +ixgbe_fdir_set_flexbytes_offset(struct rte_eth_dev *dev,
> +				uint16_t offset)
> +{
> +	uint32_t fdirctrl;
> +	int i;
> +	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);

We don't have "reverse christmas tree declarations", right J

<...>

> +
> +		/*Not supported last point for range*/

Spaces around comment.

<...>

> +		/**
> +		 * mask should not be null
> +		 */

Can have single line comment.