From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 249AFA04B2; Wed, 26 Aug 2020 12:12:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A594B4F9C; Wed, 26 Aug 2020 12:12:17 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 5F3034C89; Wed, 26 Aug 2020 12:12:16 +0200 (CEST) IronPort-SDR: rwa1UH62/8wGPELB7i3gI7Q2ogefEHqUTM/zGlJidrXZMo1znRvSLMdyuZAgNrj2MqdtoIdDbQ 6TmzS3/AwD5A== X-IronPort-AV: E=McAfee;i="6000,8403,9724"; a="136328103" X-IronPort-AV: E=Sophos;i="5.76,355,1592895600"; d="scan'208";a="136328103" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 03:12:15 -0700 IronPort-SDR: 4szMbA+7j1oMBF0b6KuhoRlmuQoad0T5QulsOC1OyHIzJHZCGxjo1dXRFborm5umuvEEAD5jxM t9oNSKX6H8Jw== X-IronPort-AV: E=Sophos;i="5.76,355,1592895600"; d="scan'208";a="474717074" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.235.135]) ([10.213.235.135]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 03:12:14 -0700 To: wangyunjian , dev@dpdk.org Cc: rory.sexton@intel.com, jerry.lilijun@huawei.com, xudingke@huawei.com, stable@dpdk.org References: From: David Hunt Message-ID: Date: Wed, 26 Aug 2020 11:12:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] examples/vm_power: fix resource leak on error path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi wangyunjian, On 19/8/2020 1:54 PM, wangyunjian wrote: > From: Yunjian Wang > > This patch fixes the resource leaks reported by coverity. > > Coverity issue: 337674 > Fixes: 95f648ff9eed ("examples/vm_power: make branch ratio threshold per core") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang > --- > examples/vm_power_manager/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c > index 3a8958058..6422d7b99 100644 > --- a/examples/vm_power_manager/main.c > +++ b/examples/vm_power_manager/main.c > @@ -206,6 +206,7 @@ parse_args(int argc, char **argv) > } > if (branch_ratio <= 0.0 || branch_ratio > 100.0) { > printf("invalid branch ratio specified\n"); > + free(oob_enable); > return -1; > } > for (i = 0; i < ci->core_count; i++) { Acked-by: David Hunt