From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C04C6A0C3F; Mon, 28 Jun 2021 12:55:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BDB340692; Mon, 28 Jun 2021 12:55:06 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 06CC44068A; Mon, 28 Jun 2021 12:55:04 +0200 (CEST) Received: from [192.168.1.71] (unknown [188.170.72.30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id F26D97F4E2; Mon, 28 Jun 2021 13:55:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru F26D97F4E2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1624877704; bh=9pWEHU7pEHiscY5jcJa6s1+XLLe+a1Pzd1ASPaar9O4=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=i5IGeeNhsMxkZwx5OvSju1bStpyItRWlTYOmgVvWq8ITY9F4U4iQJ3AYXlQKPfBqs xLfhUgkV7E2DdBWsdHtZ8hcmFqNx/eofW1O4BFek24TxQ8JbshBQI3fJTqEx33buaj DNGgm5Ts/96CY0BwcsgFhG1bPSGBfEPdG2T+Q8rw= To: Jie Zhou , dev@dpdk.org Cc: dmitry.kozliuk@gmail.com, xiaoyun.li@intel.com, roretzla@microsoft.com, talshn@nvidia.com, pallavi.kadam@intel.com, thomas@monjalon.net, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, stable@dpdk.org References: <1620241931-28435-1-git-send-email-jizh@linux.microsoft.com> <1624487698-31136-1-git-send-email-jizh@linux.microsoft.com> <1624487698-31136-7-git-send-email-jizh@linux.microsoft.com> From: Andrew Rybchenko Message-ID: Date: Mon, 28 Jun 2021 13:55:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1624487698-31136-7-git-send-email-jizh@linux.microsoft.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v14 6/9] app/testpmd: fix parse_fec_mode return type name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/24/21 1:34 AM, Jie Zhou wrote: > Replace parse_fec_mode misleading return type name mode with fec_capa > > Fixes: b19da32e3151 ("app/testpmd: add FEC command") > Cc: stable@dpdk.org > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou [snip] > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h > index 283b5e3680..9ae4d90dd1 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -885,7 +885,7 @@ void show_tx_pkt_segments(void); > void set_tx_pkt_times(unsigned int *tx_times); > void show_tx_pkt_times(void); > void set_tx_pkt_split(const char *name); > -int parse_fec_mode(const char *name, enum rte_eth_fec_mode *mode); > +int parse_fec_mode(const char *name, uint32_t *fec_capa); I guess that the real reason behind is to fix implicit conversion of enum pointer to/from uint32_t pointer. I guess the problem is different signness of enum on Windows compiler. If so, please, put real motivation of the changeset in summary. It should be human-readable (and do not contain function name). Explain details in the description. Yes, I agree that mode is misleading here and should be mentioned in the description, but I guess it is not the root cause. May be I'm wrong.