From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49136433E4; Mon, 27 Nov 2023 13:19:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31B0040273; Mon, 27 Nov 2023 13:19:56 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2052.outbound.protection.outlook.com [40.107.244.52]) by mails.dpdk.org (Postfix) with ESMTP id D36B44014F for ; Mon, 27 Nov 2023 13:19:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iRegsbVWzAVijGmU+XJFtnfa1AkB89Vd3bDyin2xamXG8vRV0J29000l+B40A36ehmr1J+E+yZLFJrAw++WeNJ/bD1udGJxG9UtPWDK4h1mS7NGcyxlzH8/V1My3vP4rCLExPjp9Xpd0vbXlbwWvTKvcfei01yhq64zIigjO5d+OS5AlrVKpJImevQwLOUBuwXSgzrPwZVhYGrOCtT1KDD52yrCgtvjTAlXGxcZgIK8XqzZA4s3DC3tUCTYqCsIccsg6i7hLff+k/W+Q6Li6Tc1QeKBeUZaTm1M1V4e2oXXui9p4grNaSN8zJLHOwH6lm/gE63p1o0SwN7vL9vq5yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q+FnTSXFTQCWB1za5H7qxMENdQLAyaNz7jyJAuLeuuE=; b=XkyAbofWYk0yBVEMXKIKwz+zClWWNleuoEhcA40bVvLO9uAszQ0vaTFPsNst1Q6oh1Th/kcIh6hC1yLfYmU9BwXShR/3igLbicoy78Nxi2npOiP8PJ4LI7ZI4eVPxDgHX6lAkl2WwQHLTAKCCKFM0G5tLbEjysbngNIyo+qd8VYjYP/j2DtR0simS5TqK3P+Gj+0fT7KCz+oNOL9h2mShj9EeJmVzEU4jqwAEAi2PCqJaaoOG17mCX+usqi43DWb1rZmF7m2jEIf2/65iaonIRxB1zUC79YdgJLnvjw1EUkAJ8H1KXLms84dLe1DAIioz6h1ISNQZ6nUN1AJG9Aj5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q+FnTSXFTQCWB1za5H7qxMENdQLAyaNz7jyJAuLeuuE=; b=GO+zHDZCoMX00IXMS3/kr66emWj3muIJ/Zx9eJiTnxud/QPcyChonyMMYSwiIi55eX7E7vo6z6N60h2m/EeMTy/brfTBeLzD8f5bj3L4OZ5RrHQtXyYhLq1E5aDTnPvk9RntuduKb7DOHpu1FSTdwk8AeeeCOxmNize8aHK1Kmk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB8402.namprd12.prod.outlook.com (2603:10b6:610:132::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.28; Mon, 27 Nov 2023 12:19:50 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 12:19:50 +0000 Message-ID: Date: Mon, 27 Nov 2023 12:19:43 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] doc: add RSS hash algorithm feature Content-Language: en-US To: Huisong Li , dev@dpdk.org, thomas@monjalon.net, Chengwen Feng , Jie Hai , Dongdong Liu Cc: liuyonglong@huawei.com References: <20231123135916.33315-1-lihuisong@huawei.com> <20231125014745.61348-1-lihuisong@huawei.com> <20231125014745.61348-2-lihuisong@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231125014745.61348-2-lihuisong@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0020.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::21) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB8402:EE_ X-MS-Office365-Filtering-Correlation-Id: b9ebbf56-a157-45d3-bf3c-08dbef432729 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hJwCdnffFag+0IHFXRiDIlLG93SnxBxJX+FqDpSKMvM16YV/KkkC3Y6tY8FixzKLNLBv9dXblTMHt4VgpIfMcPkuMzZbANNebwbRlN9W5iv1t6p4FkVI9VkeX7mylHuOJzNQF0oUdTetOkwjZ8hCe87LhrAE6WYp8LYML/IUN06Ygk1SC/+32vugc2TMaotmgAD+uqR9pfBF6zTdzjVjzjy+hZKT34qGGzAqnO8uKqHKbQ09q2A6/JEmHSTRa9ZYo/Dr+j7Srk77dsr3BxoCChxr7qruZKbc8X2jZiXaKFkKjnBrEWsS3qFXgVFFqyYTjckRZaxytsruW6CIoGG8BK5MoVmPp0WrW54ddX8v4bEkpzqH1/sQUiJYAvYXdZKXc8r9k/AYAo1G9pxT++nR5CBwkypDLaV+KI9w5yz/Pbr+zNjm3WMtJCXpljqcH2BQBZXHcFURJ2aT8FZvCJW/G8g7R1pVxz+SyWcZi+Q/FOUdZMB7VKRe1leNGdKji6Y+/Wc3+1FRXAfZ3ZiQHfiP5jSAsRhn2S4pMcx+Dyo3eE/1oyjcx6t39JxGLcy04M2y/aX2ow8Q6bRZA+NnRmlaE0IonrUwiWeO3ojih5zMDimMEZfsbWLvmdTu9bFBbZLKz4ms4+QufL5zipd/efij9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(376002)(39860400002)(366004)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(6666004)(8936002)(4326008)(8676002)(6512007)(31696002)(53546011)(6506007)(110136005)(66476007)(66556008)(66946007)(316002)(6486002)(478600001)(2906002)(36756003)(38100700002)(41300700001)(31686004)(86362001)(26005)(44832011)(2616005)(83380400001)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0l6NHA1YmJIbEk2LzBqaUtkTXM5aGR2dndrbHZYdUJ6SjFrRXB1elcxZGhx?= =?utf-8?B?c21lZFZ4a1hXQkhXQktQaDlRbXVrUU1HdGlxdHhYSlRybTA3V3hyaFkvSEQ2?= =?utf-8?B?S3RPQTRTTGdjelpqSDk3Ykp1TE52dUU2NTdoNlRaM0hoOG12ZTNuVlBndjBG?= =?utf-8?B?ekgvYjZGU25CdHlVckV1RlliRHEzOEVNVTFqNHZlRDdnQnY2U3pLUTZpL1dr?= =?utf-8?B?SmRJaWE2RW03VC9OOW9CY0VUN3M5RFB6VFg2bkxOL0hLeDFGcTR1NEszRjNt?= =?utf-8?B?RkZ2MzZtVzlwM1l5ZmZhRzdUc3AxQngwdEVWTm9qSUhRaUgxM1RtT1pHcW1v?= =?utf-8?B?Z3Yydjl1dmxFSzA2cnFDejlmbWp2N0dhNTBwc0tRSHJpWlNIU1l6dUtCTVNz?= =?utf-8?B?eS9vS2pjN0F1cTdCSjUvaWxLQWZJWUNLOVJyNmovQnFtcTA1bk1QYVBqSklj?= =?utf-8?B?R1pESWlLM0J4cVJZL0pGdVZST2pQR2xmRUdRTFVzNGZwd0VKMnBHWHhyQUcz?= =?utf-8?B?MjZqM0JYMXk4TGlGa1N4R0N3ZytsRmNMdTJFUFJLeUdsNjNOd1RXSTRlZ3ZY?= =?utf-8?B?VHg1RTdkVDhuelNTNFVpKzZ1LzBBZHFjS0F2QzA5RHUyQ3AxVWhONWlQbUp2?= =?utf-8?B?RzVpMFR6azdESnkyL0VER0JJcXpXdlNUcU1hZG0zSkc0VVA2aW03Qk43WGpX?= =?utf-8?B?akIyeVZUWEJJQTB1RUVpQ2VOc2cwMGlnODQ3UGlJblZ4eDNQcXE4YmtGLzZK?= =?utf-8?B?RHpncG5oZ2hrNTN0OC9TbTFEOG9QV1pTZ2ZWVWI3akp4V05GbHpxVFVsR1ZI?= =?utf-8?B?ak0wQVJFS0lTcmk0ZWFNWmZJaVhVbVRObnZyazRxZnRZSzBQQWY5cm5EY0hC?= =?utf-8?B?dUpoNU1qdkxOWFdzdmFkTmJUdjZzQkJzUkRaeVlORFJwMVpxcGFnUWFRR3Nz?= =?utf-8?B?NjFleEpJTzZrdFZjclBVbkttTlpsczlERnU1aHNlSUZsYzl6eU5YbWpXUnFT?= =?utf-8?B?UVljQWhKZkliQ2ZSMXE3QStqOHp3bWZ4UW1aMWRObEx2YnVLM1MvaFEzUXpj?= =?utf-8?B?aU1oanhtV01IRGpXa2ZKbUE0azdyV1NZTjhBK3NtNnlkSDJmNFIrUjFTVk9F?= =?utf-8?B?QXBaQjdXdjU2aU9HQmh3THF3TVlFdDdGdkJtUjkrMGNmUmFhbVFOMm5WRzB5?= =?utf-8?B?VHYyVDZpS1ZUT2t6RVBpeERUVmZpVU55b0J5SGhiZ1B5b1JrcUhieGovVm9Z?= =?utf-8?B?SkdXc0NzMFh0eGt6WHJlVTc0c0dJY2xqazl0WllneFRKTUpzbWQ0VVF5SnJT?= =?utf-8?B?WmNJSkRqN1lSM3k0RWJYeWViUnpFZEZBZWU2bnE3ck8wMzd6YkdBNEZVSWVU?= =?utf-8?B?R0g1Y3hhWW0xdGxlenpiRWtFNWhBQi9hUTYzdEYyNEx0a3VZVDZ2blpFQ25n?= =?utf-8?B?bjZKQUU2T21JcWZERlI5UUQwREtnN2hzSnpDNSszWkcxaFdHWjNkS1E0UUJT?= =?utf-8?B?T2NsTzF1VjQ2bkZXeEljbXZEN091dVRac1RUQ2xIdUdSaWN4SlAxSmkrcHpF?= =?utf-8?B?TzBIRTQvcE1IbFIvUEltY0w3OURwaEwyeUJSQXdxTFJmTGF6aVVQVjZXcWlS?= =?utf-8?B?SWhFLzQ1YXp5Z0hNWmt4MEoxYmM0YzJmRzQ4RXVTdEE4S2h1U1htMEpyQ2xF?= =?utf-8?B?N0tDSnl0TXZLNlNKL1RBS244bTF2ajB5a3VVblg5RTdxRTZ4YTFXVFRSV2hI?= =?utf-8?B?UkhURHlEODB3ODJSSC9xNnk5NzZ5ek9FWms1dW9sazA0NG5mTjZheE9FRnhL?= =?utf-8?B?L0pwcGpGVlRneGRQbk1sYVo1d2R0Qjg0UU1MUUppeVk5Q2NRSE5OVFBiL2xq?= =?utf-8?B?dFlBUUc3eVEwQkFVemp5VExmazBFdFRVK254K3ErbXVwNk9nR0FJc29td3lM?= =?utf-8?B?TVR6V0NLQ3hKYlk2UzVQS1hLMm5WTm92YVhYdjZqR2RycnNqRjNXOTUrejVI?= =?utf-8?B?S3NVTGQ5MzlrZWxxdHlCN3dlUmFlUWtoK2ZhN2c2NHBoRDBqYm9BMlJsS0lk?= =?utf-8?B?OHlIUHowR051YU16YzRMTXZTU2hhUEVIdThmRGdQNUlRdFJwT0FHQ2Jsai9v?= =?utf-8?Q?KEI4=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9ebbf56-a157-45d3-bf3c-08dbef432729 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 12:19:50.4509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hTS2+853FTgKW97QIsOSbVRgDuHkM9LRJ0ypuz2jt9qtnonrmoowjxehd7wN0wfN X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8402 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/25/2023 1:47 AM, Huisong Li wrote: > Add hash algorithm feature introduced by 23.11 and fix some RSS features > description. > > Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm") > > Signed-off-by: Huisong Li > Acked-by: Chengwen Feng > --- > doc/guides/nics/features.rst | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index 1a1dc16c1e..0d38c5c525 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -277,10 +277,12 @@ RSS hash > Supports RSS hashing on RX. > > * **[uses] user config**: ``dev_conf.rxmode.mq_mode`` = ``RTE_ETH_MQ_RX_RSS_FLAG``. > -* **[uses] user config**: ``dev_conf.rx_adv_conf.rss_conf``. > +* **[uses] user config**: ``rss_conf.rss_hf``. > Feature title is "RSS hash", it can be two things, 1. "Receive Side Scaling" support 2. Provide RSS hash to application When this document first prepared RSS hash value was always provided to the application when RSS enabled. So intention with this feature was "Receive Side Scaling" support, hence 'RTE_ETH_MQ_RX_RSS_FLAG' added. Later providing RSS has to the application separated as optimization, 'RTE_ETH_RX_OFFLOAD_RSS_HASH' & 'RTE_MBUF_F_RX_RSS_HASH' added for this support. As the intention of this feature is "Receive Side Scaling" support, we shouldn't reduce configuration struct to 'rss_conf.rss_hf'. Instead perhaps can expand to: 'rte_eth_conf.rx_adv_conf.rss_conf', 'rte_eth_rss_conf' > * **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. > * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``. > * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``, ``mbuf.rss``. > +* **[related] API**: ``rte_eth_dev_configure``, ``rte_eth_dev_rss_hash_update`` > + ``rte_eth_dev_rss_hash_conf_get()``. > ack > > .. _nic_features_inner_rss: > @@ -288,7 +290,7 @@ Supports RSS hashing on RX. > Inner RSS > --------- > > -Supports RX RSS hashing on Inner headers. > +Supports RX RSS hashing on Inner headers by rte_flow API. > This should be clarified with details below, not sure if it required to limit description to rte_flow. And I guess similar confusion exist with the providing hash to user. Need to check if rte_flow implementation puts hash to mbuf along with doing the RSS, or if it checks 'RTE_ETH_RX_OFFLOAD_RSS_HASH' offload, and update below items accordingly. > * **[uses] rte_flow_action_rss**: ``level``. > * **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. > @@ -303,9 +305,25 @@ RSS key update > Supports configuration of Receive Side Scaling (RSS) hash computation. Updating > Receive Side Scaling (RSS) hash key. > > -* **[implements] eth_dev_ops**: ``rss_hash_update``, ``rss_hash_conf_get``. > +* **[implements] eth_dev_ops**: ``dev_configure``, ``rss_hash_update``, ``rss_hash_conf_get``. > +* **[uses] user config**: ``rss_conf.rss_key``, ``rss_conf.rss_key_len`` > * **[provides] rte_eth_dev_info**: ``hash_key_size``. > -* **[related] API**: ``rte_eth_dev_rss_hash_update()``, > +* **[related] API**: ``rte_eth_dev_configure``, ``rte_eth_dev_rss_hash_update()``, > + ``rte_eth_dev_rss_hash_conf_get()``. > + ack There is an inconsistency in the documentation but I think it is good to use '()' when documenting API, like: 'rte_eth_dev_configure()' > + > +.. _nic_features_rss_hash_algo_update: > + > +RSS hash algorithm update > +------------------------- > + > +Supports configuration of Receive Side Scaling (RSS) hash algorithm. Updating > +RSS hash algorithm. > + > +* **[implements] eth_dev_ops**: ``dev_configure``, ``rss_hash_update``, ``rss_hash_conf_get``. > +* **[uses] user config**: ``rss_conf.algorithm`` > +* **[provides] rte_eth_dev_info**: ``rss_algo_capa``. > +* **[related] API**: ``rte_eth_dev_configure``, ``rte_eth_dev_rss_hash_update()``, > ``rte_eth_dev_rss_hash_conf_get()``. > > This document describes features listed in the 'default.ini', so we shouldn't have above. And I don't think RSS hash algorithm update is a big enough feature to list in the feature list, perhaps it can be embedded in the RSS support block, what do you think?