From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A14C42C04; Thu, 1 Jun 2023 16:36:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CA42427F2; Thu, 1 Jun 2023 16:36:48 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2055.outbound.protection.outlook.com [40.107.101.55]) by mails.dpdk.org (Postfix) with ESMTP id 30E2D40DDC for ; Thu, 1 Jun 2023 16:36:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Utn742oCYMnNLlVIel4GLfivi1yrHj+cl+MmYBhCBT8zywzrJYCt2weUO1UD8I07mHcAckvNTgSDqchX32kK4V6eRVJ3RgFABLrpGAW4PvyzJDD5wes137j2rx3tfPVC2cQ6tW2pbhH7zlNOirv9WRcibcxHEND5etZQWM6NSOixoZmfnjY5q4rk1Pfe4ZariMEd9pzgzqyy1tDPaJOvxGnOn8RU2hsk2e1h4KFmTHrVbt5OX0OBumlc5AVP4ToRXqTIqOzwecc3AMS3PoMfKQ6aa82ME7iUcxHRizGE+nfiUS1lTJW/85TdgMiCHHp1D9u0+3nV8lkibiqpXKz+JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0DlL5TvC0+h945kgU7TDjTDS0fIy+vmgNi3NE01dD2Y=; b=OfAikHy+Z7WfbTEyHL58f9atwx7eiVRZn2bRhwG0VmEtL5mN1mVu3KdH3PUa4XyDWe3AIUbNY5+8zeb0sMXbLaIaM7MqiGy/60FmM+1ouU8VfubzFbXPuFgSXdnrL+JsUooJD5+FMiIhT5NAPD7LhIPNETWdo9qe870WigCj1S5B3in2hh6e7f8L1RWOBperehJzWzCIFirNMupPYOSv7S3O5OK1/hS+kN298CzmZu01XEeT39/KCtXv4K4nr0x0bDC+eB5cTuZkGNpWjyGiE+GZu3emRZVj+aL3RWkbIWmFNz1KC/MWZ2GpiWbSoEESMj5cf0xk/+RR1fSLo6gI5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0DlL5TvC0+h945kgU7TDjTDS0fIy+vmgNi3NE01dD2Y=; b=CHnDIQekCimWDIptFX+2eP9lvJmvS4sv0MRNCJRS51AWetSq+x23njamlOsSstWioT25uhb6XzfSLVMG+O3MNFthTuNhvWroEKat/rM7QFJVbOt9DHA79lTDNj8+t4xGAlfE2s43nONRVjrlumA9n71gENOsEPtPhxGSDrs/RGY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY5PR12MB6057.namprd12.prod.outlook.com (2603:10b6:930:2e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.24; Thu, 1 Jun 2023 14:36:45 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6433.022; Thu, 1 Jun 2023 14:36:44 +0000 Message-ID: Date: Thu, 1 Jun 2023 15:36:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 00/10] support telemetry query ethdev info Content-Language: en-US To: Jie Hai Cc: dev@dpdk.org, liudongdong3@huawei.com References: <20230530090510.56812-1-haijie1@huawei.com> From: Ferruh Yigit In-Reply-To: <20230530090510.56812-1-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0250.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY5PR12MB6057:EE_ X-MS-Office365-Filtering-Correlation-Id: d9d17b7b-0e5a-468b-70c9-08db62ad9f41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K40YmwGY0eHGhD/HKqf8gxO0oxK7CMmTKBCmXofdPbrl0fZu1OTig4v0/9oAlbv8cWV9kgm5ZBSOTyQPpBVCiTDGtmKR1JqD04osbY7FMcRS8QNSLqceDpv6n9VuQMsb/LzZUWF8wF6jqj9dKd7cU+0pVKN3zr6zjvz4oe45nGZUDEJH2wg0XMmPZoeGCi9kSPaxPyFZ6ZTaSrw2jwczQLEAWkbCu/GFPlJQFYTyHuhWzuHbEggIvdwiOgHsJm+wkOqnFjMFYoeN93IZf9KbUqQw/i7cgnbZQAPe/43ADWBi+gkCB99Ar890tiyQsc8REKVAIci0wW3FGzyA5LLNj7gnDEyw7qNLdV0w414XOX3+qM4fZZ/tF7pPInYQI/xeIvqs6s2I74wcGYXueICkS0qcdlQ2j6xqAhXD530wcbUpD1aoWFUw1Hw2R5pV14pZkJFkZ+9EkNlwvBw2KwFTe7mo6+UH8WzlB0rsU2A6SjkLuKFbvCLDf4KmZhSaAYEIfgzDfDuMdpaeup9zxz5haA0CTFxF1Z32auAtjYd8938VovRWH7uWtlaoIBMMeSd9yXX+EpydoAafXeHigLQP8HA/sUfGBIwMj4qamm1YX/ZQ9f+XB8SHjX2nHsA9O5YM7id9ZeM2SXwLKjznOqj+4g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(451199021)(6486002)(478600001)(6666004)(186003)(53546011)(36756003)(86362001)(2616005)(38100700002)(31696002)(6512007)(26005)(6506007)(316002)(41300700001)(4326008)(6916009)(31686004)(66946007)(66556008)(66476007)(44832011)(8676002)(5660300002)(2906002)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFpBaDdIdzNONTUya3RjeHpsaVdKUFFUSFZ5Tis5cmNHZWNUd2x6d3VqUzc0?= =?utf-8?B?Q0MrNkN3NmN5QjBXWkFwR3lkOWo1WEUvR3hHSEJPTDdDOFV0Zm9nMHc3RFFx?= =?utf-8?B?YTF5MEFVSWpGSlJmakZMLzNMeldjOEFxWE81Y003cFdubnBrZnhPUmR2eHBG?= =?utf-8?B?T1ZFOEhSOG52WDdEOEZmZDZ3aUxxanA3b2hvV1lBclRYM09acUtLUUliejJn?= =?utf-8?B?dnowNElhUFVuVEN1bUIybGxXQ3pSOGFoVHlrT3RPQ3doNzhBQWdFWTJwYUJz?= =?utf-8?B?WVAyc3RBaGI0QUFQR2kzV1FqM0FoS2ppS1BZVlRrbVZab3J4cWMyZkJRNVpG?= =?utf-8?B?S09ZRGIweUhEb2xUMHV3bzcyQnRRSVMrWlVwTEJaOUg2OHhheXZ6ZndCOGRZ?= =?utf-8?B?V1VDZCtuRGxSTEJ1VU9zbXFMVXRMdDNpVjljUUtWMndEZ2NUeXZza0QzY1BC?= =?utf-8?B?M1FxM1JLZGhMWk5LQURYdExVTURrRjZEbjlOZG41NnJ1dk1uVmxxOGoyTEdH?= =?utf-8?B?cjNkVmVNczNpZG5oKzJnWVpWMXZHa0tGaEt5NmlQRGhQZFFoNUdiV2dhemtE?= =?utf-8?B?Ymh4ZWJwVGhhQmlha1NVYmtaeTNpQWNBSnZXRmRxeTU5djJDZFRhWDFYNWZu?= =?utf-8?B?MkpZdHNONUt4T3dTQmpsRW1mdmVRZ3VHcCtUcVJmVTYvckx6Q1Y3RDhtQk5U?= =?utf-8?B?NWJObERDWVFzZGRSV1Ezc011NEh1MGIxS2ZSNWF0eVpsNE9ZTWRSd2JlUFo5?= =?utf-8?B?alBuYk01aWJEU2dsZUVSZ0xuQlBjQ0lINlZYK2ppYUJnN29zUHN3WFpvN2dj?= =?utf-8?B?bDMzY1dIS0taMld4R2ozdE1jRUJNMFZ6dndRWFpkOTFVckEwbDl6bzhCdk5X?= =?utf-8?B?ald5TlByRjFZbFZQZENzZzlXaThwQWVrcWJBMTk5UW8yR0pWVU5taCsweFdF?= =?utf-8?B?VVV3aEw1OUs5YWh1WU5XVHFJSkdjWUE1bHBSekhxNCtmUmZYUWwxVGc4Tlo1?= =?utf-8?B?ZGVJMVpXeTloSGx0djBGcE5iUUZKcFJVTzQrVklEa2JGck5BTHdxRk5mZmtv?= =?utf-8?B?NnlQQkV0dVNQdWp6aC84bEVGWGUrdFl4MXdrUEhkQXd3RXl2R2duaWVsMzhN?= =?utf-8?B?d0tuQVNkdXJ3S3FHS2JnckF0RWY2YmRmeGM2Y1ErT2Qwcmh5WDhPODBQQWRj?= =?utf-8?B?cmh3V09YRlBMYTF1eWcwLzFmZWRYaEIvSS9ZL0JlZW10OGpJNHNhOEpRSGtH?= =?utf-8?B?QlpMdEw4VEQvaCtzV3g2SHZKY2Q1UDU4aEJEK0JBS3ZOYkxhdzFQS25xSlA5?= =?utf-8?B?SzZERno4QVBURmdEQVEyY01qbTNGTG9PSFFlU05Ub2U1Z0VxeGtmQ2VGUUtQ?= =?utf-8?B?TWxPeDk5dmlhc0lYOFYrd0ZNdkhSVVRwdktvbUFhNXNsQVZSWkpnQ0tVeTZR?= =?utf-8?B?SlZ4YVpmT09FK2c0MjVvbTk1dDVORUg1RnRjRk43SmN3Y211MzNmbWdQSUgy?= =?utf-8?B?c0RrcGFIZG91QUdja3VvQkYzM0JkRi8rSERuTmx5NU41eGlvcUlVaEtwaXpx?= =?utf-8?B?YUt0R0Fsd1gvK3RwbW41TVZqNFpPWmZjbXUzSHZteENqMUVZVkEzUTVkcXBW?= =?utf-8?B?Y1JRdjNKV1dKUURyODlZckdmQVE4RHZENitQYXkvUjBjaGM0SVdvQTJJdDZ3?= =?utf-8?B?dldLWFZrWk9YUk5FQWxONGRHdktkNHZrcHZ6endzQVYzbmlMMVZKQjBnZ2pt?= =?utf-8?B?OXdPTituaUNqL1l1dlZOSTFaODhOQTdkdTR6ZmZ6dXpqYy9kSlZMWnFoVmRz?= =?utf-8?B?bTlqMytNL3hjQTJUbWV0a3VNaTkreUN5azdRQnI3REtoYkIzWDB1VUkvUWF2?= =?utf-8?B?UmIwYnZILy9zbkVHR2NxYkxOOHlOTmhZZ3BFNEVFWjJ3U0REalMrblBpK0dP?= =?utf-8?B?ekp4MXZUN3F0RFoyeGNCOEZCbG1LQkhMRmNaUXQ5QlVoV0lza243Vmd5THp2?= =?utf-8?B?cWNlZVIxVlk1cDdxWTNSSUZkU0JzbHgxcmpQMjFvN2hZeks3OHZoU3pkTG1J?= =?utf-8?B?cmM2clVtOGx6NkR5bGF3eG5maGJyR3JOblhXZzYxa25GVE15QnhyRmVDYjdC?= =?utf-8?Q?w+OW4k9VPfh50J7qxd18KzXKB?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9d17b7b-0e5a-468b-70c9-08db62ad9f41 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 14:36:44.6458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bU69n1MYIihGXbMyhdv6AjrQHrqGJd42mkTMhdl9gb3WHgwiBUezndliWpNFd4+W X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6057 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/30/2023 10:05 AM, Jie Hai wrote: > This patchset supports querying information about ethdev. > The information includes MAC addresses, RxTx offload, flow ctrl, > Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc. > > > Dengdui Huang (1): > ethdev: support telemetry query MAC addresses > > Jie Hai (9): > ethdev: support RxTx offload display > ethdev: support telemetry query flow ctrl info > ethdev: support telemetry query Rx queue info > ethdev: support telemetry query Tx queue info > ethdev: add firmware version in telemetry info command > ethdev: support telemetry query DCB info > ethdev: support telemetry query RSS info > ethdev: support telemetry query FEC info > ethdev: support telemetry query VLAN info > Hi Jie, Overall it is good to add more telemetry support, but it is making 'rte_ethdev.c' bigger, specially naming of the static functions that telemetry handlers use making file confusing. Can you please create a specific file for telemetry functions? First you can move the existing ones and later add your patches. Also there is a common part that reads and verifies port_id, I think that part can be extracted to a common function, I will comment on it in one of the patches. Thanks, ferruh