From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1980CA053D; Fri, 17 Jul 2020 17:44:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E69DE1BEBF; Fri, 17 Jul 2020 17:44:35 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 07EFC25B3 for ; Fri, 17 Jul 2020 17:44:33 +0200 (CEST) IronPort-SDR: z56J7OfQIedt03tKhZCXJiwHkdVQGBFizYLZjyevNGQr4BmJqXSg3+fZW2N7ditPbTfioQxEXf eqNAHczKXt+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9685"; a="234466523" X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="234466523" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2020 08:44:33 -0700 IronPort-SDR: Sd0Fa+A5C5xCDslABDoX0FTG7/VQZQxpJEDR8UfRrRDAtsxikWB/xIXVo1yG3eODPIAFcK9pIw dHEw0BXr8rog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="286846367" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.226.225]) ([10.213.226.225]) by orsmga006.jf.intel.com with ESMTP; 17 Jul 2020 08:44:31 -0700 From: "Burakov, Anatoly" To: Dmitry Kozliuk Cc: Stephen Hemminger , dpdk-dev References: <20200604210200.25405-1-stephen@networkplumber.org> <20200701202359.17006-1-stephen@networkplumber.org> <20200701202359.17006-26-stephen@networkplumber.org> <20200715132910.5aaa11ed@hermes.lan> <2e34fe08-6548-e474-a7bc-f10e4bef947a@intel.com> <20200716150429.664a524e@hermes.lan> <88cf6911-c0e5-1f37-5f2d-51232d8dc787@intel.com> <11b39b9d-d0ab-bed1-ffef-232606b47c83@intel.com> Message-ID: Date: Fri, 17 Jul 2020 16:44:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <11b39b9d-d0ab-bed1-ffef-232606b47c83@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17-Jul-20 4:43 PM, Burakov, Anatoly wrote: > On 17-Jul-20 4:35 PM, Dmitry Kozliuk wrote: >> On Fri, Jul 17, 2020, 18:21 Burakov, Anatoly >> > wrote: >> >>     On 16-Jul-20 11:04 PM, Stephen Hemminger wrote: >>      > On Thu, 16 Jul 2020 14:41:41 +0100 >>      > "Burakov, Anatoly" >     > wrote: >>      > >>      >> On 15-Jul-20 9:29 PM, Stephen Hemminger wrote: >>      >>> On Wed, 15 Jul 2020 14:28:17 +0100 >>      >>> "Burakov, Anatoly" >     > wrote: >>      >>> >>      >>>>> -#define SKIP_MASTER      SKIP_INITIAL >>      >>>>> -#define CALL_MASTER      CALL_INITIAL >>      >>>>> +#define SKIP_MASTER _Pragma("GCC warning \"'SKIP_MASTER' is >>     deprecated\"") SKIP_INITIAL >>      >>>>> +#define CALL_MASTER _Pragma("GCC warning \"'CALL_MASTER' is >>     deprecated\"") CALL_INITIAL >>      >>>> >>      >>>> Presumably this is a generic header, should we introduce >>     GCC-specific >>      >>>> things there? >>      >>> >>      >>> It works with Clang as well. Likely ICC but don't have that. >>      >>> >>      >> >>      >> What about MSVC? >> >> >> FYI, DPDK on Windows is compiled with Clang, only linker is from MSVC. >> And MinGW uses GCC toolchain. Why care about MSVC here? > > Ah, OK. I'm not too familiar with Windows port, i was assuming it uses > MSVC. > Nevertheless, i would prefer having a macro for these kinds of cases, however rare they are. -- Thanks, Anatoly