From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02BD641DF6; Mon, 6 Mar 2023 16:03:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D49EF40EDB; Mon, 6 Mar 2023 16:03:03 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id C2C3A40A8A; Mon, 6 Mar 2023 16:03:02 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NDMmy/uReOstRSdWedTIrAXZ99OsAT/twxzUvu6Fs3VZwMZCt8hhBAAnghVxJnR2lGUfu+RnfmJGQqZ+Z1ehq0bOO66EdpFy0gsdFouaYN+qPjBaM3TEbvEJ/6DX2f9O5a5JJHE0PXCZbliOWkpH96NTlrPQor+tez8KM7H6vqa2GiwdP+qsrwnkHyq6+xY2d9yHm0rYidsL8QzAPlXCuJkKErHkV3mllCpOOmBZ6h8CGkiEpzI74xZgQ/D8GDwCZU0AS6WItG4NYb49lNAf2cISh7LYuWhg7X5G/n0PznY7vJs3dtgAv+OUSv+545l9ZSXmp2UsT92Fc255afEXmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YcKdperFEaYFJXSP5uB0kTwazP/Z7eB/9lFaighXXrc=; b=e4hpojBIyG+CmluBPvkd87z/jFSEhgh1dZsY+/Mz2Ws7KHGD5Lc+SXvBbXLIZU8QXaL5I42yXKwD28r6UNDbisPphvWhlNi+eLSL9B1aYPlxHRDNvqBwsD6mtFPnYlIp8i7z8+J17cNY0kFwlhDWha5PiKkTE/vYCih03jpY+jIaeO+jx5BIA8WKHDOPL2iPSu/3HwE8y/VY3EzP9ag587ehyizF3eeGoM5tinHKCG3Ds1efxa39ddueM8nP/PTrCA4n/o5rTQ+lKAI0gcNIbpAiPryiuxdTouCklvzuS0wNZQlYNEFkl7wXqtcgQYnVW8ZXUcgk38+Xg/AGPJyFlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YcKdperFEaYFJXSP5uB0kTwazP/Z7eB/9lFaighXXrc=; b=rHxTIvkZl3NQQhaVWwmWM7kgMw+H73sw9aXa69nbWIKs0f6n7bGEZBkeMN2gsoZTy87V0W7VcGZapzx6eVzpaZWU1VjrHrSt8JYAjKsR1N/RM/lXKo+TneBU/DE6B1Y0Q6z4kwfo+0N4h1o4RTU0wRBstzvBmiloQYbcxusc/fM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BY5PR12MB4291.namprd12.prod.outlook.com (2603:10b6:a03:20c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28; Mon, 6 Mar 2023 15:02:59 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6156.028; Mon, 6 Mar 2023 15:02:59 +0000 Message-ID: Date: Mon, 6 Mar 2023 15:02:52 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 1/3] ethdev: enable direct rearm with separate API Content-Language: en-US To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Feifei Wang , Thomas Monjalon , Andrew Rybchenko , techboard@dpdk.org Cc: dev@dpdk.org, konstantin.v.ananyev@yandex.ru, nd@arm.com, Honnappa Nagarahalli , Ruifeng Wang References: <20220420081650.2043183-1-feifei.wang2@arm.com> <20230104073043.1120168-1-feifei.wang2@arm.com> <20230104073043.1120168-2-feifei.wang2@arm.com> <98CBD80474FA8B44BF855DF32C47DC35D8761D@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D877B7@smartserver.smartshare.dk> From: Ferruh Yigit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D877B7@smartserver.smartshare.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0338.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BY5PR12MB4291:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e38771c-e8c4-4c71-dbff-08db1e53dffe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wuiBhbo7cOh96saMRH2KO7xRLsSBLWpAazT2qiEcI/7+BM869MWQj4IHRG6Lov/Bjs/3ozWffbHIAOEYie4yefjW710Q3nhBORfK6Up3XFUN6cLgqn8TJ9zFIE4wsrxfm1V2dyPuzMSQD/I1G2yQc9R00rnh4VU0jSCmu0bgt6KNLfKKhzYLLd6tn/C44rSwCydXVGWvjRN36CzZIGWNc/EmcroijwBxQ0tRrlbmkhAMyjbem66jg/RSstvmOeOwj5vqfEEbeBoP7QaxHdJOt+3PqwSykE6zwwSD7HTU8klKxBD0uzc1kXdjvh+yeBW04nA1pkei78C/it9cDuBT4AgSaIg7sA04IasXy6zb5LxLtU33lcuRjrYw7sXj/nAIbnXIkrqYtJSOq3acMsMvo3NnxGaFZV3s3yzNixDLdU8ZIW0s6f6R4jhKb08sNQSRas3hogUf5SxUDJe3i83mRupkn+wdMtnWcyR/0YupriS1ccPKFy69P5tRIWViFSb2Y58JTRsAkZMD+M84shagQiDgFrLXD8tiqPMM0cK+qF01mNh3R7uX294oRiVb8+g5FQraQ86XJWIl9lY8MSOf2FoJQSuTz3v30OIDX2BzBOuw+3MMW3zJBV812M9EMuoAnJlQPkodLBhTkY5HDtQtvMGhjZ/D+eCWILbt4RwLhQ6+eZ/bhTCDF19o70v2I98u3Dj5j3VtM6QZC6MBMHx7zGF/9OrE49aG7mEweNQSwLk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(366004)(376002)(39860400002)(396003)(346002)(451199018)(31696002)(86362001)(38100700002)(66476007)(36756003)(44832011)(5660300002)(7416002)(2906002)(4326008)(8936002)(8676002)(66946007)(66556008)(41300700001)(2616005)(186003)(26005)(53546011)(66574015)(83380400001)(6512007)(6506007)(110136005)(54906003)(478600001)(316002)(6666004)(6486002)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1phTXlQLzc2R3h4M2xwUy9ZcmhPWCtPY0xtTSs4VEl6WmtPSTljOFhCUEgr?= =?utf-8?B?bGRwQUp0R0U4R2hSb1g5R2VyOTE3NTNEcEtPVnhFaVpKd29hTGIrMGxaamJv?= =?utf-8?B?Ri95d1R1UTdSaE03a09ObEFYbVE3U1l4MGtkeVdLNHRUQVpyOXRtUGc0dndE?= =?utf-8?B?VFU5WFJHeUYxb3VOYkpiNStXRUpWQm5uZ2VQNGRKSDZ6aElkTmNBb3RzTW0y?= =?utf-8?B?Qy9CZm9sbm9JU1NzWnc0OWdieG05UnNIMGNIdzcrMUx1VGRjZmlEcWt5ekw4?= =?utf-8?B?QzhJVENMSU1tQS9JYWVLMGNwY0MvK2ozdDVUdS9GaXN6NUtRRE5GMURTY0xV?= =?utf-8?B?RnR3eDlNdDdQamVYZUcxcUgyamFsQjJMZm1wVHMvODJJWEljZnZBL0hLaUJ6?= =?utf-8?B?TFMwTWV5bFlZcnhCM3NmekU1c1M1NzhPV2ZLY09wcmVLam5MaGFNY3VvQVVz?= =?utf-8?B?cWNIK1c0VTFMNFJiQXZnOXAyQXRvelNVWHR2MzRUY1NBaUVRQSs0aUpUMlNF?= =?utf-8?B?Q3BsYnBIcDZ6K29GeDVkUXd1ZWdCZ0hZM3pIdEdUNFFzQXNyUnBiUmZFYmQ1?= =?utf-8?B?RWV3ZTl3cjdEUWNYeHVjeEZ5U2NmV2VhOHBUNkZWRjV4aS9VMVptTWo5WU16?= =?utf-8?B?WEs2bWZhQUJnQUlnMG1sbXdzckVtVFRDRWNHZjNvZUhjVlpQMDkyRWFkQzZI?= =?utf-8?B?MnhoWEpNZW1NSytsWmlvdjRVRUx6WGNzaEhDMlRLcVpWanZ0S3gwejh3cE02?= =?utf-8?B?RVE2V3BZSHJ0eDdhc21VRHRjSWw5ODBOQjlQZEtXSTlUVU9UNXdkWERKODRO?= =?utf-8?B?NFRWeTh2ZlNqQWM3a1p6UytZRlB0QUdacDFFV1RtOVFrejZXYnRmeEIzaDk1?= =?utf-8?B?SlI0aTFGa0xyb2dBSlQxbTN2M1poWnIwdkJIK093VGNBaTlCSHFzOE5CL3dF?= =?utf-8?B?WTQ3Q2lZVUZQTzJlOUlvRVNIUUNXc1ErK3lKbXNDZmpZelhOTFR1eTYyelZn?= =?utf-8?B?dG1waXpFRVNjQUtkS2VhZDhpWEYxK3pPcmpSSEtoT0VkaEtwL3JJakRDLzE0?= =?utf-8?B?b016aWIxaDVXeXgwUTc4SWlWTGRsVTkwNE9jVDF0UHlFWld2c1YxdFFtcFBM?= =?utf-8?B?VVZRRjhvQTBkTDYyeS9WZUFCYW80cTRNNjZsRmhKV2JST0Q2QmZHUHYwOXA0?= =?utf-8?B?dXFNUnhwNHU2SlRESW9rdXhtRnlKOElja0VMekJvVDRmV0hOckxLaHlWYXdY?= =?utf-8?B?MXNlcUVvRWVSd2VGQjM3MDFDM1lMZEtqUVJUQlN6MXBtbHVVQUtMVnRXN3Zm?= =?utf-8?B?TUFoQTZOeXh2YnI3VEtjUy9xOU9Hdi9leHlyaUNpZnNWV29XVjdQVE5NZlA5?= =?utf-8?B?TkhqWU11aG5tRGZkQjdzQkE4ODdhQ05WWkVLTGh5WFI1cHBOTGdKaTBOVGlp?= =?utf-8?B?aXJzcmhsaVVkckFQa0gzRGJOcVVrRVVPbXpiNUd4cUxselNwVUhaSDJDSTFU?= =?utf-8?B?QW9vU25sakFUUEVjRnFFYUhHcjNvcmJzM01CNGZDMHJIY0NBRFB5NnRIK2F1?= =?utf-8?B?bkVsL2p0R0w0REJ3bXI3cmhtVlovYzJVSEVkeEZxblJyNjZqSGEwcm50N3JN?= =?utf-8?B?MDR0dGZBbEtxaFZMTzJnTTJGZnJKOEhIT2lEOTNRcVNXYnRpbU5YNEVUUGhS?= =?utf-8?B?VFVsQmcveXBpZjdPNGljb01PRW1sMDRtbk5ITG41UEZnUS8vTTVISkFSbGJ0?= =?utf-8?B?bEdyV3VyYVMxVFF3aUlLVkk5clBvdGFIQmlwWmdvVkdRUHRtbVZ5c1hSYk5Y?= =?utf-8?B?NXNDOGVQVkw3akk2blhueXI5L2hCb2Z2ckNDQ2pUYjFwUnp0VW4yd2F0emhm?= =?utf-8?B?TmFqTm8zUXRMNStQT3lCTkR5Ky9IanFJRzhvVWdjUFpVRkMrMUZIV3lnUi8r?= =?utf-8?B?SDZlT1ZtUlhrdlYvcm1TeUNkWHFURXNaZnZUT0FMdGF3WXZCQTR1Z3FRQUdF?= =?utf-8?B?QjlLREt0ZkpZYmNPKy9nN2FPTElPNmdiUVg1R3UveHdpc0cvNFUrZkdDcFlE?= =?utf-8?B?NEhZSHNwYnVhUnlmc2syZEdYdDJiRTc4cmNkVVRtSzgycitGTENmS0VVK2dZ?= =?utf-8?Q?weAqIMVtGXFfdy//eZ88zBQx1?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e38771c-e8c4-4c71-dbff-08db1e53dffe X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 15:02:59.4227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e4WC+E1PbZUt3D1969ygS4NUfR8yOWyKGcbqpvAXSNxz+yYB5bb2XDnIsqWsahby X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4291 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/6/2023 1:26 PM, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yigit@amd.com] >> Sent: Monday, 6 March 2023 13.49 >> >> On 1/4/2023 8:21 AM, Morten Brørup wrote: >>>> From: Feifei Wang [mailto:feifei.wang2@arm.com] >>>> Sent: Wednesday, 4 January 2023 08.31 >>>> >>>> Add 'tx_fill_sw_ring' and 'rx_flush_descriptor' API into direct rearm >>>> mode for separate Rx and Tx Operation. And this can support different >>>> multiple sources in direct rearm mode. For examples, Rx driver is >>>> ixgbe, >>>> and Tx driver is i40e. >>>> >>>> Suggested-by: Honnappa Nagarahalli >>>> Suggested-by: Ruifeng Wang >>>> Signed-off-by: Feifei Wang >>>> Reviewed-by: Ruifeng Wang >>>> Reviewed-by: Honnappa Nagarahalli >>>> --- >>> >>> This feature looks very promising for performance. I am pleased to see >> progress on it. >>> >> >> Hi Morten, >> >> Yes it brings some performance, but not to generic use case, only to >> specific and constraint use case. > > I got the impression that the supported use case is a prominent and important use case. > Can you please give real life samples for this use case, other than just showing better performance number in the test bench? This helps to understand the reasoning better. > This is the primary argument for considering such a complex non-generic feature. > >> >> And changes are relatively invasive comparing the usecase it supports, >> like it adds new two inline datapath functions and a new dev_ops. >> >> I am worried the unnecessary complexity and possible regressions in the >> fundamental and simple parts of the project, with a good intention to >> gain a few percentage performance in a specific usecase, can hurt the >> project. >> >> >> I can see this is compared to MBUF_FAST_FREE feature, but MBUF_FAST_FREE >> is just an offload benefiting from existing offload infrastructure, >> which requires very small update and logically change in application and >> simple to implement in the drivers. So, they are not same from >> complexity perspective. >> >> Briefly, I am not comfortable with this change, I would like to see an >> explicit approval and code review from techboard to proceed. > > I agree that the complexity is very high, and thus requires extra consideration. Your suggested techboard review and approval process seems like a good solution. > > And the performance benefit of direct rearm should be compared to the performance using the new zero-copy mempool API. > > -Morten >