From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 602FA1B692 for ; Tue, 6 Feb 2018 10:28:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 01:28:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,468,1511856000"; d="scan'208";a="172037873" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.145]) ([10.237.220.145]) by orsmga004.jf.intel.com with ESMTP; 06 Feb 2018 01:28:51 -0800 To: Thomas Monjalon Cc: dev@dpdk.org References: <3cf7f9aa904a5ba53ba63d7c32539e8b78638939.1513946317.git.anatoly.burakov@intel.com> <750e30c6dcc7a22a87df9c56fb824042b1db984f.1517848624.git.anatoly.burakov@intel.com> <4220934.KFJTx7yznj@xps> From: "Burakov, Anatoly" Message-ID: Date: Tue, 6 Feb 2018 09:28:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <4220934.KFJTx7yznj@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] eal: add function to return number of detected sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 09:28:53 -0000 On 05-Feb-18 10:45 PM, Thomas Monjalon wrote: > 05/02/2018 18:39, Burakov, Anatoly: >> On 05-Feb-18 4:37 PM, Anatoly Burakov wrote: >>> During lcore scan, find maximum socket ID and store it. >>> >>> Signed-off-by: Anatoly Burakov >>> --- >>> >>> Notes: >>> v3: >>> - Added ABI backwards compatibility >>> >>> v2: >>> - checkpatch changes >>> - check socket before deciding if the core is not to be used >>> >>> lib/librte_eal/common/eal_common_lcore.c | 37 +++++++++++++++++++++---------- >>> lib/librte_eal/common/include/rte_eal.h | 25 +++++++++++++++++++++ >>> lib/librte_eal/common/include/rte_lcore.h | 8 +++++++ >>> lib/librte_eal/linuxapp/eal/eal.c | 27 +++++++++++++++++++++- >>> lib/librte_eal/rte_eal_version.map | 9 +++++++- >>> 5 files changed, 92 insertions(+), 14 deletions(-) >>> >> >> This patch does not break ABI, but does it in a very ugly way. Is it >> worth it? > > I think we agreed to not get this patch in 18.02. > Did you change your mind? > Sorry, how do i mark this patch as for 18.05? Is it a patch header? -- Thanks, Anatoly