From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB42C45B7C; Fri, 13 Dec 2024 11:22:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5CAC402BB; Fri, 13 Dec 2024 11:22:30 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 4EEA740263 for ; Fri, 13 Dec 2024 11:22:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734085349; x=1765621349; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=fz7qL6fe+3DsouSBMFXP7/gvuzX8YKVQGUj8E1PoyAU=; b=mrRRHRRLVfg1P1B/i+QVnYCWPD6MmQP88lWgjv2kQpMBdiFrET2MHPd5 y7fwSZnlkgc2zEDoWhnZChtYAOTIyJ960vZ2POBxGEPAUhXGiEu5DsfX0 COgQMyR3mfm573AbpCHDxTzr5JWKxR+VXtrCVKKgIw0AG6peuA926Hfiq cLOtaFHyck0/wkxZi5e57qQQjm4WqmngIQjSeEAHkdCjQbtGvpkIFjB1I M8DM/hkNP3+IFnygqOiJmMhN140/TjS+OHLLCaBK437v7O+4OX7BBJgEk zasayzLSwg3OyMriMMqb9IQOZm1LLyieBIlgQLu7fFLgUGMiU0C7mSYZ8 w==; X-CSE-ConnectionGUID: liHV55REQJ62Tv2D7kXsWQ== X-CSE-MsgGUID: dkevbceISV+I7RMMKtk2fg== X-IronPort-AV: E=McAfee;i="6700,10204,11284"; a="59927874" X-IronPort-AV: E=Sophos;i="6.12,230,1728975600"; d="scan'208";a="59927874" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2024 02:22:27 -0800 X-CSE-ConnectionGUID: RkDkuZ18TrSN4pJiL+FonA== X-CSE-MsgGUID: lSffy0a7R4aBNhFu8Wp9dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="101073132" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Dec 2024 02:22:27 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 13 Dec 2024 02:22:26 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Fri, 13 Dec 2024 02:22:26 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 13 Dec 2024 02:22:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kKdLMZbefP3KhcVdGSKT0kH6EvE0mVR35xcpgwKTPTS5JshWFjTsplJYUHHdhzh5Z+Hx/q0bbh3yP9sv6LCXOz9KSMR4ZRzs3u6OKzGUCwLq1gETLwk1m1z4sdXORAMA+WiCgLG23A3lKkKqi82bNar4R0SqWMAMY+cOa2xEtLjbZqwbLIwaBFni8zIlukg3k6Y1XlrCLbxEg2glaYAVKlYl8uq6Bo2UcBD3rL3kFR01fFawY+iQMJ96tEZYPQ+dWvtRX5cIayHU46FtF16vTejCE6NpkyuuAzGKCktmUnEEjUevgqUMFndoLoEVOxe3nGyf33iASDpoysuJMuPziA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K8VoT9r91kKFDWY4Ew7ydHhlf82ntjtUbViyR4Fei+U=; b=VRaint3AH+bkWyEJftHYbT9rs8SJxon9beW03UwxRvbbr4nriRb6nRqZkkaXi8U3k19T9/c+B+8Q6NSaRbxLm7zYv02PD1l0Ko7zasvrL3rbq/zmaJM3oJeQ8JiKS4ZYZ4IBN+OUyQM+z4w/J66OJipXFoI8BZZqrBMuWsk9nJ5pCKwsV4c8op/+bvcW1Bso2qAZ7eazJ9cWywrNydiK0TLHoRVMv7H42HZffHngO/4Yu4qv2L5WzcZg1Ti2tepUSLwu0QiT60UGBCRsSjvEHO3bWAIrF0bQeoRA5f+Jle2gNaFndANRLxvsS0s7FX4b6nYttsXoniMl0E3BOqGYNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) by BY1PR11MB8053.namprd11.prod.outlook.com (2603:10b6:a03:525::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.17; Fri, 13 Dec 2024 10:22:24 +0000 Received: from SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::5851:319:3da6:850b]) by SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::5851:319:3da6:850b%6]) with mapi id 15.20.8251.015; Fri, 13 Dec 2024 10:22:24 +0000 Message-ID: Date: Fri, 13 Dec 2024 10:22:20 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/test: fix stack overflow in lpm6_perf_autotest To: Andre Muezerie , Bruce Richardson CC: References: <1734057571-20367-1-git-send-email-andremue@linux.microsoft.com> Content-Language: en-US From: "Medvedkin, Vladimir" In-Reply-To: <1734057571-20367-1-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU7PR01CA0034.eurprd01.prod.exchangelabs.com (2603:10a6:10:50e::9) To SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB5772:EE_|BY1PR11MB8053:EE_ X-MS-Office365-Filtering-Correlation-Id: 217d0ae9-952c-45e4-926f-08dd1b60095b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZWRNcFVKak9OQWg0L2d5d2JIYisvOFNJdzlqZkpuaXEvMWVLaFovSjY4Rlhq?= =?utf-8?B?TDVycGoyQktwN0FaOS9qaFdoVUFsZmRFMVd2UlVFTUNNV0RSTUw4a01pMGdY?= =?utf-8?B?Zi9sUnNTNDBhK3MrUXZqemVySFZ6QVRBN09SakkwaUduMThtei8rSzBUVkFx?= =?utf-8?B?VUovM0ptYWdocG1xbWRSZkhUbEZYMzU4QkZidFhmN3RQNEd3d1pidWVMK05R?= =?utf-8?B?SVdiT2FCZmVBN1A4dE1YcG5jdW1RQ1lUa1lwczBEN0RyS3V1VlV4ZzFvTlVh?= =?utf-8?B?QWRaam81OURZOWRLdTdRaldpWEY1SzBFdDQvbHlmTWtDVmxaUlc1M2libzNQ?= =?utf-8?B?WjVLcytCaWNMOFdvVWdwSno3aUJqQlN6N3F3RGZtTDNWUy81Um8zMlQ2Q0dK?= =?utf-8?B?bXExck9TTEg0VFZrT01jL1RnZHhHei9pa0t3eUx4RmxjNnlHREROMlUrcHE0?= =?utf-8?B?b1lCYUlLR1lZSWlUYStSL3hBeFYrWGkyWnFIb2JET0dlc2pReU04YnBWRFNq?= =?utf-8?B?VkEwbFFkRDZPa1JzRnRJRVRmU3Q2R0ErUlZQdnFmVzViT0VLS1VqNDg0MUpW?= =?utf-8?B?VjNvUzQyZlVKL0xQY2FaV1B1SVpFampSalM4NllENGNvRmV3NXJwajhPcHU1?= =?utf-8?B?Y2hhQ2VSQldCL2RDOWovN2pEU1NEUEh1WjlOVHdRcnhRWGpqUCtvNGNQOGk2?= =?utf-8?B?bHhxTU5FRlk0eVhhSXlQRGdlZmJBdXMxSEJVcjJPTFBtcUYvbFhQQzRLYk5F?= =?utf-8?B?YjRsNWlaYTkwQkRYei81dVhQZmUrRy9xbU1qa3IwRzR2SHNhalNTVkJ2aENS?= =?utf-8?B?YWplZS90WWEyNW9tS0hlTTFEL01uNkVkVU1FMko5d2Exdkh4WUZYS3pnL3Bo?= =?utf-8?B?cG9TUHVrYWpLZXVEdHk1enh4Q3crQi8zMHV5Vm5ubUtBakxHSHltYTk5Z0x3?= =?utf-8?B?eXhUR0ZuMU5JSTBoQjgxZUZKbXlacHBKV05WQlVabVNsWU9xdUkrODdSUy8w?= =?utf-8?B?aUVha3F3YjRFOWVnSXBNdTBrVVFMNzVNUjZEdlZkclJOT0J2Vlk2bjF3d1Bv?= =?utf-8?B?Y0NVbGlBTUk5TUxaUkN4VFFWME5uVU5XVVovaWl3bENDWS9hSWVFSDFJR1Jh?= =?utf-8?B?cVA0TUo2SUVhc0dNR29idHUyNTZZdTVoaEtjRUdudC9RVmFyOElPaGNyNjdi?= =?utf-8?B?VU5uMGZUTVFCZmNwQ0IwSDh2VWRUeWk1UFNCcGdTQjZFT3BpRG5ibjhQWWw4?= =?utf-8?B?ZUJnV1JmTFJHRGhobE1NKzVkSkN4YUxnRjdCamJBSjlqYmVudHpWd052NFlM?= =?utf-8?B?ajl3Smd2ZExjM1NJY2lQQ2xQSEl2ZHNxQmN5cXVVemVYZU92SlBJMnN2RGlr?= =?utf-8?B?OXc1N3JtbmFXbUtGa3lrRlhKOU9SNCsxWEJjRTdEb3BLK2ZYOTk5UFUyZHRk?= =?utf-8?B?ZStWdHN6RnN4UkJ6VEdVV3Y1bHcwaEJFdWhPRlI5NWVhaVFibElmZmcrWjNq?= =?utf-8?B?VVlOTCtDUzNRcmNkclhvcE0vRTV6dXorL0VmdHZwaTNranljYkp2NUNqWWFj?= =?utf-8?B?WVE4V0xRalBQQ3gzeW95ZjlhckhVY2E3V2ZOS0xjT1Z0bjBFN3I1L2pGUUhV?= =?utf-8?B?MlhWaEprUUxIYUxEY21MbkZUUnp1aFlTSmhLdGV5dFlCc1ptZTB2OEFCSUNi?= =?utf-8?B?bHdXb1I3N3dnSDhGZkFWdEtVVUxvcUJkWjZqWE5pV2R2MWcvU21Vc0xMcW91?= =?utf-8?B?M1NOZnZGUnduRC9MMENreEhkdW5WYmV4OHIxREsxZHpRSHdpMWl2NytDUThS?= =?utf-8?B?N1hndkRjcWV2Z09HWFlVcTlVSEtybDREU1NQMTlUcjFNZXl0TGNrZks0ZWdi?= =?utf-8?Q?WFuPs9NozCf+/?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5772.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnVEeDFlMFdROThGUi9YV0J0QXFuNEU2cU1pTlg0dDNLaGsxc2VmWFNETW1N?= =?utf-8?B?UHVsTk1ORm5HN2tZczdpYjJtazZpTURhbGJSa3EwSmRlL1N2ay8zeks4QjlU?= =?utf-8?B?Y3VqVm12U1gxL1cxNDVvSVRzTFBMZHJQOWlzSWl3eWkwYlpoRTB2anljZk5v?= =?utf-8?B?TGllbS9pVVliejBzN2E3Y2RHMThJVmZSU1hiczNNOTNmajFnWkFyc2RqRG1J?= =?utf-8?B?ZVErdGJFY0lUaEJqQVRhbWFVeTZQTXlCcm9pSjBNZFY2RHBqSjJiVnU5Q3Nh?= =?utf-8?B?Ymk5WnVlNURXaWQvR2t1RkxpKzh2eDE1MjZJWDhQVGNnbkhUMFdmZjlWQUxp?= =?utf-8?B?WjN5SHlMYmU2c2lNTTRyYUpRZE92VkppQ3YxWTV2MVlsK1V5QS9McUFRWW55?= =?utf-8?B?akc3OGRrRS9VM2lMQVhlR0NqU0Zudm9yaTlPTVVaK1lZQ0FsUXhZcGF1OXFN?= =?utf-8?B?VzM5eSt6b2Y0WHJ1SmQ5NjZGbHhWSDUvSEJIM2o1OWgyekxzZnpnZmxya2hT?= =?utf-8?B?b0NOT3BOdHRKS1FvTHNoSE42bzFIZTViMUZVR1VicGRicm1EcTZoWnkvaDZp?= =?utf-8?B?RWtydHQrOFM2c2cxM0wvQTROVUM4TC83eUdxVUF2bHNrZVkzOWlKSFZMWk5W?= =?utf-8?B?YkxEZU1XTFlTMG4xZTlZMDVreEdKRGxzRmZZR1ZhdTB0cmZSVm1BZkxKUkhp?= =?utf-8?B?YUlYdHZpMGFYSlVnR3BMR1BCNlUrOEZDTVBFVnJKbXBUMW9FRStVNitsdDcv?= =?utf-8?B?cktKakVob2tDcDZWY3BqUkVPRkFZZzZ6cDhtZ0Z4VXRzQW9yeTJHa3RnYkgz?= =?utf-8?B?aFRVQ3pvUHFxRXkvOFhHanpjZzg3MlhEUkVVZEJ6Tm1SQk93MFZnMkpWbkFo?= =?utf-8?B?ekhtUWJsSDBhUFBCbURCbTRDMGgyVGNsZmlxRVVyZFVqRjlBNmlMQW5aZitw?= =?utf-8?B?dXcwc1k1K0FOd09XdnVTLzh1Qmk4RlpOb29HOGRtUEFLZElJZXNKb01veU5S?= =?utf-8?B?OVQ5SUw0bjRLeUt5bGk5YWN0SmtMSjBCYzA1ZTYvU3JNZFNiZlhjK3o0alNZ?= =?utf-8?B?Qlk4RDZqeEJ2eDFNNnFRajIrakh4ekMwRVkzandNSndZbUNrMjc4N0U2eTFQ?= =?utf-8?B?elgzRmVlcTh2SXI2SVBFTEZKWjJRcUkyZm5wRFR4WUk1SFY4VUs0Y2lhREZY?= =?utf-8?B?TVZkNGdKamhyTjNHZTJhbkROUGxIS0dCNm85QjVvWUMxQXNCeE00dDVZNlIy?= =?utf-8?B?TC8yVnhSZElRdDhybWpQQmxZYUJrMWlJZk80OHFxSmcwaFZkcVl0UTNnRnpH?= =?utf-8?B?N01wcWZPaHROL0V6eHJQNVpzQ2dYMUNDa3ZiRklDTTV1bDhyMGszS2I4anUw?= =?utf-8?B?MTdmbWVFV3pRbW1RVkZoYy9ZWWhOaFREMHlGUHozZ0E0RGRNZ1FiMk5CdzZC?= =?utf-8?B?b2F5VTdSc2ZTSWJxUnI1a2luZWtvc2JvRGlkaGNXamR5cndOY0NSQWV1ZC9v?= =?utf-8?B?bkowOVZWdEthM3dBM2xubEpIV2NxYU94dEg3SkVyQTZVOGc3SXR3a1I1aXRi?= =?utf-8?B?YkdCT0krQU5lRGp6elJpc1JodnhWSmVsZjN5MERSVk1yczRzaEp6bVdLWU5x?= =?utf-8?B?TE9Rb1hJMVZzK3lXZVgvV2pvN2h2ak1NUmRTYzM0ZnZPWm56WkFvdm1NZmts?= =?utf-8?B?b1d3UW9wdi9JWVQxTWFKTzVVOUFXN3drTTh2T0tnSEFzR2NhR0tudUVVbklM?= =?utf-8?B?MTBCRmlQekV3M3Jxajl1OGtONlVlWEVjL0RrQ04yQjI0aHhIUUlPMi81WDNZ?= =?utf-8?B?L3ltRTByNGpDZVVma2RDWDZkSXZBbjM4c2EzWEI3VW40K0dqRGtwS0FLT2Nt?= =?utf-8?B?aGVuMDZYTk5LV1FUbjJ1VzkwMGhwRGFnWXdWNlhyM1psc0c4MGJOZXZBWXI0?= =?utf-8?B?RE9EK0dKK3hTZlpiMUowaEluaERRcnZwS0JneHlheU0yR3JIdWZjZ3QwdVRF?= =?utf-8?B?djhYRE9WQVVzWVI3Vm5BNkIyY1R3QWNSekVDSDZoZmRtRVU5Ym5TaE94QjY0?= =?utf-8?B?R3Y5Y3hQbUUvcmhPeCtUb1dRSTZHcHBlbk9TNnlIMnl5TUdEdmNJcFpzbjFI?= =?utf-8?B?WUhoejF2RldCL2YvL2s1aHNiNUlLbnA2K3ZHTTFpSFNHYzQ2Tml3RUhaZUJy?= =?utf-8?B?OXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 217d0ae9-952c-45e4-926f-08dd1b60095b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5772.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2024 10:22:24.6721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q6W1Fk+NAtpH/8fQygdvZSyua55GlEoHU5HAqMH0J8erp6oFLBlg1zhpTPWPMPS6Oa3fRoakGV6nYYqldbKbsZlnAGs0Cv4yH8qiGHtGLtM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8053 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Andre, On 13/12/2024 02:39, Andre Muezerie wrote: > Test lpm6_perf_autotest was hitting a stack overflow on Windows > with both MSVC and Clang. > > The fix is to move some of the data from the stack to the heap. > > Signed-off-by: Andre Muezerie > --- > app/test/test_lpm6_perf.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/app/test/test_lpm6_perf.c b/app/test/test_lpm6_perf.c > index 1860a99ed6..8231ad825d 100644 > --- a/app/test/test_lpm6_perf.c > +++ b/app/test/test_lpm6_perf.c > @@ -117,8 +117,12 @@ test_lpm6_perf(void) > total_time = 0; > count = 0; > > - struct rte_ipv6_addr ip_batch[NUM_IPS_ENTRIES]; > - int32_t next_hops[NUM_IPS_ENTRIES]; > + struct rte_ipv6_addr *ip_batch = (struct rte_ipv6_addr *)malloc( why not rte_malloc? > + sizeof(struct rte_ipv6_addr) * NUM_IPS_ENTRIES); > + TEST_LPM_ASSERT(ip_batch != NULL); > + > + int32_t *next_hops = (int32_t *)malloc(sizeof(int32_t) * NUM_IPS_ENTRIES); > + TEST_LPM_ASSERT(next_hops != NULL); > > for (i = 0; i < NUM_IPS_ENTRIES; i++) > ip_batch[i] = large_ips_table[i].ip; > @@ -153,6 +157,9 @@ test_lpm6_perf(void) > printf("Average LPM Delete: %g cycles\n", > (double)total_time / NUM_ROUTE_ENTRIES); > > + free(next_hops); > + free(ip_batch); > + > rte_lpm6_delete_all(lpm); > rte_lpm6_free(lpm); > -- Regards, Vladimir