From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7406843279; Fri, 3 Nov 2023 14:12:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60C3040691; Fri, 3 Nov 2023 14:12:11 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 020824067D for ; Fri, 3 Nov 2023 14:12:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UJTFQGgwCSid3d6dUTWHOL6bS3Kxi5rnJibqt7Aa8z7eKT755xOq7icfCVH7I0Unxm1MWbf+eGR84FngJ8u94leeyJ+wS+p1HghO5B44UmkhDBLee6MfoM0QjK0ex5/87KQVzHTbmGLTWGdI99/fPwPxhOgH/6e3xckaRXs4WIZfDL8ILvhF7zUP1L8cJVT9wVfhUwfynHOi6C4M/A+qHY6SSN1bm06f2ons6EU2Pnynmb90rMyEsNcGsQYHKyfu64IlWc/HAa9/SYJoXZOvVSGX/gvXwcNMU50CHgWZW0uA1Z3CvBOgW0pT0mWnh6kklM+jvrw7msTeV09XJ/Kg5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7mY3qVR4VhDPQIrSWHH4MvQTXIJBvTLVvr+Jktax6YA=; b=E0KG5M0aypSWocs8EGMlvTuvBCM8LMG9k0N68Q2avDrsanLzP51l62SyUqMjBCyo3afvnQuHkcSO6F6A7N+mIFToZ8de17lvqFWUzfTGDvpWovXK3Y2WE+OmdwV0U+MhAc0T7LJZ0OYW8SGBmye0tgSx4PinvZDb6gxb9q9pj1LI5xGc9CgGVAK3o6qi9lI+CUfEqyLkorycdwlwQt+jg9GIM6Au5/IlO/55BtdLjvsSoBkYgiacT+sy4REJRXfUA0PtG1EWDZyefNdds+b0YvNXnHK7OHPOYoesFjqbZie2F1rBxTNjjbHzGk0JIwkOfpPt5JWdYtNrFPYMnskNxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7mY3qVR4VhDPQIrSWHH4MvQTXIJBvTLVvr+Jktax6YA=; b=o6ZyOF5BlDf2angGomA8MgJ2UrH7kKah5yWRQQmU+imy0bP7kwrqQpUWolzmWz5v7dswSg8M2hpJwc+gzEMctxzQyoPkAMwfovBrBi1+umlBrhnMtx+ExL9yAU8NLehtf/GTy45FzKMZPNkTsEkco85lzu3WfGIk7Ql2KsX7avc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BN9PR12MB5225.namprd12.prod.outlook.com (2603:10b6:408:11e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Fri, 3 Nov 2023 13:12:08 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.019; Fri, 3 Nov 2023 13:12:08 +0000 Message-ID: Date: Fri, 3 Nov 2023 13:11:57 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/5] net/af_packet: use new API to parse kvargs Content-Language: en-US To: Chengwen Feng , thomas@monjalon.net, "John W. Linville" Cc: dev@dpdk.org, stephen@networkplumber.org References: <20230314124813.39521-1-fengchengwen@huawei.com> <20231103073811.13196-1-fengchengwen@huawei.com> <20231103073811.13196-3-fengchengwen@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231103073811.13196-3-fengchengwen@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0164.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BN9PR12MB5225:EE_ X-MS-Office365-Filtering-Correlation-Id: 6833b373-9a1e-4094-6bb8-08dbdc6e7b5d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UxwiqEwmelSPDDfXFQBF2pkwzNz/gko6MvbAA/oTal4hhfa1JKdWPJScDUwYO0AyI5mc9n8kovaKSupCh+zZ6fszJjvbXzPdD8zIQphNPb7EIuwTKyz9TpkCka2u95GsSK4zmqRuywlJZiDlcqJdZRVOsv1aCpSACK2fZIrnOA95bnrjKbbWR1inDG+vHni8fGMp41Z38M33mU4rfmUcQrLWD5u6tWJp5j0dMRUeRQaHbF5OIp4R8fYC1dwkcMWfeZYWTwT2DCfWvXrQ7smlx2BuTp+31ZYZp3RRgkTvFoL2vyhddVFQ92tjeQl/lcXhR+vKRUXmeoPoTM02nV2Z2QTkX3AU6i+Fc4FBLVAgKoChyV2kRnC5AFMKRvZcHhSDx2W/9ht06fJSVIpYPgrvNWfGBkqa1c9qwVARaDCka+M4fz1A0mi6EVHDJPtQBDzLT++Y7OVc/4/GMINSD7RRZIR+U4ChjiPSC/UV8PP9LDIZw4zCgekiwfEbtF6bxQ3waAaUuo25octhoxf5AReZ5iV3xy5UdH18BQ8AHl2FK/+vXsWNziUyQuhcrl45rPjrkGUY1CnBZ/eYfnS1zcsupOStz4xQpstsnfCyYhaf3vcRUcXb2RLiyIkRj3ZjmBmB+Z8I/VO8ta+wQ6UMKfe/RQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(366004)(346002)(396003)(39860400002)(230922051799003)(64100799003)(186009)(1800799009)(451199024)(6486002)(26005)(83380400001)(66476007)(38100700002)(110136005)(66556008)(5660300002)(8676002)(316002)(8936002)(6512007)(4326008)(53546011)(6506007)(44832011)(41300700001)(2616005)(6666004)(478600001)(2906002)(66946007)(36756003)(86362001)(31696002)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmFRTENoZHF3YVV5RmNDcEpid0M2cXJZaTRMSUwxZXRLbjYzVDg2MlM1ZjVu?= =?utf-8?B?bnJXRjJodVBSL3lYZHVUVUlLeis0WVAram95TW5iRWp0QW1ETVVyeG96OGl5?= =?utf-8?B?SlNYUitJVW9ZbnJjRFN0ZlgwRkhTNFgrWDRYRHFXKzVqK2REUEM4a2FrVXJB?= =?utf-8?B?L3VFYjNYc3BTYWYwbnFSeUdzZkJVcHBEMDlQL21aN1FMeWowOW8xZi9qVDhC?= =?utf-8?B?K01NSE43anVSZGY5NFRLVjVHeFp5YjkvYUU3RXZpTzM4VTQzMGlrTEZQZnA3?= =?utf-8?B?bFdIZmMxVVVpZzd1S0kvQjl4aHFhUjI5OW9na3pHNDBhakwvdXBBQlI0elIr?= =?utf-8?B?d0tldmNvY01nM05RdzBiTDBnUWc2dzl2dGV4bGMxclp6MEJjcE9SWDk0RWZT?= =?utf-8?B?SmlZaGU1emRZNno4dlNJajIyWVN5bW1jUk1MNWJBWXh6S3JXME1pTU10R1ZP?= =?utf-8?B?cTEyV01uZ3RlcTBoNkM2d0dCUkFMZnFTM1E4RlJCNzJ4dStYUHMzN1d2UFZl?= =?utf-8?B?eGZ0SDFXb3V1V0NxMUZBR2s5Nmh1ODhtRndSSEdPalZESWxYbGNMbXJUMCtm?= =?utf-8?B?Rm1zTjBqKzc0aWxDYklFQ0VneG9lUlFNYkxiR29xelFiaU5pZjJLWHIxL21h?= =?utf-8?B?VUl4MGErSy82bDBaZzF2NitlNUNzU29jNjd5dzBVbG9oNUc3OGtYSVc4TUNK?= =?utf-8?B?anAxY1VOQzVYenBYNDNGT1JVWWIxV2V5WVZFVmRzQVRLTk04aVppdkMzeWpp?= =?utf-8?B?aVlDaUdjS0t5dC9qR0t4T25UVHVndU40VjlyajNKcm9URFFzT3BEZDlPYmNT?= =?utf-8?B?OUFudXRFSUh5bjIzRzFCZVM1ZUxLak00NnZhcFJ6OEhER3EwcW5tU2tIa1B0?= =?utf-8?B?RGkwaytkVWZVTmxSbUNvamhkZWVTemI4K1poZXBXR3dsU1BreUpMYVhtK084?= =?utf-8?B?UG9DVWtBZ2gvS0lmNnpvMmdwSENSVWw4U0VoRVZUZXJlNGZuL0FZMmdIOG91?= =?utf-8?B?SjBkZnFnelp5emlaRzlneHJyOWJFNnpsN3M2dTdmTTlnNjl5ZUEvQkhyVzRP?= =?utf-8?B?TEZ6bGlVc3NySzNQVXVwR2xSaFVqbml5eW9Mc01UMXdzZHZDc2lMbmNqUDJV?= =?utf-8?B?RGVEN3lsQ0llcnBSc0I5M2pYLzJtZ2lJV1dnYUxMOWh1WlBZeTJPU29MMTds?= =?utf-8?B?T1p2WHlaTHpJTHZ4VEk5aVM4aitGbGI0eFFCZW9kYWFpam1qTXQ1M1grdWtz?= =?utf-8?B?UnJGeXZCQTNuTkNCWWx6emdmMkg5Y3BNczBhWHA1eWltTTJoUlhET20yUGl1?= =?utf-8?B?NWtKY3NZSElmbDNoNldkd0ZxR2M4WDA1T1JGRkR2V3IzamVFa0xtYkVycWp3?= =?utf-8?B?MkVhTExMWjVhZzdHUlNDNmtWSEM3UDd3ZFRYaXpLWU0zcUxTQjRsb3dMSUdS?= =?utf-8?B?aUdac1FQaGE2VlRiTTRpdlM4b3NKNHJVRHZRbzRlTlBLN1NSYTNBZGdia2JE?= =?utf-8?B?QVRaSVRWdTlJMHdCSVVuZHJuQkJaUm5MaXN3dXh0YzBKWWlEc0liN2VYWjhP?= =?utf-8?B?cndyNDBDMUpycFYreVZyUkZYR1VCMUc4aVdwdlpicmluNWRjMTJBdWx5Wkky?= =?utf-8?B?M0dwa3FEL0xaSi9aVEFoOUV5TE03RkhIcnR3VjZ0RGMxWk03UmE2L3c2L21N?= =?utf-8?B?dnJIclh3YkhZVHZNTGJNTjF0U1BScFRuejl4OWNHeElzUExkcHI2R2RUTXN5?= =?utf-8?B?SGh6bUN3VHFCcDRQOW5vRmRSb3BpS1VMaE9xZUxQSUdlckd2OStKUXpjQWw5?= =?utf-8?B?QXlQaGNTNStlYUROMllXbFZreit0Z3NWalV0MWN4SzMzdCtqN1JjTTFIY1Zz?= =?utf-8?B?bU41Vi9CdDFrejk0M29nWW1mSTVLUXdTTzJVM2FlNWxWbWwwRWpTMUsvQ0Nm?= =?utf-8?B?K3RNWHpyMndCKzlHR3Nzd0tGNW5VMFU1cnF6YnRac2VDYmZlTGVIYTNtRVNZ?= =?utf-8?B?ajVqa2pFZXJhOTR2a0FmYWdWZ2JxL3RPT1NDakszdUZWMTd3ZlBmZ1VacTVR?= =?utf-8?B?YWhKOTM3bDVHSGFKMUcvZ2RwWHQ2K2NlNjhkTVp5YzdXdzFHbUp2dUxnZDVm?= =?utf-8?Q?1m6G3tG9mq18rOIJt8oJnyIpI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6833b373-9a1e-4094-6bb8-08dbdc6e7b5d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 13:12:07.9714 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s4NQdo52v1bguyjIMEZm2RAPH21Ngl2d9ZUjjJBbawZg3V5QHPcsZ5Gb2uFfpmIh X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5225 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/3/2023 7:38 AM, Chengwen Feng wrote: > This driver don't care about the 'iface' value, it should use > rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. > > Signed-off-by: Chengwen Feng > --- > drivers/net/af_packet/rte_eth_af_packet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c > index 397a32db58..54a9f5f746 100644 > --- a/drivers/net/af_packet/rte_eth_af_packet.c > +++ b/drivers/net/af_packet/rte_eth_af_packet.c > @@ -1096,8 +1096,8 @@ rte_pmd_af_packet_probe(struct rte_vdev_device *dev) > */ > if (rte_kvargs_count(kvlist, ETH_AF_PACKET_IFACE_ARG) == 1) { > > - ret = rte_kvargs_process(kvlist, ETH_AF_PACKET_IFACE_ARG, > - &open_packet_iface, &sockfd); > + ret = rte_kvargs_process_opt(kvlist, ETH_AF_PACKET_IFACE_ARG, > + &open_packet_iface, &sockfd); > if (ret < 0) > goto exit; > } lets not update this driver, I think it is using kvargs unconventionally, 'iface' requires argument but driver parses it directly from kvargs. We can fix kvargs usage more properly instead of this change, I am taking a mental note for this.