From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA248A0032; Mon, 15 Nov 2021 13:47:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6CE240E01; Mon, 15 Nov 2021 13:47:10 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 6F11D40141 for ; Mon, 15 Nov 2021 13:47:08 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="233270275" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208,217";a="233270275" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 04:47:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208,217";a="454013026" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 15 Nov 2021 04:47:03 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 04:47:03 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 04:47:03 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 15 Nov 2021 04:47:03 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 15 Nov 2021 04:47:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FmLViNfd621pzml8mhsWd1fHkCSMBRe9JWeh2JAgXZYdrAZW22wPtASCFp/sMRXG1JyC37dtaJAb/Jj4asSaOjLBsGj7qpT8j2Ptw5qVPXklG91brJbQMk0gQCCRAQhC72N1bHzMJnEUtsVxUcgLlDl7lYUWXCq93gvGw2Jo+ZCjEOf1kx5WGT4nUmcD8zBTEqkOmYBW1sNJwLQy9CRO2nLgB8QHaR+Wzn8EMd/Wf8k1+AoHkV1bkLXKnrkORuNPqKRIWr/EdIS0djfa0uFXDsZrbadNevsOEPXkiyvjW0dIlZGzLaCXJWbABL7IvMNQrANZ289jhICMi6cDfghICg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dY5i+nLzTB/ZrUliX7Bl8HvWyZskUrMyrKl38XAAxyE=; b=JPzjJinxMiba/KN5IOAQE81k+dGCxk4nWDr6ABnMpsSpRHAlkobgAnRrUXMBUrwTqgUG7Rcw9GQDPZ7WIMAPjwHfrEMQN41xTymgXFB4VH4GgDvK0rhyC9Snm4Vzvvwe4FO4oVspHOQ4EvHLTMnyzom918aHNEL6wh5LDenEFsDJhoW5ospvMKdyGJDj+Qg3rlq85OFVIcMy/SLkA7yv491323YMXBbsrnQA9WKFW+je4cVh7d+jA2EiYgtakD+8NqGCxVYb54OapkIJPK5UXi7U/5fq3KBMOyOm99fw42FO67gbn47EGcMgHrGEdw7173DhK2aqw+e0q790IytL7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dY5i+nLzTB/ZrUliX7Bl8HvWyZskUrMyrKl38XAAxyE=; b=idtZHMKZ09jSwXGO5yw2Mq0b6wTbP5qwJgM5Dsw5xxP86seXKL81hSI9tTfX2U6nTBFhr1Tcngu2/kZbnR49EOpeDa1eMlZzOl8S5wHwHxj6p6JW4+ET0TKnnsTEaXK2P2X/JTYojoakKxLYh95PsMx7nsCST4zLmDS+Rv0DWe8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by MWHPR11MB1392.namprd11.prod.outlook.com (2603:10b6:300:24::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Mon, 15 Nov 2021 12:47:01 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::8ded:1b78:a4ab:1505]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::8ded:1b78:a4ab:1505%3]) with mapi id 15.20.4669.022; Mon, 15 Nov 2021 12:47:00 +0000 Content-Type: multipart/alternative; boundary="------------myfYUIb0P00h9OmMXTVpcuKe" Message-ID: Date: Mon, 15 Nov 2021 18:16:51 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.3.0 Subject: Re: [PATCH v3] app/testpmd: fix DCB in VT configuration To: Jie Wang , CC: , , , Ferruh Yigit References: <20211110090842.912936-1-jie1x.wang@intel.com> <20211115032958.2535862-1-jie1x.wang@intel.com> From: "Singh, Aman Deep" In-Reply-To: <20211115032958.2535862-1-jie1x.wang@intel.com> X-ClientProxiedBy: PN3PR01CA0007.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:95::13) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 Received: from [192.168.1.18] (223.178.208.161) by PN3PR01CA0007.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:95::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Mon, 15 Nov 2021 12:46:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5918d080-af38-4fb2-e9fa-08d9a836043b X-MS-TrafficTypeDiagnostic: MWHPR11MB1392: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:177; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UqdJycOVyNRMNAywB9dpkY/iF8HvLQt6OcYyDav46tn4np7+J5SAAe9j8SFjwH1SJKhqg1xZlrFVdhc/QFl0Spnl4R9K/cxHxkfYm6vsiXKzrjS0ZMZILv70u5mZJ9+jnYWfRlxC2FqpeqarARJy8351ATuf/1keAYuvSOszEtCi11BcXi7bg0c9Oju5oQ+1MAv9RvyRSuPHK3qQqXYp3Nd5WURF+ftcsxegf7O6sqNRaqwt4q8iSMCoyj7UOpBzQnAZkzjGAcFvopRTX6hthxO7cKZwA45gHJ0E87SdirWrpUra5zAt3WGGg6og+XA1ct2yRnMfTmHqQcMu/uWqfYkkjac3DJCOkMh5O+csm09fO+kHAmSt5bbbX1Zm+rsp9kUrnn65pEBAM2ReRQleV4Yjkbpb7r+bUyRcPxtQOEBSZol381LkKCT9ft/5lRqA2nRt4kkQyCEQP21bgO+nasV3jHjIyoFNEbkwGBcfpoeqkQvgfMCE/AfHUd24myTwAJXUlz1ZqTg22p/U5jvT1lLJ8Do/QknpjVgriI94wgTsQKtIvlgzFHWcV5fracYSGAfpI8f10oehQFlMf8UjW01xfhGZJ68AoEuZeZyDIMhEybVWOrVNWaGb62jv0ppYlcHijigCOwRKKSnwz1R5WOmSGpamiadeIrOuE4vLi34m41W3w1ovzNz49bV2/tPq9L7R0xnX+VzpOZt0+Qeo+EwxZ8p9x62g50zSkpzCic0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(53546011)(316002)(16576012)(26005)(186003)(33964004)(31686004)(6666004)(508600001)(4326008)(86362001)(2906002)(83380400001)(66476007)(66556008)(6486002)(8676002)(2616005)(82960400001)(956004)(8936002)(107886003)(66946007)(31696002)(5660300002)(36756003)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0Q1M1Z2bmExb1V5SUVkMU9jVEc5OHJ2ck9wSmxwNzA3S3c5a2JLbjFBV0hE?= =?utf-8?B?cTFIZENCWUlsL2Q3emJhckNaM3FTNWxFaDZ0VU1YcU5kM0Q1WTBBZVZmWGd4?= =?utf-8?B?ODJNdW9ONEhDb29TaDFVMFhhQzZZK3RHMUM3WENSZmhhazkzZ2lkZnhwSjU5?= =?utf-8?B?dy82KzFlNWdJK2JITDJLTEFQbG9QYnhRQnYrMG9vemJIZnlwT1EvZkc0NUNC?= =?utf-8?B?bS9FMUpiOFVxWitHQ25FalpzcHEwVUJDaW9PS0l1NUpiUVdQRXRuVXpJVUt6?= =?utf-8?B?eVg5eUF6TlBwT1JXdEdFYXVla1Q3ZTQzbVFVVDFmZGVzZ2ZmV1htQytuNWRw?= =?utf-8?B?NlVlZHY3UFMyeERxZmVoMlYzTm9Td1VzU3ljWm94czFkTGVrZDNYRDJvT2tE?= =?utf-8?B?dEVSbFJEbnhrM1ZrRUVSbXYwUWIyRlpyMUkxOSsxMlpGRTQvYlRtN2UxTW9r?= =?utf-8?B?Ky9EYXlxakM0ZXNxNU5wT2kvZ1U0UWViUEhPN3BQQnhlTDZMdG12TUVmUnZu?= =?utf-8?B?NjBYb0J0Z1h0dDhTUzJzOURNVHIwSDJCT0VmUXN1MmV3d21HbHhRRTdBdFd6?= =?utf-8?B?bUxuWXQ0QkpwMm9qc3JYczB3R2pXUkhVVUFJNnhycUxsWUovbWFUUm8vSExQ?= =?utf-8?B?T2Nsb3E3YzdtMVRBS0l5U2hETXVKbWNIbDZGbjF3aDc3N2lhVys4alV3RjZK?= =?utf-8?B?M3FOL2VqTUl6eXJuT0NlcjlXdzBqamNpS2J1V2gwZGt1S0lzSUpSK1RQblky?= =?utf-8?B?SllMTlF3SWZhaDMzMDZzdTIxb3A0RkdLT1dVdjdFMzVhYzgvSGFNc1REV3N5?= =?utf-8?B?UjV5QWozYkdIcXJyUCtwcFB1WkZxVlZ3U1lqNmRxZEcvTWJwVGNSUmg2anla?= =?utf-8?B?ZVAvU0J2SC9xZTUvdEpidHNoOXdqYVRQY0g2b1pkaThRRVdMN2E3UWhEbTdW?= =?utf-8?B?NFVxbVZmbVRHdzRxV3NHT3I1TVFDR3Q3aXVqM3BkaVFManM1MU5YYWNOb1c2?= =?utf-8?B?UzBmWmtPV3N2ZFZVSDBzMlpIaHBaSllTYUtLbnBIVGZKTzhxWGpJeE01L1NG?= =?utf-8?B?WDZGWUxVc0dEQy9QVDNHeXloWGJzK0NVcDNWYUpZbERic2NlNFpHY3FCNWhx?= =?utf-8?B?dy81eXVhQTA3eEc5UjRQbC83ZWZ3d2g3TnFDRUs2MDBhU3pyd0lyRGc1VlRm?= =?utf-8?B?S3NHeEdpMjduYXFocDdDbGd3Z29HUytxZkJDalZYTGZ0SVA5VXdSbCsyaGNw?= =?utf-8?B?WjgzZVRtTFE3WVJFRVI3S0VqeGlyUStnMmRFWFpNc0lLUVhlKytyNDd5R2pz?= =?utf-8?B?aUhJUGxqamw4bE1TTnlVaWhXRXlZSTdiNFRqYmF2ckwrNmJtSnN1Z0Y2Qnh6?= =?utf-8?B?QjhCdzZrTWRhZWhqNTZZbnlNeUZ3bnBEZGYxZERIRUsrQk9PSFVleWxoSU04?= =?utf-8?B?eWhaL0swY0J0SUE1bjZoZGlwVC9lU1FLVGFKcUtMdjE1RWFWd3VmMDlIMjlP?= =?utf-8?B?b1FKZWw4ekFFWHlZTTVDcFFvSHlXaWc5SjBnQVF4WEt0akZpZk4zRFBKeEZE?= =?utf-8?B?OHBQeE9nOUxMNmVodTg0aWp2YlFsVW8rcElNbmxMREdpS2NnTGZXU0tuNkQv?= =?utf-8?B?WEYzbEo4b2FLY2lLTGVwR3pOWmluMXBKTVR2WmVVcGpRbXBiS0o4Zm1rcStB?= =?utf-8?B?MzY0Y0YrQStKR1JlY3ZjTmc4ZHJwS3E1dlFOamh0R1JtTlJ6VEVSZWpoMnVR?= =?utf-8?B?c0hmcXpHL2JNYXEyZWZUa3BqQmtnM2UvVDA5RjJqc2NpMnJzMU5JYTUydE5F?= =?utf-8?B?UE55blRWVUx6aVNocHEvY1FqUVlWOXE1QVNRMmVyL0VGVldkSzdUSUk0OXkx?= =?utf-8?B?YWJGbnVnUFFxMXNsZGtxVlBlK2lRckJJOGVmTUF5NVN5dUo5QTkwMHA1bng0?= =?utf-8?B?WlNHVkRqR0hmSmRIR2YwVnRJVnA0OWpoK3BNcTJkRFlLQ2toQlU1VEdBTjBI?= =?utf-8?B?WnlIREpGUXZqQ1gxRnFIa2FPWncwNGpkVVdrdEY5NUdnSmxQcnRFTXdSWDRO?= =?utf-8?B?eUdZQ2VtbzhEN0NWeldocmcvQUZDR1YxaW0zZmQ5cmREeFc5SDc5cU5hNUl0?= =?utf-8?B?cmVwMHFEczd6cElZc2N1ZG4vSjNQRk5UTGZRd3hNQzZ5Z3VHdDFNUEkxVFJp?= =?utf-8?B?VzhESDBlN3dIdEVTZ0k4dEdsb1prakZIdjJkajl4TGlwazRjRW9VQzBxNjBp?= =?utf-8?Q?ATXDg3TBflM11/2FGHj4M3UDzuHWIOjSKdgW+pO+wE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5918d080-af38-4fb2-e9fa-08d9a836043b X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 12:47:00.6249 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wfgSxUg6BB3N85g2JtQmKJ8/auzErTmzTgW1Q8j6PFCB6z9F3BAlJZl4J79ib4Y5oGRFwuu1bj+oFkjPJo+CIT7iPGRlxguUNiXr4Qhl54A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1392 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------myfYUIb0P00h9OmMXTVpcuKe Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/15/2021 8:59 AM, Jie Wang wrote: > When set port DCB in VT mode enabled, it should remove RSS HASH > offload before reconfiguring the device and queues. > > Because port multi-queue mode is changed from RSS to DCB in VT. > > Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") > > Signed-off-by: Jie Wang Acked-by: Aman Deep Singh > --- > v3: > * update commit log. > * remove RSS HASh offload from DCB in VT. > v2: > * update commit log. > * remove RSS HASH offload from port->rx_conf[i].offloads. > --- > app/test-pmd/testpmd.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index a66dfb297c..c18942279a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3948,6 +3948,13 @@ init_port_dcb_config(portid_t pid, > if (retval < 0) > return retval; > port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER; > + /* remove RSS HASH offload for DCB in vt mode */ > + if (port_conf.rxmode.mq_mode == RTE_ETH_MQ_RX_VMDQ_DCB) { > + port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH; > + for (i = 0; i < nb_rxq; i++) > + rte_port->rx_conf[i].offloads &= > + ~RTE_ETH_RX_OFFLOAD_RSS_HASH; > + } > > /* re-configure the device . */ > retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf); --------------myfYUIb0P00h9OmMXTVpcuKe Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 11/15/2021 8:59 AM, Jie Wang wrote:
When set port DCB in VT mode enabled, it should remove RSS HASH
offload before reconfiguring the device and queues.

Because port multi-queue mode is changed from RSS to DCB in VT.

Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")

Signed-off-by: Jie Wang <jie1x.wang@intel.com>

Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>
---
v3:
 * update commit log.
 * remove RSS HASh offload from DCB in VT.
v2:
 * update commit log.
 * remove RSS HASH offload from port->rx_conf[i].offloads.
---
 app/test-pmd/testpmd.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index a66dfb297c..c18942279a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3948,6 +3948,13 @@ init_port_dcb_config(portid_t pid,
 	if (retval < 0)
 		return retval;
 	port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER;
+	/* remove RSS HASH offload for DCB in vt mode */
+	if (port_conf.rxmode.mq_mode == RTE_ETH_MQ_RX_VMDQ_DCB) {
+		port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
+		for (i = 0; i < nb_rxq; i++)
+			rte_port->rx_conf[i].offloads &=
+				~RTE_ETH_RX_OFFLOAD_RSS_HASH;
+	}
 
 	/* re-configure the device . */
 	retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);
--------------myfYUIb0P00h9OmMXTVpcuKe--