From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 89BC8B62 for ; Tue, 30 Oct 2018 14:48:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2018 06:47:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,444,1534834800"; d="scan'208";a="103780328" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.72]) ([10.237.220.72]) by fmsmga001.fm.intel.com with ESMTP; 30 Oct 2018 06:47:55 -0700 To: Alejandro Lucero , Thomas Monjalon Cc: eric.zhang@windriver.com, dev , "Mcnamara, John" , Allain Legacy , matt.peters@windriver.com, Stephen Hemminger , Ferruh Yigit , Andrew Rybchenko , Maxime Coquelin , Shahaf Shuler , Jerin Jacob , Hemant Agrawal , David Marchand References: <1538599994-23331-1-git-send-email-eric.zhang@windriver.com> <3464472.yQ3oHpXKXX@xps> <1870558.97lydUBT9V@xps> From: "Burakov, Anatoly" Message-ID: Date: Tue, 30 Oct 2018 13:47:55 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/3] force IOVA to a particular mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 13:48:01 -0000 On 30-Oct-18 12:02 PM, Alejandro Lucero wrote: > > > On Sun, Oct 28, 2018 at 11:04 PM Thomas Monjalon > wrote: > > 11/10/2018 12:08, Thomas Monjalon: > > +Cc more maintainers in order to collect more reviews > > > > 04/10/2018 11:19, Burakov, Anatoly: > > > On 03-Oct-18 9:53 PM, eric zhang wrote: > > > > This patchset introduces an EAL command line option "--iova-mode" > > > > to give the user a facility to force IOVA mode to a special > value. > > > > > > > > Auto detection of the IOVA mode, based on probing the bus and > IOMMU > > > > configuration, may not report the desired addressing mode > when virtual > > > > devices that are not directly attached to the bus are present. > > > > The EAL command line option "--iova-mode" can be used to > select either > > > > physical addressing('pa') or virtual addressing('va'). > > > > > > Acked-by: Anatoly Burakov > > > Rebased and applied, thanks > > > > Could not this lead to a problem if a device can not wok with the mode set? > For example, IOVA mode set to VA and IOMMU hw with less bits than those > required for the virtual addresses? > > IMO any device should be attached to a bus, and a bus should have a > function for setting IOVA mode and the --iova-mode option just allowed > with supported IOVA modes within the bus. I don't think it should work that way. It should warn the user that an incompatible IOVA mode was selected, but the user has specified an IOVA mode for a reason - it probably implies he really means it, so let him :) -- Thanks, Anatoly