From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 42DD91B864 for <dev@dpdk.org>; Thu, 10 May 2018 13:19:56 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 00CCDA80061; Thu, 10 May 2018 11:19:54 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 10 May 2018 12:19:50 +0100 To: Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org> References: <20180509094337.26112-1-thomas@monjalon.net> <20180509224313.27289-1-thomas@monjalon.net> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <ab36b2b1-5a4f-b687-1876-a945abb6e640@solarflare.com> Date: Thu, 10 May 2018 14:19:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180509224313.27289-1-thomas@monjalon.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23834.003 X-TM-AS-Result: No--3.789900-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1525951195-FLTYo6sRExg8 Subject: Re: [dpdk-dev] [PATCH v2 00/11] ethdev: fix race conditions in iterator and notifications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 10 May 2018 11:19:56 -0000 On 05/10/2018 01:43 AM, Thomas Monjalon wrote: > We have discovered some race conditions when using the port iterator > and/or the notifications recently added. > The work was done mostly with failsafe but some bugs could > be reproduced with other drivers. > These 11 patches are fixing all these issues. > The PMDs are modified to call a new function after probing each port. > > v2 (address Gaetan comments): > * rename rte_eth_dev_allocated_lock_free to rte_eth_dev_allocated_nolock > * do not use uint32_t for avoiding port id iteration overflow > (should be fixed separately with BUILD_BUG_ON) > > > Quick survey: > Do you think it is too late to merge these fixes in 18.05? > Or do you agree that these bugs really deserve to be fixed > by this series in 18.05-rc3? I have only questions and some review notes about 10/11 patch only. I think the series should be included in 18.05-rc3.