From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 315F4428CE; Tue, 4 Apr 2023 17:51:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1575440EF0; Tue, 4 Apr 2023 17:51:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BA7FA40A7E for ; Tue, 4 Apr 2023 17:51:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680623469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x4gq6pWxFZS0hD37NyqCtGVCyUuiki0z0NE52miQ1dM=; b=bAfwA73a47vOdFpvm9yk39NhWiz2dOg1IAJw4fDAaTEpQW6zVG9AY+eTnOmA0Q0hPx/j+6 eXyOtUnoP6riCczrAn9ZeoziETudwLfBW69XCYP+g3DG8knjyNKTJOwjSF/cirx4zJ/9M3 nbRTCCNrpse3pTkoWT5oVEG25V5nq70= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-7u6KHDbSOSmKRnUzYZ8avA-1; Tue, 04 Apr 2023 11:51:08 -0400 X-MC-Unique: 7u6KHDbSOSmKRnUzYZ8avA-1 Received: by mail-wr1-f70.google.com with SMTP id i25-20020adfaad9000000b002cff37de14fso3812616wrc.16 for ; Tue, 04 Apr 2023 08:51:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680623466; h=content-transfer-encoding:in-reply-to:subject:references:cc:to:from :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x4gq6pWxFZS0hD37NyqCtGVCyUuiki0z0NE52miQ1dM=; b=deDOphcLYssndNXKX1UzKDK90gOjHhBtFryoC2A/GLh11ef+VQfjWK8e7RaPQzyxKL IEHqhiqu6+nl8+w8vb5OumtFKxv10BywRDTywwoTO6ZOWpN2K8GLfCN2z/nxLMjJyYYR 7FuScR9lHrBtUNWzM+36X0GYlMwsGIe8U2cDnN0tK2+3aFv7OLZd1I+nqUTd09bU0vzV vlhYXDSPg1WDdPZTnohMXlKqEowG7gz9+r5oIUYzO4WPK9S8lSnQ6C5Oz9C5b5gbV/oA drX/V9P8wnNyiH8wRs8Bxjb096WRbMiNdYro+khSsz4FQaCAOht9A8h6+Vv8zqsA/dXC j39w== X-Gm-Message-State: AAQBX9e1Z+EZvoCowrH/ogrPk4508cXUBVInBc2wLNi61oCaIB3vBmxd iLBCBDYlU0glQ2ng2PwK64SlfIfEA8UJChHUI4Wh0iBSc7Sb0Zz5r0XZKpDUfROGydYbc+gkVQV 7JLg= X-Received: by 2002:a7b:ce16:0:b0:3ed:4b0f:5378 with SMTP id m22-20020a7bce16000000b003ed4b0f5378mr2610517wmc.27.1680623466513; Tue, 04 Apr 2023 08:51:06 -0700 (PDT) X-Google-Smtp-Source: AKy350Ytwy7ZmyxnmJSKUtezKScAHzfhYRlVCPMpAKxYucsJ9wbaXztv1pUbcWCbTvJuFLIgLwIzvQ== X-Received: by 2002:a7b:ce16:0:b0:3ed:4b0f:5378 with SMTP id m22-20020a7bce16000000b003ed4b0f5378mr2610504wmc.27.1680623466257; Tue, 04 Apr 2023 08:51:06 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.115]) by smtp.gmail.com with ESMTPSA id 3-20020a05600c228300b003ed2384566fsm15548216wmf.21.2023.04.04.08.51.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 08:51:05 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 16:51:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Kevin Traynor To: Ciara Loftus , dev@dpdk.org, "Zhang, Qi Z" Cc: thomas@monjalon.net, ferruh.yigit@xilinx.com, David Marchand , "Mcnamara, John" , Andrew Rybchenko References: <20220624102354.1516606-1-ciara.loftus@intel.com> <0fcfe78a-72c6-788d-867e-0ff554ba5004@oktetlabs.ru> <29f03d86-bc81-c39f-76b1-bb51b9999cfb@redhat.com> Subject: Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0 In-Reply-To: <29f03d86-bc81-c39f-76b1-bb51b9999cfb@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 21/12/2022 09:28, Kevin Traynor wrote: > On 21/12/2022 06:09, Andrew Rybchenko wrote: >> Hi Kevin, >> >> On 12/20/22 17:05, Kevin Traynor wrote: >>> On 24/06/2022 11:23, Ciara Loftus wrote: >>>> libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd >>>> functions. Use meson to detect if libbpf >= v0.7.0 is linked and if >>>> so, use >>>> the recommended replacement functions bpf_xdp_query_id, bpf_xdp_attach >>>> and bpf_xdp_detach which are available to use since libbpf v0.7.0. >>>> >>>> Also prevent linking with libbpf versions > v0.8.0. >>>> >>>> Signed-off-by: Ciara Loftus >>> >>> Hi Andrew/Qi (assuming Ciara is still out of office), >>> >>> I am seeing a similar issue [1] on 21.11 branch with Fedora 37 >>> (libbpf-0.8.0-2.fc37.x86_64 and libxdp-1.2.6-1.fc37.x86_64). >>> >>> This patch alone won't apply as there are other dependencies. Looking at >>> the commits in main branch, it seems like I could take all these [2] to >>> resolve the issue. With these cherry-picked the build warnings on Fedora >>> 37 are removed. >>> >>> It's a bit late to take these for DPDK 21.11.3 as I intend to release >>> later today/tomorrow, so it can be resolved for DPDK 21.11.4. >>> >>> Do the commits below look ok for backport? Main branch might be able to >>> demand user uses new libbpf/libxdp versions etc, but with stable we >>> never want to break the users existing setup when they upgrade from >>> 2X.11.n to 2X.11.n+1. >>> >>> Let me know what you think? >> >> IMO these patches are to to be backported to stable branch. > > Thanks Andrew. > >> However, af_xdp maintainers opinion is more important here. >> > > Qi, what do you think? > As F37 will be the oldest supported Fedora release from mid-May and there is no available af_xdp maintainers to comment on backports, I'm going to just squash the warnings [0] for 21.11.4. If a better fix is available for 21.11.5+ please send patches to stable ML. thanks, Kevin. [0] http://inbox.dpdk.org/stable/20230404153501.123038-1-ktraynor@redhat.com/ >>> >>> thanks, >>> Kevin. >>> >>> [1] https://paste.centos.org/view/e4eec764 >>> [2] >>> 1eb1846b1a net/af_xdp: make compatible with libbpf 0.8.0 >>> 5ff3dbe6ce net/af_xdp: add log on XDP program removal failures >>> 0ed0bc3834 net/af_xdp: avoid version-based check for program load >>> e024c7e838 net/af_xdp: avoid version-based check for shared UMEM >>> f76dc44ded net/af_xdp: make clear which libxdp version is required >>> 50b855fc47 net/af_xdp: move XDP library presence flag setting >>> >> >