From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AF9EA00BE; Tue, 29 Oct 2019 08:13:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B86E51BEDD; Tue, 29 Oct 2019 08:13:37 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id EAEF41BEB3 for ; Tue, 29 Oct 2019 08:13:35 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 014FE800069; Tue, 29 Oct 2019 07:13:34 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 29 Oct 2019 07:13:26 +0000 To: , , , John McNamara , "Marko Kovacevic" , Thomas Monjalon CC: References: <20191025143314.11162-1-pbhagavatula@marvell.com> <20191029050312.2715-1-pbhagavatula@marvell.com> <20191029050312.2715-3-pbhagavatula@marvell.com> From: Andrew Rybchenko Message-ID: Date: Tue, 29 Oct 2019 10:13:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191029050312.2715-3-pbhagavatula@marvell.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25008.003 X-TM-AS-Result: No-6.126100-8.000000-10 X-TMASE-MatchedRID: hls5oAVArl8eimh1YYHcKPZvT2zYoYOwC/ExpXrHizyRoQLwUmtovzCW p18HPoW8SjVIFO5E44BCxxedyPqGQS5rFQ7ithY8IAjxomarSPDxuhkRWK22GJ+4ziUPq4LxCYS nwnapRgXqMNZsGUCbYVTc4Z0AZzK6YlldA0POS1Lo5fsYXP0fUARryDXHx6oXV4i674aSi3yVjF 4ez76JIyscgJiSQQDeOmJZNkpbkqBwoTxwetcEI02rn9j60W9bIfZjRfGTydgAjiw/nJICh7FZt 2LwGofv3aKPvoX8bM9vcmY92rn2+U1+zyfzlN7ygxsfzkNRlfKx5amWK2anSPoLR4+zsDTtwwUc WQpWasHOuhcmTT8JljTqvtHRKEPobBbnsYWFBxwXlL1FBE1rP+SlMfpRC7IkEVJuhMxEHQzlOmi z/jY/x9tSbzvZfAXkkQ1hmLK0DWhR029mOM6P0LrcE8xytxC5d5hZXZFoB8PxWx93BSYyycC+ks T6a9fy X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--6.126100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25008.003 X-MDID: 1572333215-ga0wvm7qJwIp Subject: Re: [dpdk-dev] [PATCH v14 2/7] ethdev: add mbuf RSS update as an offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/29/19 8:03 AM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to > enable/disable PMDs write to `rte_mbuf::hash::rss`. > PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation > by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`. > > Signed-off-by: Pavan Nikhilesh > Reviewed-by: Andrew Rybchenko [snip] > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index 6ce8f5e75..fef1dbb61 100644 [snip] > @@ -1303,6 +1304,16 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, > goto rollback; > } > > + /* Check if Rx*/ > + if ((dev_conf->rxmode.mq_mode & ETH_MQ_RX_NONE) && ETH_MQ_RX_NONE is 0 so above condition is always false. It should be if ((dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) == 0 && > + (dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_RSS_HASH)) { > + RTE_ETHDEV_LOG(ERR, > + "Ethdev port_id=%u config invalid mq_mode %s with offloads %s\n", > + port_id, "ETH_MQ_RX_NONE", "DEV_RX_OFFLOAD_RSS_HASH"); I think the error message is a bit misleading. It should be: "Ethdev port_id=%u config invalid mq_mode without RSS but %s offload is requested\n" rte_eth_dev_rx_offload_name(DEV_RX_OFFLOAD_RSS_HASH) should be used to log offload name. > + ret = -EINVAL; > + goto rollback; > + } > + > /* > * Setup new number of RX/TX queues and reconfigure device. > */ [snip]