From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0430FA0C46; Tue, 11 May 2021 21:22:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78BDC4003F; Tue, 11 May 2021 21:22:23 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id B16094003E for ; Tue, 11 May 2021 21:22:21 +0200 (CEST) IronPort-SDR: nW+4eZ7DDPmCr51f+lDvkju3P5jCV3MBmA/1IInsupfsAH1kjbjSyMXXNgKNrAi+fBe1slP/Z2 1FRPTyypgl5w== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="285021620" X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="285021620" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 12:22:09 -0700 IronPort-SDR: FdmzeyLLcTmZOHxDMa1ZNxrxkCgDViCvClZvSG/sk4CTJ3mwXKPyqsY+/Y3tfw5bE1wE9gVX9L RZDWDw1t1chA== X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="537151732" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.45]) ([10.213.224.45]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 12:22:08 -0700 To: Haifei Luo , matan@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com, Xiaoyun Li Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com References: <20210428141015.25728-1-haifeil@nvidia.com> <20210511092810.22801-1-haifeil@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 11 May 2021 20:22:04 +0100 MIME-Version: 1.0 In-Reply-To: <20210511092810.22801-1-haifeil@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add CLI for action meter color X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/11/2021 10:28 AM, Haifei Luo wrote: > Currently action RTE_FLOW_ACTION_TYPE_METER_COLOR is defined. > Add the CLI for this action in meter policy: color type (types) > There are three types: green, yellow and red. > > Example for the new policy meter CLIs: > add port meter policy 0 1 g_actions color type green / end y_actions > color type yellow / end r_actions color type red / end > > In the above command, the action type is RTE_FLOW_ACTION_TYPE_METER_COLOR, > the meter policy action list: green -> green, yellow -> yellow, red -> red. > > V2: rebase the latest code. Hint: you can put the changelog as last thing in commit log after '---' marker, than it will be taken as note and will automatically removed by "git am". > > Signed-off-by: Haifei Luo > Acked-by: Ori Kam > > --- > app/test-pmd/cmdline_flow.c | 85 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 85 insertions(+) Hi Haifei, Can you please document new command in the testpmd documentation, 'testpmd_funcs.rst' has already "add port meter policy ..." command documented, you can extend it unless there is no better place to document this new command. Can you also update release notes too, there is already a block there listing new commands, this can go into same place.