From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C58E433E3; Mon, 27 Nov 2023 11:20:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 532C5402DF; Mon, 27 Nov 2023 11:20:02 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2072.outbound.protection.outlook.com [40.107.243.72]) by mails.dpdk.org (Postfix) with ESMTP id 672F540150 for ; Mon, 27 Nov 2023 11:20:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e2u6s03TeKu3fZvFdq2Lx7eJlH2iQn1ytyDbajbbfLBhnUI+SvR3QlAv+Vows/0ITS8J8MYzzytOrLuoJaFtZcOZNahjpJacEELv9Bpjlgj4ZK3/WYTQEz9jQoJix50WYitBWVe2TGG2zXCMi8Tu9JjoJ15wBAZA9n2XqbmHqp7bQVUQRcaCCIzSyuAccWoqH/id8V4KV6S2RN0grL+VEyTu/26LaA/B9s6fefkSWz58PeTRLUlugiu2/5aCkse4OTe4qcgGSElw/t0P8TpqsB3x28L/VjFkdIr1MIv5v0Atm6C7J5oTEMWRGYPP8BobgiWx+ZEqs5Ugo2w82XJqFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zkepJad09eFR0Z7U2KYdbh9ATFJpPwk4lc+Ekl44HI4=; b=Y76khJZjLsyF0wcF4Xy5vRpTZUpn8PoOpVOO1iR33jLQJxjwRwwYELehp6DHIgmDjoOjhw4cPIhv5l6NvcJLxVNQpOKSG3fpyk4hYPOMFjP28BupunNU9DAuAx2wKT09dmqlKhwiF0cWOpOfbMPyrx3ZbVy+Z7GNWjEVbtMzIMB0zC4X4QxHzcTqL2yJubyfTCTC9Z2hWn1JeaJR2tXAt/npOlbNkVxcnOZZYwC0hZKpOAxaaH8T/8NLdEROq7vVHk+KMCYjdqqsAzjqPwbcEHC5e9N+vgUbu/APX8QoZg8Mj5LqPxcoiYwDOnWSllwQIK++88Ps5EMVL9+QIANFIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zkepJad09eFR0Z7U2KYdbh9ATFJpPwk4lc+Ekl44HI4=; b=2VpXz2Z1Smq2JHDfdJEGEJuTcxE8Ezv9f+OQaz+/3Qf02nKmFbI+wdKyb9/nIWNkiLaaD2NTDW3zyEvyhM7R+IhmbsdI/0NfpjUNYBzS4C7vSBaxZJf+ew4ifiYLt9LyQV75kdUmNhX047zwA9Xg8AcGHxNgg3DLa+issjc8oqI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB5596.namprd12.prod.outlook.com (2603:10b6:510:136::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.28; Mon, 27 Nov 2023 10:19:59 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 10:19:57 +0000 Message-ID: Date: Mon, 27 Nov 2023 10:19:53 +0000 User-Agent: Mozilla Thunderbird Subject: Re: net/virtio: duplicated xstats To: Edwin Brossette , dev@dpdk.org Cc: maxime.cocquelin@dpdk.org, Olivier Matz References: Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB5596:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cad2ac1-cf32-4e58-97a9-08dbef326802 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8myeZySMuotku9x2uwQ1tfJEoy1bp9qRP/2vAXSqfUDZojtSR3hKROLRr0ACb03FmFdM184yY3uMCMEinb7GjUzxNrMsZcijve26W9PFeosiG9TbtkN6I1XJjyNZ8R2pJvRtJSNj/AVAESckgi4MMx+2rYs1fgQFmqlacA71cNK2wNg+x3lW15kVtmtgOcLtgblU+r1M22PBV2TZ4/NGiQ5YONZWLOBY5ETrlBspoVB6jq8l6AMBoeRnmQMugkTTX1ep2V9YHxdKIaGW6nYaobnzEw0wR4NLlrSOcXGXMwUdU/pdjNSKlcv3+RIaNjOdUSxZTWFAWn01Jhx2G6dBxCZqDUzh+lWMgb2iuggu1EY5hhOPkR+knD3rYlkyqGdYSRMr2iaMHRQaw6xMpI6HlaThw7IUn1h4r5gF+XywKZLOLGlxv8oi93P9z1Pvcwp+Y/WUzEH5HYIXEwJEPy5VzHaByLvi6Lsn9yudgE8S79gv08zU3xDb11LI93HZW+umKArk87tilS46xk+fWiLfDg49ZLp+KqMyZh/bS9VI06T9oW3p1D9OsafPwa67cVSXgqVBBEqaTMQf+qwWjmDlWD+Enjk7vx4Rq/CloVxRmIaWfy4E4kRGsyg1Qp6jCNZoRKLdL4dyPE0pX5UfUm0Iz8ttkATbeSo6B9tFQ+cpOElmsBLGGKgII/vKf/vDECgs X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(39860400002)(376002)(366004)(346002)(230922051799003)(230173577357003)(230273577357003)(451199024)(1800799012)(64100799003)(186009)(6666004)(8936002)(4326008)(8676002)(6512007)(31696002)(53546011)(6506007)(66476007)(66556008)(66946007)(316002)(966005)(6486002)(478600001)(2906002)(36756003)(38100700002)(41300700001)(31686004)(86362001)(26005)(44832011)(2616005)(83380400001)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWdhSFFuakdMcFg3bUt4NEVxbHprUmNvYXlaV2NIS2ppMU1UaXBtRTR3Mytp?= =?utf-8?B?ZWZGYUtIUnJWUTRBckkvODUzbkRjNSs0SUNPbks0UjZPSGtTV0NqdHpsSDAz?= =?utf-8?B?RTNvcnJFbzBWMk80ZHg4SEttZWpmM21PZXltK2wybTV6UWNzalJFK2tEdzFW?= =?utf-8?B?a2M1NS9sbHp0NUZDaWhTUnpMMFpBVXZNU1kvWUYyYVMwKzIyaWVVUWNXTnNE?= =?utf-8?B?OE9QM2h1SllzT055KzZuLzB5NXBXSko5SUdxSi9uV3cxaXZ3Rzg1eEI0dGY1?= =?utf-8?B?aC9URUpTNXZYUmFvNkNkR0pjVkM0cE4rTDUyOExKN2Y2TWhvdllTNnA3SElx?= =?utf-8?B?NUNOSEhjcktzTG1Sa3VMSXljdnoxUnBvYU9ZcEErczBURnpKZW53WTJuYUR1?= =?utf-8?B?SlZrTCtMbjBhWDFHb29lVEFnUnNMUnRzdWJoWE54NjROZ0swZ1JoWWF0R2Y0?= =?utf-8?B?SUFyMHhwczNCYXpKSk5xdEpGclJZRlN5ZGRNb1d3ditkMkp2eVdIMFFvZkxO?= =?utf-8?B?WWFITENHVTdXQU5JalBIQjZIYUNtZGhLdDh5OG12U2VVWmN6bCtwdlZQZ0tp?= =?utf-8?B?YXBIbXNpdXRmT2x2aWlMS0wveERXZmlDVmRlYVZ4TzFxSEE3enp4WmdiSGtI?= =?utf-8?B?V21ySEM1N1grUGlTWmg0UFN2Q2dwR3h4VDJzdVl2NEVJd1crMzRkVjBTQTNt?= =?utf-8?B?ZWJoNjJuT0JEYWFKdThGcUl5WE9nTHJaWG50NjdONFFRN0x3aCtFNkw3MXRF?= =?utf-8?B?Rnlwak5tRWxLc3ozSWgxdHdjRUllL2hCUkxmMkY3WDNQR3ZMTW5uNFp0VElv?= =?utf-8?B?b1QvRjFBNWUvL0lheEwzb2ZiSTU0bG9rMm5jYzJPUUNEN0hQdDUyT3pPTXM5?= =?utf-8?B?cE9MNGpXRGdpWGNkamY1RkZEU3poSElNcWl1eXAvZEVWa2hVNU96OUd6bjNq?= =?utf-8?B?M0hrLzRIY0I3b01YYkxtOXhsMG5rM2ZMTUZYdEU4NHZiSTIxUHROaTV3MVhm?= =?utf-8?B?MkNXWjlsT2pPRGZOSHNFd2pkZE96TzVEdnNaOHlENGIyWnM1Mmx1VnltMk1r?= =?utf-8?B?ZldaNUludDl3YjhMYUZUWDRkV3B6Z1I4b0xTL1ZhUVlpTkNGMEpuTUVLdDg3?= =?utf-8?B?eEx4aVJrb1g5Rm1LZ3FpSklDRThvaGRCNVRkbXhqRWNNMTRndC9XWGtPZjMx?= =?utf-8?B?ZzVXQThqUGthWks4OC9BOHgvdXZvYk5TUVBLUGpMNVpFMHBVUW5DUmw4Szhj?= =?utf-8?B?VVJGSlFXSjkrYlFPNTQ1WGh3NkJ3S040dHZHcndJdDB4QUk3a3pzM1k1c29j?= =?utf-8?B?SEdRWUJSeHVHM29qN3U2UERmK0lSTG1wZWd6bnJzdTcwaTF3VloyYVRTandy?= =?utf-8?B?ZmJXMmdDQmY3ZlpBemNnRFdEZG9yWFJDWDNVUnZBRTVoeFFEbTdlNUlHUFAx?= =?utf-8?B?SWFqWjJpU0NVQVp6Ylk5Qi9HWUJVa1cwbTNya2p5NUZycFVMVDV4WUxETTY5?= =?utf-8?B?WHIxL2tpNG9mbXlRU2YwNmRBc1B1RHVaOTNwMDdJb0g4WG9OTG9EOEY4UUZx?= =?utf-8?B?L1IxMFZnTkt6cS9WMUIrVDZBdEM4dEtpMHo4bThFcmN4MmdDTVhxMGtjdW5N?= =?utf-8?B?VUFWTWZXbm8xSXh5L2kybjBpd3Y1RUxzempPVkdRc215RkdDSkZadGE4SjZK?= =?utf-8?B?Yjk5Z0dXZk04WTdvRHZpeG83a0hiL1BEUlFOMklqSzNrRGxYUFRIK0lGK1hN?= =?utf-8?B?eTRjUy9SZUZ4N0JETlhDTkh4NWxnT2FrbzYwcEozQlJWcnNGZWtSdGhuZU9U?= =?utf-8?B?ck5WZ3NQRVk4Q096dzNLZ1BUeTNjek1ZWkFIYVhBVjhvNEFIUWR5K0tHVHRt?= =?utf-8?B?OVZFNUEyb3Y5ZThNWWRpcEdjTkYvaHl4a3FzcmI3cEZxb1JCVXY2WDRJTk1D?= =?utf-8?B?aWFFMWRUMkRJd3hWMnBYUHVzUU9XdGZsT0VlZ3hCS0x2TjF1dDNtbEx3N085?= =?utf-8?B?aDlrM2MrdnA0ZEFqdzg0NzNnUzJBRDdCSGEwdFFUUFlSZEdYZmVTVVM1TkhJ?= =?utf-8?B?Y1JUb0l3QUN5aUxHeWR3bk5XcTBsQUIrMFhGWEFzZXlTaloySmoxZHQvQnh6?= =?utf-8?Q?PzLA=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cad2ac1-cf32-4e58-97a9-08dbef326802 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 10:19:57.7853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +QdeRDJH5iiv1zejZ+q0QKzbCR/gBOr/ahKAT+2OWqR4LvqSxHIxIFxGY48zF9N6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5596 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/24/2023 9:18 AM, Edwin Brossette wrote: > Hello, > > I noticed a small inconsistency in the virtio pmd's xstats. > The stat "rx_q0_errors" appears twice. > I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" > and "tx_q0_bytes" are duplicates of "rx_q0_good_packets", > "rx_q0_good_bytes", "tx_q0_good_packets" and "tx_q0_good_bytes" > Ack, I didn't reproduce but from code I can see this inconsistency can occur. > I believe this issue probably appeared after this commit: > > f30e69b41f94: ethdev: add device flag to bypass auto-filled queue xstats > http://scm.6wind.com/vendor/dpdk.org/dpdk/commit/?id=f30e69b41f949cd4a9afb6ff39de196e661708e2 > > From what I understand, the rxq0_error stat was originally reported by > the librte. However, changes were made so it is reported by the pmd instead. > The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set to keep > the old behaviour so that every pmd could have time to adapt the change. > But it seems the flag was forgotten in the virtio pmd and as a result, > some stats are fetched at two different times when displaying xstats. > Motivation is move queue stats from "basic stats" to "xstats". 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' is a temporary flag, as you said, and when driver sets it, ethdev layer copies queue stats from basic stats to xstats. In long term expectation is driver itself implement queue stats in xstats and unset the flag, when all drivers implement this, flag will be removed. The issue with virtio is it already has queue stats in the xstats, with the flag some queue stats duplicated. It seems it is not forgotten to be removed, but it was mistake to add flag at first place. So OK to remove the flag from virtio PMD. > First in lib_rte_ethdev: > https://git.dpdk.org/dpdk/tree/lib/ethdev/rte_ethdev.c#n3266 > > (you can see the check on the RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag > before the snprintf on |eth_dev_rxq_stats_strings[]| ) > > And a second time in the virtio pmd: > https://git.dpdk.org/dpdk/tree/drivers/net/virtio/virtio_ethdev.c#n705 > pmd > (see the snprintf on|rte_virtio_rxq_stat_strings|[] ) > > This problem can be reproduced on testpmd simply by displaying the > xstats on a port with the net_virtio driver: > > Reproduction: > =========== > >     1) start dpdk-testpmd: > > modprobe -a uio_pci_generic > dpdk-devbind -b uio_pci_generic 03:00.0 > dpdk-devbind -b uio_pci_generic 04:00.0 > > dpdk-devbind -s > > Network devices using DPDK-compatible driver > ============================================ > 0000:03:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic > unused=vfio-pci > 0000:04:00.0 'Virtio 1.0 network device 1041' drv=uio_pci_generic > unused=vfio-pci > [...] > > dpdk-testpmd -a 0000:03:00.0 -a 0000:04:00.0 -- -i --rxq=1 --txq=1 > --coremask=0x4 --total-num-mbufs=250000 > EAL: Detected CPU lcores: 3 > EAL: Detected NUMA nodes: 1 > EAL: Detected static linkage of DPDK > EAL: Multi-process socket /var/run/dpdk/rte/mp_socket > EAL: Selected IOVA mode 'PA' > EAL: VFIO support initialized > EAL: Probe PCI driver: net_virtio (1af4:1041) device: 0000:03:00.0 > (socket -1) > EAL: Probe PCI driver: net_virtio (1af4:1041) device: 0000:04:00.0 > (socket -1) > Interactive-mode selected > Warning: NUMA should be configured manually by using --port-numa-config > and --ring-numa-config parameters along with --numa. > testpmd: create a new mbuf pool : n=250000, size=2176, socket=0 > testpmd: preferred mempool ops selected: ring_mp_mc > Configuring Port 0 (socket 0) > Port 0: 52:54:00:B0:8F:88 > Configuring Port 1 (socket 0) > Port 1: 52:54:00:EF:09:1F > Checking link statuses... > Done > >     2) port info: > > show port info 0 > > ********************* Infos for port 0  ********************* > MAC address: 52:54:00:B0:8F:88 > Device name: 0000:03:00.0 > Driver name: net_virtio > Firmware-version: not available > Devargs: > Connect to socket: 0 > memory allocation on the socket: 0 > Link status: up > Link speed: Unknown > Link duplex: full-duplex > Autoneg status: On > MTU: 1500 > Promiscuous mode: enabled > Allmulticast mode: disabled > Maximum number of MAC addresses: 64 > Maximum number of MAC addresses of hash filtering: 0 > VLAN offload: >   strip off, filter off, extend off, qinq strip off > No RSS offload flow type is supported. > Minimum size of RX buffer: 64 > Maximum configurable length of RX packet: 9728 > Maximum configurable size of LRO aggregated packet: 0 > Current number of RX queues: 1 > Max possible RX queues: 1 > Max possible number of RXDs per queue: 32768 > Min possible number of RXDs per queue: 32 > RXDs number alignment: 1 > Current number of TX queues: 1 > Max possible TX queues: 1 > Max possible number of TXDs per queue: 32768 > Min possible number of TXDs per queue: 32 > TXDs number alignment: 1 > Max segment number per packet: 65535 > Max segment number per MTU/TSO: 65535 > Device capabilities: 0x0( ) > Device error handling mode: none > Device private info: > guest_features: 0x110af8020 > vtnet_hdr_size: 12 > use_vec: rx-0 tx-0 > use_inorder: rx-0 tx-0 > intr_lsc: 1 > max_mtu: 9698 > max_rx_pkt_len: 1530 > max_queue_pairs: 1 > req_guest_features: 0x8000005f10ef8028 > >     3) show port xstats: > > show port xstats 0 > ###### NIC extended statistics for port 0 > rx_good_packets: 0 > tx_good_packets: 0 > rx_good_bytes: 0 > tx_good_bytes: 0 > rx_missed_errors: 0 > rx_errors: 0 > tx_errors: 0 > rx_mbuf_allocation_errors: 0 > rx_q0_packets: 0 > rx_q0_bytes: 0 > rx_q0_errors: 0      <================== > tx_q0_packets: 0 > tx_q0_bytes: 0 > rx_q0_good_packets: 0 > rx_q0_good_bytes: 0 > rx_q0_errors: 0      <================== > rx_q0_multicast_packets: 0 > rx_q0_broadcast_packets: 0 > rx_q0_undersize_packets: 0 > rx_q0_size_64_packets: 0 > rx_q0_size_65_127_packets: 0 > rx_q0_size_128_255_packets: 0 > rx_q0_size_256_511_packets: 0 > rx_q0_size_512_1023_packets: 0 > rx_q0_size_1024_1518_packets: 0 > rx_q0_size_1519_max_packets: 0 > tx_q0_good_packets: 0 > tx_q0_good_bytes: 0 > tx_q0_multicast_packets: 0 > tx_q0_broadcast_packets: 0 > tx_q0_undersize_packets: 0 > tx_q0_size_64_packets: 0 > tx_q0_size_65_127_packets: 0 > tx_q0_size_128_255_packets: 0 > tx_q0_size_256_511_packets: 0 > tx_q0_size_512_1023_packets: 0 > tx_q0_size_1024_1518_packets: 0 > tx_q0_size_1519_max_packets: 0 > > You can see the stat "rx_q0_errors" appeared twice.