From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01F3A45FF9; Mon, 6 Jan 2025 05:03:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4C0D40264; Mon, 6 Jan 2025 05:03:38 +0100 (CET) Received: from lf-2-47.ptr.blmpb.com (lf-2-47.ptr.blmpb.com [101.36.218.47]) by mails.dpdk.org (Postfix) with ESMTP id BA71D4014F for ; Mon, 6 Jan 2025 05:03:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2403070942; d=yunsilicon.com; t=1736136211; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=+iO+Ps+msuApyTDZSC+jEDTecUmMv4SStma8WSbWrtE=; b=b+MO4bkCq3ddf9b1D79/9MobhFHqAif57wbLVOLL2Pxx0aZCiOQ0I5lyqLk3HiLnMTJmQY gmolsUst8PB9QkAQ9YgdSLQygmQG/V6BzOjwolsI+gt6u4zz6FujJJHusgXR8GkxAznFyE hR9cvIb+gsDl8uHCzFvlmSBI2IaMtJ6PXRhGA/u6DcUScCKLJ6GA8siGTmvoZDOjN6uKpR xBnKR9uCZgcN/DAphLeEvz0vlD9+hQ0BYYuV5YEBlgFDdelT4QQsmfBl+2Dl8eLemjkymE HC1WUAqqlAYsFjXGDPfgGbQTIiW0TPMxns/J/z14ZQmEls5qJQilemdd7+zPgg== User-Agent: Mozilla Thunderbird Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 X-Original-From: WanRenyong Message-Id: In-Reply-To: <20250103112203.48955f38@pi5> Subject: Re: [PATCH v4 14/15] net/xsc: add ethdev infos get Received: from [127.0.0.1] ([116.231.104.97]) by smtp.feishu.cn with ESMTPS; Mon, 06 Jan 2025 12:03:28 +0800 To: "Stephen Hemminger" Cc: , , , , , , , , , Mime-Version: 1.0 X-Lms-Return-Path: References: <20250103150404.1529663-1-wanry@yunsilicon.com> <20250103150434.1529663-15-wanry@yunsilicon.com> <20250103112203.48955f38@pi5> From: "WanRenyong" Date: Mon, 6 Jan 2025 12:03:30 +0800 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2025/1/4 3:22, Stephen Hemminger wrote: > On Fri, 03 Jan 2025 23:04:35 +0800 > "WanRenyong" wrote: > >> + >> +static int >> +xsc_ethdev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *= info) >> +{ >> + struct xsc_ethdev_priv *priv =3D TO_XSC_ETHDEV_PRIV(dev); >> + >> + info->min_rx_bufsize =3D 64; >> + info->max_rx_pktlen =3D 65536; >> + info->max_lro_pkt_size =3D 0; >> + info->max_rx_queues =3D 256; >> + info->max_tx_queues =3D 1024; >> + info->rx_desc_lim.nb_max =3D 4096; >> + info->rx_desc_lim.nb_min =3D 16; >> + info->tx_desc_lim.nb_max =3D 8192; >> + info->tx_desc_lim.nb_min =3D 128; >> + >> + info->rx_queue_offload_capa =3D xsc_get_rx_queue_offloads(dev); >> + info->rx_offload_capa =3D info->rx_queue_offload_capa; >> + info->tx_offload_capa =3D xsc_get_tx_port_offloads(dev); >> + >> + info->if_index =3D priv->ifindex; >> + info->speed_capa =3D priv->xdev->link_speed_capa; >> + info->hash_key_size =3D XSC_RSS_HASH_KEY_LEN; >> + info->tx_desc_lim.nb_seg_max =3D 8; >> + info->tx_desc_lim.nb_mtu_seg_max =3D 8; >> + info->switch_info.name =3D dev->data->name; >> + info->switch_info.port_id =3D priv->representor_id; >> + return 0; >> +} >> + > Note: that driver probably won't be at all functional without info_get > but as long as each patch builds, it doesn't matter to me what order the > patchset is in. Too hard to get a working driver at each step. Agree with you.=C2=A0 When I made the patches, I had refered the the=20 suggestion of Adding a new driver in DPDK Contributor's guidelines, the=20 device info is recommanded to be placed later position. Altering the orde of the patchs is a bit of a hassle, so if it's not=20 unacceptable, I am going to leave it as is. --=20 Thanks, WanRenyong