From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DE02758C6 for ; Sat, 2 Dec 2017 00:51:16 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Dec 2017 15:51:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,347,1508828400"; d="scan'208";a="8185567" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.115]) ([10.241.225.115]) by FMSMGA003.fm.intel.com with ESMTP; 01 Dec 2017 15:51:14 -0800 To: Hemant Agrawal , Thomas Monjalon , Shreyansh Jain , Nipun Gupta , Jerin Jacob , Santosh Shukla , "John W. Linville" , Shepard Siegel , Ed Czeck , John Miller , Allain Legacy , Matt Peters , Harish Patil , Rasesh Mody , Stephen Hurd , Ajit Khaparde , Declan Doherty , Rahul Lakkireddy , Wenzhuo Lu , Marcin Wojtas Cc: dev@dpdk.org, vladz@cloudius-systems.com References: <20171201022957.64329-1-ferruh.yigit@intel.com> <20171201022957.64329-3-ferruh.yigit@intel.com> <393b75b1-bc37-3aeb-a63b-f33abff546bc@nxp.com> From: Ferruh Yigit Message-ID: Date: Fri, 1 Dec 2017 15:51:14 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <393b75b1-bc37-3aeb-a63b-f33abff546bc@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 3/7] ethdev: separate driver APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 23:51:17 -0000 On 12/1/2017 12:59 AM, Hemant Agrawal wrote: > On 12/1/2017 7:59 AM, Ferruh Yigit wrote: > > ... >> diff --git a/lib/librte_ether/rte_ethdev_driver.h b/lib/librte_ether/rte_ethdev_driver.h >> new file mode 100644 >> index 000000000..3e77d1439 >> --- /dev/null >> +++ b/lib/librte_ether/rte_ethdev_driver.h >> @@ -0,0 +1,163 @@ >> +/*- >> + * BSD LICENSE >> + * >> + * Copyright(c) 2017 Intel Corporation. All rights reserved. >> + * All rights reserved. > > You can remove one of the all rights reserved. > This is also an issue in your next patch for rte_ethdev_core.h > > Also, as Shreyansh mentioned, Why not start with SPDX tags instead of > full license text? Good idea, I will update in next version. > > ... >> +/** >> + * @internal Executes all the user application registered callbacks for >> + * the specific device. It is for DPDK internal user only. User >> + * application should not call it directly. >> + * >> + * @param dev >> + * Pointer to struct rte_eth_dev. >> + * @param event >> + * Eth device interrupt event type. >> + * @param cb_arg >> + * callback parameter. >> + * @param ret_param >> + * To pass data back to user application. >> + * This allows the user application to decide if a particular function >> + * is permitted or not. >> + * >> + * @return >> + * int >> + */ >> +int _rte_eth_dev_callback_process(struct rte_eth_dev *dev, >> + enum rte_eth_event_type event, void *cb_arg, void *ret_param); >> + >> +/** >> + * Create memzone for HW rings. > > Like all other functions, you can also add "@internal" for this as well. OK. > > Acked-by: Hemant Agrawal >