From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 8829BA493 for ; Thu, 11 Jan 2018 21:06:46 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 12:06:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,346,1511856000"; d="scan'208";a="9438654" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by fmsmga002.fm.intel.com with ESMTP; 11 Jan 2018 12:06:43 -0800 To: Neil Horman , dev@dpdk.org Cc: thomas@monjalon.net, john.mcnamara@intel.com, bruce.richardson@intel.com References: <20171201185628.16261-1-nhorman@tuxdriver.com> <20171213151728.16747-1-nhorman@tuxdriver.com> <20171213151728.16747-4-nhorman@tuxdriver.com> From: Ferruh Yigit Message-ID: Date: Thu, 11 Jan 2018 20:06:43 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20171213151728.16747-4-nhorman@tuxdriver.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCHv4 3/5] Makefiles: Add experimental tag check and warnings to trigger on use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 20:06:47 -0000 On 12/13/2017 3:17 PM, Neil Horman wrote: > Add checks during build to ensure that all symbols in the EXPERIMENTAL > version map section have __experimental tags on their definitions, and > enable the warnings needed to announce their use. Also add an > ALLOW_EXPERIMENTAL_APIS define to allow individual libraries and files > to declare the acceptability of experimental api usage > > Signed-off-by: Neil Horman > CC: Thomas Monjalon > CC: "Mcnamara, John" > CC: Bruce Richardson > --- > app/test-eventdev/Makefile | 1 + > app/test-pmd/Makefile | 1 + > drivers/event/sw/Makefile | 1 + > drivers/net/failsafe/Makefile | 1 + > drivers/net/ixgbe/Makefile | 1 + > examples/eventdev_pipeline_sw_pmd/Makefile | 1 + > examples/flow_classify/Makefile | 1 + > examples/ipsec-secgw/Makefile | 1 + > examples/service_cores/Makefile | 1 + > lib/librte_eal/bsdapp/eal/Makefile | 1 + > lib/librte_eal/linuxapp/Makefile | 2 ++ > lib/librte_eal/linuxapp/eal/Makefile | 2 ++ > lib/librte_eventdev/Makefile | 1 + > lib/librte_security/Makefile | 1 + > mk/internal/rte.compile-pre.mk | 4 ++++ > mk/toolchain/clang/rte.vars.mk | 2 +- > mk/toolchain/gcc/rte.vars.mk | 2 +- > mk/toolchain/icc/rte.vars.mk | 2 +- > 18 files changed, 23 insertions(+), 3 deletions(-) > > diff --git a/app/test-eventdev/Makefile b/app/test-eventdev/Makefile > index dcb2ac476..78bae7633 100644 > --- a/app/test-eventdev/Makefile > +++ b/app/test-eventdev/Makefile > @@ -32,6 +32,7 @@ include $(RTE_SDK)/mk/rte.vars.mk > > APP = dpdk-test-eventdev > > +CFLAGS += -DALLOW_EXPERIMENTAL_APIS Do we need this internally in DPDK? For application developers this is great, they will get warning unless explicitly stated that they are OK with it. Do we have any option than allowing them in DPDK library? And when experimental API modified the users in the DPDK library internally guaranteed to be updated. Why not globally allow this for all DPDK internally? > CFLAGS += -O3 > CFLAGS += $(WERROR_FLAGS) > <...>