From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B300A0C47; Wed, 27 Oct 2021 16:23:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E96B41151; Wed, 27 Oct 2021 16:23:19 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id AE5D840DDA for ; Wed, 27 Oct 2021 16:23:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="230118506" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="230118506" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 07:23:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="597376983" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga004.jf.intel.com with ESMTP; 27 Oct 2021 07:23:16 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 07:23:16 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 07:23:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 27 Oct 2021 07:23:16 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 27 Oct 2021 07:23:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NEn2iGi/FTMVmN+/ln0XrQ7ltsI29BSAuRY03CWBrZUANjVIAGvdpvfJu+2XNlSNIpj42OXe7I4n0Oi33hYMtpQTeVnTUVSfLvs6T1QmVWSgRbor1MbP+SozdLBqGBYgdn68xZhFkae/VUWuqaHWvLqCOe8jbX9ySNSgObMAa4QhsJrahCO8kV840vxB98nh9DctpYxxwAO5cj2ZfvSB64pKeOYWuKiCBXsbOv9ULdj4KdJINNGYiplqmoYMjqnRTPUyrLpUQQnStEexJdhKztw3NoakiXoj78yWJIQ0c9SeHJ++r8NQJitYSR49aQyU7ovuSU1+rAfjKeGC5Hq5pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2JcZ2bvGk0JTO2HZ5GpK0tlf9kmrXaN2thSv6duVhmc=; b=TEh+9PvGeov5YqKyoVZPOvgkxmcrVTgbebnPjlkeS5UTzeOOBwi+iLD3qInxqWUxJVGOu0Ko5A/B34kz9choAPQmvCo9qDBVQHG1+3ecYSHig0mDaBfTJ6refYoWotHR6d8t9Ze6gE2auyenVbiD734AlqqavDi+APF0XNRDAuVhPDCQCIBexk65VDf/mgaEtJR15hEKXt6PHhNF/LwLwb4DJzhoVRGnIxPNIKHM+EDbhMS6oVMPDf5VF4j6UohZM9MoxynP1iDzDAjl3OY0+PlAMoPIW+eLunOTk2g9ELdTJs6acnjlyiBoAH4ZIJmwgqJz+3NdPoM8GsgOcId30w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2JcZ2bvGk0JTO2HZ5GpK0tlf9kmrXaN2thSv6duVhmc=; b=amIVLrGifVXbC4ZI/tGTR7ov+/2fO7pCUOb1J9AOHMZPgwIcUTdxfFHH6s4JbL2fmyB5dFV1775fPhLyLBz6iIe3RHjM18m0evatlYWANYGvfy2zWUqWO0103fPf+K/ihvvgdrP3evogniTQ65oy0BFshI+whaxOgLIZfHAOAmU= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4870.namprd11.prod.outlook.com (2603:10b6:510:34::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct 2021 14:23:15 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.020; Wed, 27 Oct 2021 14:23:15 +0000 Message-ID: Date: Wed, 27 Oct 2021 15:23:08 +0100 Content-Language: en-US To: Apeksha Gupta , , , CC: , , References: <20211019184003.23128-2-apeksha.gupta@nxp.com> <20211021044700.12370-1-apeksha.gupta@nxp.com> <20211021044700.12370-4-apeksha.gupta@nxp.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211021044700.12370-4-apeksha.gupta@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR02CA0018.eurprd02.prod.outlook.com (2603:10a6:10:52::31) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB7PR02CA0018.eurprd02.prod.outlook.com (2603:10a6:10:52::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.22 via Frontend Transport; Wed, 27 Oct 2021 14:23:13 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: efb7430b-5906-4f84-ff56-08d99955503b X-MS-TrafficTypeDiagnostic: PH0PR11MB4870: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k6cG/o/TMw0Ry8ebNScVAWB+ngiPqCkwC2YTT9u/X3dxqDAjtHIo7Zb06VxZ4iad+KuSsgmyV9XgDoM33d3q7RdzUDS5U6wO5DvBa9iWnqVhFsaEe2YFnv86CKeaNFjIBArGmFwH5bmxxdPCWX3X686EGaQZLsZDVqpq2GniPVf3BBwL0i6CK8rzwlrnhHMRRVKIo+acEo8qeKbqBkIkjMIbilRv8Miogf4MX12bhQIhK9YIvbUOTDrkOQ1p96MdJ8n7uOAbtrLjBcnH1b+8EXD47kX/RpERORJEKyAjYnVWFu+mhnIuYGwCJmTdD2hRRaONMGvPRLasDG120HMBVWFrBzpMMQCTAt6yMXJV/dkaLsb0/dJnHYK5/MzdlmWYNN5QI9h1KKVwYNplR9egnOx7Zwxq4dW6eZuZRyLP0Pfm9yL0c7WgsPmp41+LXGwx0PeBI0ar56fVxWyBjyrw/7wmN2wTrrHdu01nmVtNgUDOrjsqLaSGItVx0P3JXr51N75LIeVOZVfreHUhqHLj7ZNQfnuB3NTsiKdgV76pAZp5hwX37jch+bP3+fjMP4x99ziuzrP5XCZEMBp5IbOVP7351cOmIZmF5yqUMtZ9ht65eAayHIl94vgp0KFswrmZTwTd5+XFhhgaoyDQfdPhHnZMj4WO1ZMkj/MOI9YpRVO4PTE9r9shL/MInPfWgjGx3uUjd0HWYtvls7WXLO20dg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38100700002)(508600001)(6666004)(31686004)(2616005)(4326008)(66556008)(5660300002)(86362001)(66946007)(4744005)(66476007)(44832011)(8936002)(83380400001)(2906002)(316002)(186003)(26005)(31696002)(16576012)(36756003)(8676002)(53546011)(956004)(6486002)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTdOMnpzK0FtMlJ2eXJ6eHBuZytBbzZ3VGxiUXlWc2c0WFJqT2JlN3RMUzdn?= =?utf-8?B?aVp6TUpUZlJJMEdNTUVpZGsrRWg2MDRZcTE4YW5RNldEN3BseWorZFpXa21q?= =?utf-8?B?dlFxZ2MwQXZMSGFPSUZvUENNUzhFMUhCT2crY2sydUxVbkxXYlhKVjcwNTkz?= =?utf-8?B?dU9iN2cvNTJsSmpFNXI1Uit5bWxId1IrWFUzdjkvQ2txbWFmSGF0aWNIWTFo?= =?utf-8?B?ZSt0NTRpYjhpT0ZJUFZ5Z2EvdWpDeFh3cDlOVVFrZG93TEpFSkVqTDU1cGJs?= =?utf-8?B?RHkwc2wrbFp5K2s1VGhBUk5WYVBzaEFDQjFXTi9NSHVsd0dzczh4UzE5ZjV0?= =?utf-8?B?WEpGb2FZMzhoQi9oSEhnMXl1NDUxTGZETmlBblNiQlFiWXBKZjloSUxBSjNX?= =?utf-8?B?VWlTL3ZqWFhkQXd5dUxXWGdhRnpqUjVqdHU2N0ZqOFVQeW9vVkN6dG1PVnk0?= =?utf-8?B?RWNXT0pRUVMrZHBoSjRUUm9aUnpDYU1TdnkxT0VZelVyMWxDTEJSalcrWlZ5?= =?utf-8?B?YWI2T1doUnN5VCs4dlRITGNvUTM1T0pwMXpDditWQlhSVzl5bWliYnBLWEwr?= =?utf-8?B?WG5wdy80U3FKMmhQSFJxZ0RFNDFnQ1UxK0ZKT3ZUMDZtTXJuOC9JMU9mRlEr?= =?utf-8?B?U3NhZTBmVlMzd0t0bnpCemlvMzk1TTc5c3Y5bG9uWDBLb3kvZGlnWVAwdVZl?= =?utf-8?B?dWFYcHV2OE1LVWtEZWpNQTRVcEwrMzdYZGxMb0RFZGxTMmJHZnNsS3VndG50?= =?utf-8?B?eGt5MS9JZnZQQjFVSGVWTUhGRGc4Q0dScC8ybWdQSnVaQW5VYkFueDI5azkr?= =?utf-8?B?T2dnMUhmbTRMK1ZubG15WE51QlAxYVU5UnpLK0M1ejhvcmJuRURKYXdHZExN?= =?utf-8?B?bFU4bnZXM2VlQURFTkJ2NEhhTVp5eWY5bGlxT0JiQXlzNWRMMWVOK0JkVnpK?= =?utf-8?B?OFJvUTkwRUFiazdYZVZabmYxSDRYd3ZOaWlmSTJxZkk4dzN4ZDhUWG9DTWJw?= =?utf-8?B?bEZ0K0ZVWVYyYVMvcThueXZOMktKWWNPSDRZZ1JUTkJMc2thVXltRGRoTms1?= =?utf-8?B?REVWdTY1TmxvMU1URkkxRGdkZkEyNEgwcGlOSzRtZ3p2STdRdUdXNDdoY3Jn?= =?utf-8?B?UmFQR0NzSzltSHhPcDFyVFhTUEZMSk52WXBwRUYyOURrYkRDYmJ1UzR2dUlP?= =?utf-8?B?ZmJyWDFSYlpPb2dUQmxSVU96SE9nT2FvL0hpSS9vNUd3UU03YVMxMVE2MVFa?= =?utf-8?B?eU1ac1hsNWkwbEtCRkJXZVFaSnBkWDRaUXdBVSt4ajJ6N0RDV1M3N0kwWjY2?= =?utf-8?B?TklrZFFFOW91Uy9RL05ESk1NSDJCOHBtelBaY00wL2g1Q0daOGpMQU1tRFV0?= =?utf-8?B?OWxHYTBNRDVEdGIxUTI3MXRxY0dqcExhejk3alhvYnloaE9QYlpFWlRiWVVQ?= =?utf-8?B?MTVESDhMSzJlcHpTMUhGZ3NBVS9od05EVGdvMi9iY1VwV2FBSEdXNm9ueEs3?= =?utf-8?B?MXF4dmxxQi9rSm9KTHd1LytQVU5LTVFvY1dWaVRTbDBFRjI2SEhIcnVJa0Zy?= =?utf-8?B?eURCYkVNVGdiZEUzUHVVcTIrNTQzNHZyWi9qRnQwMXF2QXpPUEdYZkMvTjFQ?= =?utf-8?B?Nk1wTkRtWXNweWNGa3IrNlFtUzY4MTZ1bHB0dXFNOUFFL2ZPaEtuZjNuRXBL?= =?utf-8?B?Si9kNlR5Y2dDaFVDb0VZaEF4b0lNQnZuRkxIS2Q0Sk1NYU92TUJOVXRzTzFk?= =?utf-8?B?K2VZRW5lK0FJNmNMZXhBcVRvbmNBZmR4Z214eTgrdHZ0SzRCRUZjNEFmZTFT?= =?utf-8?B?cmt0OHVOY3l4cW04a214R3RiblJ6TEJKWUZzSjJKdWl2bEx5cStzSlF2NlJP?= =?utf-8?B?Z21SK3oxcEhtZHlZcDVQamdVSG9GUS96cUF0b1ZJUlNPejlnQnR4Y25yZktk?= =?utf-8?B?WUVqb1NXZ2sxUHNoZDd4WEVwdFFWTHZCOFN5QWVtTHlXck5NdVloM0hoVENy?= =?utf-8?B?alRDZXlWTnZsRW5EQnhGUUk5dTVkR21xdEJqTHpOMy9XUWhUaW1OVkwrTnRE?= =?utf-8?B?SnQwNjF0K003b0lBdk43bzR2UjdYMGNESlBKbG40eTYzbFI0VEZIZFpXOE5w?= =?utf-8?B?RUZrbUdHK3dGSlVtTThEQzh5aXVPZi9EMGJFNEw4M05SY2JDU3VFVEVhMGtl?= =?utf-8?Q?qyY3K5D1s9jg+EdXY+eNWOc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: efb7430b-5906-4f84-ff56-08d99955503b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 14:23:14.9294 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kda0CVrRImuhXm5ma7hZVHJB6xUwnf844Ri/tC4yp0duJK3JC9LpdUsPbV7w0UYfXoiKiPka5A5+DV+3G9y31Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4870 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 3/5] net/enetfec: support queue configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/21/2021 5:46 AM, Apeksha Gupta wrote: > This patch adds Rx/Tx queue configuration setup operations. > On packet reception the respective BD Ring status bit is set > which is then used for packet processing. > > Signed-off-by: Sachin Saxena > Signed-off-by: Apeksha Gupta <...> > > +/* Supported Rx offloads */ > +static uint64_t dev_rx_offloads_sup = > + DEV_RX_OFFLOAD_IPV4_CKSUM | > + DEV_RX_OFFLOAD_UDP_CKSUM | > + DEV_RX_OFFLOAD_TCP_CKSUM | > + DEV_RX_OFFLOAD_VLAN_STRIP | > + DEV_RX_OFFLOAD_CHECKSUM; > + > +static uint64_t dev_tx_offloads_sup = > + DEV_TX_OFFLOAD_IPV4_CKSUM | > + DEV_TX_OFFLOAD_UDP_CKSUM | > + DEV_TX_OFFLOAD_TCP_CKSUM; > + The macro names are updated in ethdev, can you please update them? Also these offloads are advertised, but some of them are not checked anywhere in the driver, like 'DEV_TX_OFFLOAD_*_CKSUM'. Are they really supported? If they are not supported in the datapath, please don't advertise them.