From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gaetan.rivet@6wind.com>
Received: from mail-wr0-f182.google.com (mail-wr0-f182.google.com
 [209.85.128.182]) by dpdk.org (Postfix) with ESMTP id F20F27CB8
 for <dev@dpdk.org>; Fri,  7 Jul 2017 02:04:56 +0200 (CEST)
Received: by mail-wr0-f182.google.com with SMTP id r103so24311319wrb.0
 for <dev@dpdk.org>; Thu, 06 Jul 2017 17:04:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :in-reply-to:references;
 bh=6MrGr2vU8CONXU1KobjjPw+OI+z/f1LX9g1D23oTHJ8=;
 b=F2Jrw/oiIXUc2vmAjoB1QsMhAGuEqSv9OzjHoyDx/0xCFqcAsxNKOJp3LDNoQCNPWO
 7pyU9PuCl3z0ghxvtwa+WXpUeqyfaT3UQxhvQWnclqXnSXbS2nXb9nyE9s7E7Y4kapiy
 qrbn1O9Nqhbws0LTAZtYOfQ7o6qcBoIqed0If8sDDkq0CSIkWDdGeu75QYpYzdCKFj2S
 1TRa6yocIdVYphqnxPTyMyyAe/B+FzwxoR0h4mgXfCLit2FWwbIMnB9dVswpEwgFSkO9
 2PtKksH56AYnF6Mo/NLgyUDUYOweM7Y1zAOeAi640UcWKkmVgJxKxU/sQXBq7grK4yZ7
 AZMA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:in-reply-to:references;
 bh=6MrGr2vU8CONXU1KobjjPw+OI+z/f1LX9g1D23oTHJ8=;
 b=txonbT1UrNTM1DkD9Al9lpCTgTY+si4gbCNHZaJd+yfswiZQhMUYSdhDNCH0pj6IJ5
 Teg4t0Y0CC36LoLQI48at31HwZwLYLoFhgrXwXRTwPcpaWkNdrIy5tYMaURvjrPhLWbx
 PSMhIhtkO2xgFoD/8Bgb3JHyz4WyGdPbIdpgLSY9xmcEMD3MgLhnyB67WEg8IjDa5ABW
 aq3CjA39pn5XSUeJj31NvhaTxUqnSi7eVXhb0e3FgAIRwIcuFi1lw+FgY2N2B3H98uSm
 wyz1sjKayFjsnOWdhzYyaX7LM44coMiXlDzEtIVXWgPTBrLO2K8TwN+ZmZFN7CDu4OtA
 +TJw==
X-Gm-Message-State: AIVw113eTM5nORueSG6xPBFEJLC+XZTQeoYJikAxtR+KzBRSwBE+aP1x
 S7NrgWKtdEGoONxtSOo=
X-Received: by 10.28.142.138 with SMTP id q132mr250844wmd.75.1499385896433;
 Thu, 06 Jul 2017 17:04:56 -0700 (PDT)
Received: from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.
 [62.23.145.78])
 by smtp.gmail.com with ESMTPSA id b197sm1111520wmb.4.2017.07.06.17.04.55
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
 Thu, 06 Jul 2017 17:04:55 -0700 (PDT)
From: Gaetan Rivet <gaetan.rivet@6wind.com>
To: dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>
Date: Fri,  7 Jul 2017 02:04:26 +0200
Message-Id: <abcd675ae0239db11303aa2066ea849f5c2a3481.1499384590.git.gaetan.rivet@6wind.com>
X-Mailer: git-send-email 2.1.4
In-Reply-To: <cover.1499384589.git.gaetan.rivet@6wind.com>
References: <cover.1499211959.git.gaetan.rivet@6wind.com>
 <cover.1499384589.git.gaetan.rivet@6wind.com>
In-Reply-To: <cover.1499384589.git.gaetan.rivet@6wind.com>
References: <cover.1499384589.git.gaetan.rivet@6wind.com>
Subject: [dpdk-dev] [PATCH v7 09/17] examples/ethtool: properly reference
	PCI header
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Jul 2017 00:04:57 -0000

From: Thomas Monjalon <thomas@monjalon.net>

In devargs rework, rte_pci.h won't be included by rte_ethdev.h
(via rte_devargs.h) anymore.

rte_ethtool_get_drvinfo() could use rte_devargs.name instead of
creating equivalent bus specific name.
For now, it is workarounded by just including rte_pci.h.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 examples/ethtool/lib/rte_ethtool.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
index fabfcb2..252382c 100644
--- a/examples/ethtool/lib/rte_ethtool.c
+++ b/examples/ethtool/lib/rte_ethtool.c
@@ -36,6 +36,7 @@
 #include <rte_version.h>
 #include <rte_ethdev.h>
 #include <rte_ether.h>
+#include <rte_pci.h>
 #ifdef RTE_LIBRTE_IXGBE_PMD
 #include <rte_pmd_ixgbe.h>
 #endif
@@ -73,6 +74,7 @@ rte_ethtool_get_drvinfo(uint8_t port_id, struct ethtool_drvinfo *drvinfo)
 		dev_info.driver_name);
 	snprintf(drvinfo->version, sizeof(drvinfo->version), "%s",
 		rte_version());
+	/* TODO: replace bus_info by rte_devargs.name */
 	if (dev_info.pci_dev)
 		snprintf(drvinfo->bus_info, sizeof(drvinfo->bus_info),
 			"%04x:%02x:%02x.%x",
-- 
2.1.4