From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 163462C49 for ; Thu, 9 Mar 2017 11:01:49 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2017 02:01:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,268,1486454400"; d="scan'208";a="74618395" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.33.82]) ([10.254.33.82]) by fmsmga006.fm.intel.com with ESMTP; 09 Mar 2017 02:01:46 -0800 To: "Xing, Beilei" , "Wu, Jingjing" References: <1488533497-27682-1-git-send-email-beilei.xing@intel.com> <1488533497-27682-2-git-send-email-beilei.xing@intel.com> <94479800C636CB44BD422CB454846E01315A7CF0@SHSMSX101.ccr.corp.intel.com> Cc: "Zhang, Helin" , "dev@dpdk.org" , "Iremonger, Bernard" , "Stroe, Laura" From: Ferruh Yigit Message-ID: Date: Thu, 9 Mar 2017 10:01:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <94479800C636CB44BD422CB454846E01315A7CF0@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/4] net/i40e: support replace filter type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 10:01:50 -0000 On 3/9/2017 5:59 AM, Xing, Beilei wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Wednesday, March 8, 2017 11:50 PM >> To: Xing, Beilei ; Wu, Jingjing >> Cc: Zhang, Helin ; dev@dpdk.org; Iremonger, >> Bernard ; Stroe, Laura >> >> Subject: Re: [dpdk-dev] [PATCH 1/4] net/i40e: support replace filter type >> >> On 3/3/2017 9:31 AM, Beilei Xing wrote: >>> Add new admin queue function and extended fields in DCR 288: >>> - Add admin queue function for Replace filter >>> command (Opcode: 0x025F) >>> - Add General fields for Add/Remove Cloud filters >>> command >>> >>> This patch will be removed to base driver in future. >>> >>> Signed-off-by: Bernard Iremonger >>> Signed-off-by: Stroe Laura >>> Signed-off-by: Jingjing Wu >>> Signed-off-by: Beilei Xing >>> --- >>> drivers/net/i40e/i40e_ethdev.h | 106 ++++++++++++++++++++++++++++ >>> drivers/net/i40e/i40e_flow.c | 152 >> +++++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 258 insertions(+) >>> >>> diff --git a/drivers/net/i40e/i40e_ethdev.h >>> b/drivers/net/i40e/i40e_ethdev.h index f545850..3a49865 100644 >>> --- a/drivers/net/i40e/i40e_ethdev.h >>> +++ b/drivers/net/i40e/i40e_ethdev.h >>> @@ -729,6 +729,100 @@ struct i40e_valid_pattern { >>> parse_filter_t parse_filter; >>> }; >>> >>> +/* Support replace filter */ >>> + >>> +/* i40e_aqc_add_remove_cloud_filters_element_big_data is used when >>> + * I40E_AQC_ADD_REM_CLOUD_CMD_BIG_BUFFER flag is set. refer to >>> + * DCR288 >> >> Please do not refer to DCR, unless you can provide a public link for it. > OK, got it. > >> >>> + */ >>> +struct i40e_aqc_add_remove_cloud_filters_element_big_data { >>> + struct i40e_aqc_add_remove_cloud_filters_element_data element; >> >> What is the difference between >> "i40e_aqc_add_remove_cloud_filters_element_big_data" and >> "i40e_aqc_add_remove_cloud_filters_element_data", why need big_data >> one? > > As ' Add/Remove Cloud filters -command buffer ' is changed in the DCR288, 'general fields' exists only when big_buffer is set. What does it mean having "big_buffer" set? What changes functionally being big_buffer set or not? > But we don't want to change the " i40e_aqc_add_remove_cloud_filters_element_data " as it will cause ABI/API change in kernel driver. > <...>