From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BE2FA0A02; Wed, 13 Jan 2021 21:27:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05E52140D25; Wed, 13 Jan 2021 21:27:23 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 2CA35140D22; Wed, 13 Jan 2021 21:27:20 +0100 (CET) IronPort-SDR: F/xqTz+2RvIDv/ykwreArv6D4BhJp4I+JtjDAHzjdLo39qUbzKPXfZi7TaloPPlL3jdAal2BiN mWFkcAKV4VQA== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="263055719" X-IronPort-AV: E=Sophos;i="5.79,345,1602572400"; d="scan'208";a="263055719" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 12:27:19 -0800 IronPort-SDR: eytCUzDf9EuAPiu+O3zkcibGwPx1AVxd8PY+tXxV2aRK4Tn+wNrm/47WlmHYxLEZruszhXJWns jp4tbmceUY2g== X-IronPort-AV: E=Sophos;i="5.79,345,1602572400"; d="scan'208";a="499376251" Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253]) ([10.166.30.253]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 12:27:19 -0800 To: Dmitry Kozlyuk , dev@dpdk.org Cc: Olivier Matz , Bruce Richardson , stable@dpdk.org References: <20210112003602.29004-1-dmitry.kozliuk@gmail.com> From: Ranjit Menon Message-ID: Date: Wed, 13 Jan 2021 12:27:18 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20210112003602.29004-1-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] build: fix using ELF-only linker flags with COFF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote: > The --export-dynamic linker option is only applicable to ELF. > On Windows, where COFF is used, it causes warnings: > > x86_64-w64-mingw32-ld: warning: --export-dynamic is not supported > for PE+ targets, did you mean --export-all-symbols? (MinGW) > > LINK : warning LNK4044: unrecognized option '/-export-dynamic'; > ignored (clang) > > Don't add --export-dynamic on Windows anywhere. > > Fixes: b031e13d7f0d ("build: fix plugin load on static build") > Cc: stable@dpdk.org > > Signed-off-by: Dmitry Kozlyuk > --- > Using TLS variables with DLLs is problematic on Windows for now, > so not attempting to check or solve the issue with plugin load. > > app/meson.build | 2 +- > buildtools/pkg-config/meson.build | 6 +++++- > examples/meson.build | 2 +- > 3 files changed, 7 insertions(+), 3 deletions(-) Acked-by: Ranjit Menon